From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, 50424@debbugs.gnu.org, alan@idiocy.org
Subject: bug#50424: 27.2; Tab bar button mouse face not clearing entirely
Date: Mon, 13 Sep 2021 10:59:12 +0300 [thread overview]
Message-ID: <877dfkhpnz.fsf@mail.linkov.net> (raw)
In-Reply-To: <835yv5g3rp.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Sep 2021 19:25:14 +0300")
tags 50424 fixed
close 50424 28.0.50
quit
>> > If we want the default value of tab-bar-button-margin to be a cons
>> > cell, let's change the default value to be a cons cell, it's not more
>> > complicated than setting it to a scalar, even in C. But tab-bar.el
>> > should use in its image specs the exact value of
>> > tab-bar-button-margin, it cannot decide to change it behind the back
>> > of the caller.
>>
>> I tried a cons cell, but it looks ugly for buttons other than the close button.
>> OTOH, margin 1 looks nice for all buttons:
>
> Fine by me.
So pushed to master.
>> -#define DEFAULT_TAB_BAR_BUTTON_MARGIN 4
>> +#define DEFAULT_TAB_BAR_BUTTON_MARGIN 1
>> #define DEFAULT_TAB_BAR_BUTTON_RELIEF 1
>
> Btw, I don't see much sense in keeping the
> DEFAULT_TAB_BAR_BUTTON_MARGIN macro: it's used in one place only,
> AFAICT, so we could simply have it there literally.
I thought about this too, but it will break the symmetry with
DEFAULT_TOOL_BAR_BUTTON_MARGIN and DEFAULT_TOOL_BAR_BUTTON_RELIEF when
DEFAULT_TAB_BAR_BUTTON_MARGIN will be used in more places.
next prev parent reply other threads:[~2021-09-13 7:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87eea2cebb.fsf.ref@yahoo.com>
2021-09-06 8:12 ` bug#50424: 27.2; Tab bar button mouse face not clearing entirely Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 10:50 ` Eli Zaretskii
2021-09-06 11:31 ` Stephen Berman
2021-09-06 11:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 12:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 12:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 17:39 ` Eli Zaretskii
2021-09-07 0:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-07 10:41 ` Eli Zaretskii
2021-09-07 13:02 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-07 13:12 ` Eli Zaretskii
2021-09-07 23:13 ` Alan Third
2021-09-08 6:05 ` Eli Zaretskii
2021-09-08 16:57 ` Alan Third
2021-09-11 12:11 ` Eli Zaretskii
2021-09-11 18:49 ` Juri Linkov
2021-09-11 19:41 ` Eli Zaretskii
2021-09-11 19:45 ` Juri Linkov
2021-09-12 3:46 ` Eli Zaretskii
2021-09-12 6:05 ` Eli Zaretskii
2021-09-12 7:06 ` Juri Linkov
2021-09-12 8:35 ` Eli Zaretskii
2021-09-12 16:06 ` Juri Linkov
2021-09-12 16:25 ` Eli Zaretskii
2021-09-13 7:59 ` Juri Linkov [this message]
2021-09-13 11:59 ` Eli Zaretskii
2021-09-11 19:43 ` Juri Linkov
2021-09-12 3:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dfkhpnz.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=50424@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).