From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Date: Mon, 15 Nov 2021 15:02:53 +0200 Message-ID: <83y25pshaa.fsf@gnu.org> References: <87bl2nhbyp.fsf@163.com> <83bl2nugao.fsf@gnu.org> <878rxq62qt.fsf@gnus.org> <83k0hatxjl.fsf@gnu.org> <875ysu2d18.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28106"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tumashu@163.com, 51821@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 15 14:04:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmbez-00078R-0w for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Nov 2021 14:04:33 +0100 Original-Received: from localhost ([::1]:50302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmbey-00053p-2u for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Nov 2021 08:04:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmbeV-0004uv-Pb for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 08:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmbeT-000771-W0 for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 08:04:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmbeT-0007IZ-SC for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 08:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Nov 2021 13:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51821 X-GNU-PR-Package: emacs Original-Received: via spool by 51821-submit@debbugs.gnu.org id=B51821.163698139828002 (code B ref 51821); Mon, 15 Nov 2021 13:04:01 +0000 Original-Received: (at 51821) by debbugs.gnu.org; 15 Nov 2021 13:03:18 +0000 Original-Received: from localhost ([127.0.0.1]:52937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmbdl-0007Ha-TT for submit@debbugs.gnu.org; Mon, 15 Nov 2021 08:03:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmbdk-0007HH-Ez for 51821@debbugs.gnu.org; Mon, 15 Nov 2021 08:03:16 -0500 Original-Received: from [2001:470:142:3::e] (port=33240 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmbde-00070a-2W; Mon, 15 Nov 2021 08:03:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=p69/s3tJvdIZz0uePOcUebz/QEOXLrovBAgot5NgUZM=; b=nFoa1FtF5dpJ jcVsQXJAWZZe7GtN9grqw/0oHE0S3SnxM9n9/ZZA/K4Z3u7oG3MJF1sno7dH/uzk4R2s+V8bicmqd TD6bBE5mLuLuAI+Yt5zXZR1udN60i3HAEThr/XIzhNK6eZgta3Sjt19Sjv5yXemkzeY25xcT0UdiR I/WSrruzGAdjXs010R8xYjeHJ57Cm4YkYPJQB32Mj+2o15cV8xF7FDJT0/y8ILci4eUcAbxZOUYyg F73rvyKKdhT5s08vijSX0wCQVVGg0M69A9Xk4WDaHj0ZHH5XdxVl2mlSjmP560kYScd43+yKWzbne nElGJsYCJMcv/Pk5Rk/Sfg==; Original-Received: from [87.69.77.57] (port=2806 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmbdY-0001GQ-Gd; Mon, 15 Nov 2021 08:03:08 -0500 In-Reply-To: <875ysu2d18.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 15 Nov 2021 06:39:15 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220052 Archived-At: > From: Lars Ingebrigtsen > Cc: tumashu@163.com, 51821@debbugs.gnu.org > Date: Mon, 15 Nov 2021 06:39:15 +0100 > > It has to work across different fonts -- I think that's the real use > case here, that if you're missing different fonts (which you commonly > are when writing with different scripts), then the Emacs display gets > pretty messy (uneven line heights all over the place). You mean, because of "tofu"? But tofu doesn't change the line height, AFAIK. So I think I'm missing something. > * After redisplay has composed a line, it should check whether the line > height is less than `line-height', and if so, add empty space at the > bottom (or the top, or perhaps both, to center it). > > ** But -- if the line is composed purely of text with a face with an > explicit :height property, it should do nothing. The last part ruins it all. I guess you are thinking about faces in their 'defface' form? But when a face gets to be used by the display code, it is converted to the internal form and always completely specified, and thus always has an explicit :height property already calculated. And of course the default face must always be completely specified at this point.