* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
@ 2020-11-19 22:24 Stefan Kangas
2020-11-20 8:35 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 24+ messages in thread
From: Stefan Kangas @ 2020-11-19 22:24 UTC (permalink / raw)
To: 44743; +Cc: akrl
Severity: minor
Steps to reproduce, on the native-comp branch:
0. rm -rf ~/.emacs.d/eln-cache
1. emacs -Q
2. C-x C-c
3. Press "y" (I am sure I want to quit)
A prompt is now shown with this text:
"Active processes exist; kill them and exit anyway? (y or n) "
The processes are all native-comp processes.
Expected result: No prompt is shown. The native-comp processes are
recognized and killed automatically.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2020-11-19 22:24 bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling Stefan Kangas
@ 2020-11-20 8:35 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-20 11:35 ` Eli Zaretskii
0 siblings, 1 reply; 24+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-11-20 8:35 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 44743
Stefan Kangas <stefan@marxist.se> writes:
> Severity: minor
>
> Steps to reproduce, on the native-comp branch:
>
> 0. rm -rf ~/.emacs.d/eln-cache
> 1. emacs -Q
> 2. C-x C-c
> 3. Press "y" (I am sure I want to quit)
>
> A prompt is now shown with this text:
> "Active processes exist; kill them and exit anyway? (y or n) "
>
> The processes are all native-comp processes.
>
> Expected result: No prompt is shown. The native-comp processes are
> recognized and killed automatically.
Hi Stefan,
I agree this would be nice to have.
I'm a little underwater ATM as I'm trying to progress on other features,
fill free to pick it up if you feel/like.
Thanks
Andrea
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2020-11-20 8:35 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-11-20 11:35 ` Eli Zaretskii
2020-11-21 19:22 ` Stefan Kangas
2020-11-24 7:52 ` Lars Ingebrigtsen
0 siblings, 2 replies; 24+ messages in thread
From: Eli Zaretskii @ 2020-11-20 11:35 UTC (permalink / raw)
To: Andrea Corallo; +Cc: stefan, 44743
> Cc: 44743@debbugs.gnu.org
> Date: Fri, 20 Nov 2020 08:35:49 +0000
> From: Andrea Corallo via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> > 0. rm -rf ~/.emacs.d/eln-cache
> > 1. emacs -Q
> > 2. C-x C-c
> > 3. Press "y" (I am sure I want to quit)
> >
> > A prompt is now shown with this text:
> > "Active processes exist; kill them and exit anyway? (y or n) "
> >
> > The processes are all native-comp processes.
> >
> > Expected result: No prompt is shown. The native-comp processes are
> > recognized and killed automatically.
>
> Hi Stefan,
>
> I agree this would be nice to have.
FWIW, I think this should be controlled by a user option. It is not
at all obvious that everyone would like compilation processes to be
killed automatically, people might want to wait for them to complete.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2020-11-20 11:35 ` Eli Zaretskii
@ 2020-11-21 19:22 ` Stefan Kangas
2020-11-21 19:47 ` Eli Zaretskii
2020-11-24 7:52 ` Lars Ingebrigtsen
1 sibling, 1 reply; 24+ messages in thread
From: Stefan Kangas @ 2020-11-21 19:22 UTC (permalink / raw)
To: Eli Zaretskii, Andrea Corallo; +Cc: 44743
Eli Zaretskii <eliz@gnu.org> writes:
>> > Expected result: No prompt is shown. The native-comp processes are
>> > recognized and killed automatically.
>>
>> I agree this would be nice to have.
>
> FWIW, I think this should be controlled by a user option. It is not
> at all obvious that everyone would like compilation processes to be
> killed automatically, people might want to wait for them to complete.
Compiling in the background should in my opinion work as transparently
as possible. The fact that we cache compilation results should be
considered an implementation detail. We don't need to shape our
outwardly behavior by such implementation details.
We could of course support what you suggest. I'm not against it as an
option. But I don't think it is very important, and it would take some
time and effort to implement and maintain. I'm not sure that effort is
well-spent at this point, and would rather leave it for the future.
IOW, I think we should work on reasonable defaults first, and only add
options in later once we are sure that we really need them.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2020-11-21 19:22 ` Stefan Kangas
@ 2020-11-21 19:47 ` Eli Zaretskii
2020-11-21 20:35 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 24+ messages in thread
From: Eli Zaretskii @ 2020-11-21 19:47 UTC (permalink / raw)
To: Stefan Kangas; +Cc: akrl, 44743
> From: Stefan Kangas <stefan@marxist.se>
> Date: Sat, 21 Nov 2020 11:22:58 -0800
> Cc: 44743@debbugs.gnu.org
>
> > FWIW, I think this should be controlled by a user option. It is not
> > at all obvious that everyone would like compilation processes to be
> > killed automatically, people might want to wait for them to complete.
>
> Compiling in the background should in my opinion work as transparently
> as possible. The fact that we cache compilation results should be
> considered an implementation detail. We don't need to shape our
> outwardly behavior by such implementation details.
I understand your opinion, but I don't think that's the only opinion
that could exist. Caching the compiled modules can hardly be regarded
as an implementation detail when compilation takes a tangible amount
of time -- which is why we cache the results in the first place. IOW,
if compilation is interrupted, Emacs will try to compile it again the
next time, and the code will run slower than expected. So if this is
an implementation detail, it will be acutely obvious to users, and
they may wish to wait a bit with exiting Emacs to let the compilation
run to the end. It is not unlike the case where you sent an email
message and want to exit Emacs before the message transmission has
ended. Users will appreciate a degree of control in these cases.
> We could of course support what you suggest. I'm not against it as an
> option. But I don't think it is very important, and it would take some
> time and effort to implement and maintain. I'm not sure that effort is
> well-spent at this point, and would rather leave it for the future.
I think interrupting compilation also comes with maintenance
head-aches, such as the temporary files left behind, incomplete .eln
files we'd need to clean up, etc.
> IOW, I think we should work on reasonable defaults first, and only add
> options in later once we are sure that we really need them.
I think the argument is about what is "reasonable" here, all the rest
is agreed upon.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2020-11-21 19:47 ` Eli Zaretskii
@ 2020-11-21 20:35 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 24+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-11-21 20:35 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Stefan Kangas, 44743
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Stefan Kangas <stefan@marxist.se>
>> Date: Sat, 21 Nov 2020 11:22:58 -0800
>> Cc: 44743@debbugs.gnu.org
>>
>> > FWIW, I think this should be controlled by a user option. It is not
>> > at all obvious that everyone would like compilation processes to be
>> > killed automatically, people might want to wait for them to complete.
>>
>> Compiling in the background should in my opinion work as transparently
>> as possible. The fact that we cache compilation results should be
>> considered an implementation detail. We don't need to shape our
>> outwardly behavior by such implementation details.
>
> I understand your opinion, but I don't think that's the only opinion
> that could exist. Caching the compiled modules can hardly be regarded
> as an implementation detail when compilation takes a tangible amount
> of time -- which is why we cache the results in the first place. IOW,
> if compilation is interrupted, Emacs will try to compile it again the
> next time, and the code will run slower than expected. So if this is
> an implementation detail, it will be acutely obvious to users, and
> they may wish to wait a bit with exiting Emacs to let the compilation
> run to the end. It is not unlike the case where you sent an email
> message and want to exit Emacs before the message transmission has
> ended. Users will appreciate a degree of control in these cases.
>
>> We could of course support what you suggest. I'm not against it as an
>> option. But I don't think it is very important, and it would take some
>> time and effort to implement and maintain. I'm not sure that effort is
>> well-spent at this point, and would rather leave it for the future.
>
> I think interrupting compilation also comes with maintenance
> head-aches, such as the temporary files left behind, incomplete .eln
> files we'd need to clean up, etc.
>
>> IOW, I think we should work on reasonable defaults first, and only add
>> options in later once we are sure that we really need them.
>
> I think the argument is about what is "reasonable" here, all the rest
> is agreed upon.
I also think this option should be controlled by a customize.
I can picture most "power users" legitimately willing to be informed of
these processes being killed if present at exit. OTOH I guess the
majority of non "power users" would like just to close Emacs
transparently.
Because of this my idea I think I'm for the transparent behavior as
default.
Andrea
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2020-11-20 11:35 ` Eli Zaretskii
2020-11-21 19:22 ` Stefan Kangas
@ 2020-11-24 7:52 ` Lars Ingebrigtsen
2020-11-24 15:42 ` Eli Zaretskii
1 sibling, 1 reply; 24+ messages in thread
From: Lars Ingebrigtsen @ 2020-11-24 7:52 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Andrea Corallo, stefan, 44743
Eli Zaretskii <eliz@gnu.org> writes:
> FWIW, I think this should be controlled by a user option. It is not
> at all obvious that everyone would like compilation processes to be
> killed automatically, people might want to wait for them to complete.
Since this is something that Emacs does automatically, in the
background, I don't think a user option sounds like something somebody
would want to tweak. If somebody has a use case for that, it can be
added later.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2020-11-24 7:52 ` Lars Ingebrigtsen
@ 2020-11-24 15:42 ` Eli Zaretskii
2020-11-24 16:08 ` Stefan Kangas
0 siblings, 1 reply; 24+ messages in thread
From: Eli Zaretskii @ 2020-11-24 15:42 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: akrl, stefan, 44743
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Andrea Corallo <akrl@sdf.org>, stefan@marxist.se, 44743@debbugs.gnu.org
> Date: Tue, 24 Nov 2020 08:52:18 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > FWIW, I think this should be controlled by a user option. It is not
> > at all obvious that everyone would like compilation processes to be
> > killed automatically, people might want to wait for them to complete.
>
> Since this is something that Emacs does automatically, in the
> background, I don't think a user option sounds like something somebody
> would want to tweak.
IMO, we should offer an option precisely _because_ this is in
background, thus the user could be unaware of the compilation being
run. Since compilation takes non-negligible time, I envision users
who'd like to wait for a few moments if that gave them faster Lisp
next time.
This is not unlike background subprocesses about which we do ask on
exit.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2020-11-24 15:42 ` Eli Zaretskii
@ 2020-11-24 16:08 ` Stefan Kangas
2020-11-24 16:29 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-24 16:36 ` Eli Zaretskii
0 siblings, 2 replies; 24+ messages in thread
From: Stefan Kangas @ 2020-11-24 16:08 UTC (permalink / raw)
To: Eli Zaretskii, Lars Ingebrigtsen; +Cc: akrl, 44743
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Cc: Andrea Corallo <akrl@sdf.org>, stefan@marxist.se, 44743@debbugs.gnu.org
>> Date: Tue, 24 Nov 2020 08:52:18 +0100
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > FWIW, I think this should be controlled by a user option. It is not
>> > at all obvious that everyone would like compilation processes to be
>> > killed automatically, people might want to wait for them to complete.
>>
>> Since this is something that Emacs does automatically, in the
>> background, I don't think a user option sounds like something somebody
>> would want to tweak.
>
> IMO, we should offer an option precisely _because_ this is in
> background, thus the user could be unaware of the compilation being
> run. Since compilation takes non-negligible time, I envision users
> who'd like to wait for a few moments if that gave them faster Lisp
> next time.
>
> This is not unlike background subprocesses about which we do ask on
> exit.
IIUC, it's different from other background processes. The compilation
will resume automatically the next time that file is loaded in
subsequent invocations of Emacs.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2020-11-24 16:08 ` Stefan Kangas
@ 2020-11-24 16:29 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-25 22:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-24 16:36 ` Eli Zaretskii
1 sibling, 1 reply; 24+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-11-24 16:29 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Eli Zaretskii, Lars Ingebrigtsen, 44743
Stefan Kangas <stefan@marxist.se> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Lars Ingebrigtsen <larsi@gnus.org>
>>> Cc: Andrea Corallo <akrl@sdf.org>, stefan@marxist.se, 44743@debbugs.gnu.org
>>> Date: Tue, 24 Nov 2020 08:52:18 +0100
>>>
>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>
>>> > FWIW, I think this should be controlled by a user option. It is not
>>> > at all obvious that everyone would like compilation processes to be
>>> > killed automatically, people might want to wait for them to complete.
>>>
>>> Since this is something that Emacs does automatically, in the
>>> background, I don't think a user option sounds like something somebody
>>> would want to tweak.
>>
>> IMO, we should offer an option precisely _because_ this is in
>> background, thus the user could be unaware of the compilation being
>> run. Since compilation takes non-negligible time, I envision users
>> who'd like to wait for a few moments if that gave them faster Lisp
>> next time.
>>
>> This is not unlike background subprocesses about which we do ask on
>> exit.
>
> IIUC, it's different from other background processes. The compilation
> will resume automatically the next time that file is loaded in
> subsequent invocations of Emacs.
Yes but you will loose the machine time invested into the compilation
that was aborted :) I guess 99% of people wouldn't care about it but
OTOH what's the downside of leaving a customize to control it?
Andrea
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2020-11-24 16:08 ` Stefan Kangas
2020-11-24 16:29 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-11-24 16:36 ` Eli Zaretskii
1 sibling, 0 replies; 24+ messages in thread
From: Eli Zaretskii @ 2020-11-24 16:36 UTC (permalink / raw)
To: Stefan Kangas; +Cc: larsi, akrl, 44743
> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 24 Nov 2020 08:08:15 -0800
> Cc: akrl@sdf.org, 44743@debbugs.gnu.org
>
> The compilation will resume automatically the next time that file is
> loaded in subsequent invocations of Emacs.
Resume, and take how much time? Not every user out there has a
16-core i9 at his/her disposal.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2020-11-24 16:29 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-02-25 22:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 0:45 ` Stefan Kangas
2021-02-26 7:05 ` Eli Zaretskii
0 siblings, 2 replies; 24+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-02-25 22:51 UTC (permalink / raw)
To: 44743; +Cc: eliz, stefan, larsi
Hi all,
IIUC this bug is "just" about deciding what's the best default behavior
regarding requiring confirmation or not for killing running async
compile processes when exiting Emacs.
As my understanding is that Eli's preference is matching the current
implementation (requiring it) I'm wondering if we can close this bug.
Thanks
Andrea
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-25 22:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-02-26 0:45 ` Stefan Kangas
2021-02-26 7:05 ` Eli Zaretskii
1 sibling, 0 replies; 24+ messages in thread
From: Stefan Kangas @ 2021-02-26 0:45 UTC (permalink / raw)
To: akrl, 44743; +Cc: larsi
Andrea Corallo <akrl@sdf.org> writes:
> IIUC this bug is "just" about deciding what's the best default behavior
> regarding requiring confirmation or not for killing running async
> compile processes when exiting Emacs.
>
> As my understanding is that Eli's preference is matching the current
> implementation (requiring it) I'm wondering if we can close this bug.
FWIW, I agree with your previous assessment that transparency by default
is the best choice here.
Ideally, nativecomp would not change how Emacs works in any user visible
way (besides better performance). But in practice, due to the way this
all works, there will necessarily have to be at least some differences.
The user visible change in behavior we discuss here is not necessary,
AFAIU, but completely avoidable. It feels to me like we leave our guts
hanging out on purpose.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-25 22:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 0:45 ` Stefan Kangas
@ 2021-02-26 7:05 ` Eli Zaretskii
2021-02-26 13:02 ` Stefan Kangas
2021-02-26 13:44 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 2 replies; 24+ messages in thread
From: Eli Zaretskii @ 2021-02-26 7:05 UTC (permalink / raw)
To: Andrea Corallo; +Cc: larsi, stefan, 44743
> From: Andrea Corallo <akrl@sdf.org>
> Cc: Stefan Kangas <stefan@marxist.se>, Eli Zaretskii <eliz@gnu.org>,
> Lars
> Ingebrigtsen <larsi@gnus.org>, 44743@debbugs.gnu.org
> Date: Thu, 25 Feb 2021 22:51:00 +0000
>
> IIUC this bug is "just" about deciding what's the best default behavior
> regarding requiring confirmation or not for killing running async
> compile processes when exiting Emacs.
Yes, mostly.
> As my understanding is that Eli's preference is matching the current
> implementation (requiring it) I'm wondering if we can close this bug.
It is fine with me to close the bug and leave this for later, when the
branch is merged, and we have more user experience. We could reopen
the bug at that time.
A better solution, from my POV, given the controversy, is to provide a
defcustom for this, and then I'm okay with making silently killing the
compilation the default. I thought it would leave everyone happy.
For some reason, Lars and Stefan are against even that, so I hesitate
to even ask you, Andrea, to add such a defcustom if you have time.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-26 7:05 ` Eli Zaretskii
@ 2021-02-26 13:02 ` Stefan Kangas
2021-02-26 13:44 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 0 replies; 24+ messages in thread
From: Stefan Kangas @ 2021-02-26 13:02 UTC (permalink / raw)
To: Eli Zaretskii, Andrea Corallo; +Cc: larsi, 44743
Eli Zaretskii <eliz@gnu.org> writes:
> A better solution, from my POV, given the controversy, is to provide a
> defcustom for this, and then I'm okay with making silently killing the
> compilation the default. I thought it would leave everyone happy.
Sounds good to me.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-26 7:05 ` Eli Zaretskii
2021-02-26 13:02 ` Stefan Kangas
@ 2021-02-26 13:44 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 14:12 ` Eli Zaretskii
1 sibling, 1 reply; 24+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-02-26 13:44 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 44743-done, larsi, stefan
Eli Zaretskii <eliz@gnu.org> writes:
Q>> From: Andrea Corallo <akrl@sdf.org>
>> Cc: Stefan Kangas <stefan@marxist.se>, Eli Zaretskii <eliz@gnu.org>,
>> Lars
>> Ingebrigtsen <larsi@gnus.org>, 44743@debbugs.gnu.org
>> Date: Thu, 25 Feb 2021 22:51:00 +0000
>>
>> IIUC this bug is "just" about deciding what's the best default behavior
>> regarding requiring confirmation or not for killing running async
>> compile processes when exiting Emacs.
>
> Yes, mostly.
>
>> As my understanding is that Eli's preference is matching the current
>> implementation (requiring it) I'm wondering if we can close this bug.
>
> It is fine with me to close the bug and leave this for later, when the
> branch is merged, and we have more user experience. We could reopen
> the bug at that time.
>
> A better solution, from my POV, given the controversy, is to provide a
> defcustom for this, and then I'm okay with making silently killing the
> compilation the default. I thought it would leave everyone happy.
> For some reason, Lars and Stefan are against even that, so I hesitate
> to even ask you, Andrea, to add such a defcustom if you have time.
I also agree the customize look like the best option, 54df918ad1 adds
`comp-async-query-on-exit' setting it to nil as default.
Please have a look to the docstring I've added and let me know in case
needs improvent, my docstring skills are worst than my coding one's.
Closing the bug in the meanwhile.
Thanks
Andrea
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-26 13:44 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-02-26 14:12 ` Eli Zaretskii
2021-02-26 14:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 24+ messages in thread
From: Eli Zaretskii @ 2021-02-26 14:12 UTC (permalink / raw)
To: Andrea Corallo; +Cc: larsi, stefan, 44743
> From: Andrea Corallo <akrl@sdf.org>
> Cc: stefan@marxist.se, larsi@gnus.org, 44743-done@debbugs.gnu.org
> Date: Fri, 26 Feb 2021 13:44:47 +0000
>
> > A better solution, from my POV, given the controversy, is to provide a
> > defcustom for this, and then I'm okay with making silently killing the
> > compilation the default. I thought it would leave everyone happy.
> > For some reason, Lars and Stefan are against even that, so I hesitate
> > to even ask you, Andrea, to add such a defcustom if you have time.
>
> I also agree the customize look like the best option, 54df918ad1 adds
> `comp-async-query-on-exit' setting it to nil as default.
Thanks.
> Please have a look to the docstring I've added and let me know in case
> needs improvent, my docstring skills are worst than my coding one's.
Thanks, I've made some changes there.
Btw, all the defcustom's in comp.el will need to have the :version
tag. But we can leave this for later.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-26 14:12 ` Eli Zaretskii
@ 2021-02-26 14:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 17:26 ` Stefan Kangas
0 siblings, 1 reply; 24+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-02-26 14:28 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: larsi, stefan, 44743
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Andrea Corallo <akrl@sdf.org>
>> Cc: stefan@marxist.se, larsi@gnus.org, 44743-done@debbugs.gnu.org
>> Date: Fri, 26 Feb 2021 13:44:47 +0000
>>
>> > A better solution, from my POV, given the controversy, is to provide a
>> > defcustom for this, and then I'm okay with making silently killing the
>> > compilation the default. I thought it would leave everyone happy.
>> > For some reason, Lars and Stefan are against even that, so I hesitate
>> > to even ask you, Andrea, to add such a defcustom if you have time.
>>
>> I also agree the customize look like the best option, 54df918ad1 adds
>> `comp-async-query-on-exit' setting it to nil as default.
>
> Thanks.
>
>> Please have a look to the docstring I've added and let me know in case
>> needs improvent, my docstring skills are worst than my coding one's.
>
> Thanks, I've made some changes there.
Appreciated
> Btw, all the defcustom's in comp.el will need to have the :version
> tag. But we can leave this for later.
Okay
Thanks
Andrea
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-26 14:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-02-26 17:26 ` Stefan Kangas
2021-02-26 18:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
` (2 more replies)
0 siblings, 3 replies; 24+ messages in thread
From: Stefan Kangas @ 2021-02-26 17:26 UTC (permalink / raw)
To: Andrea Corallo, Eli Zaretskii; +Cc: larsi, 44743
Andrea Corallo <akrl@sdf.org> writes:
>> Btw, all the defcustom's in comp.el will need to have the :version
>> tag. But we can leave this for later.
>
> Okay
I've tagged them up.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-26 17:26 ` Stefan Kangas
@ 2021-02-26 18:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 19:54 ` Eli Zaretskii
2021-02-26 20:31 ` Glenn Morris
2 siblings, 0 replies; 24+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-02-26 18:55 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Eli Zaretskii, larsi, 44743
Stefan Kangas <stefan@marxist.se> writes:
> Andrea Corallo <akrl@sdf.org> writes:
>
>>> Btw, all the defcustom's in comp.el will need to have the :version
>>> tag. But we can leave this for later.
>>
>> Okay
>
> I've tagged them up.
Thanks!
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-26 17:26 ` Stefan Kangas
2021-02-26 18:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-02-26 19:54 ` Eli Zaretskii
2021-02-26 20:31 ` Glenn Morris
2 siblings, 0 replies; 24+ messages in thread
From: Eli Zaretskii @ 2021-02-26 19:54 UTC (permalink / raw)
To: Stefan Kangas; +Cc: larsi, akrl, 44743
> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 26 Feb 2021 11:26:15 -0600
> Cc: larsi@gnus.org, 44743@debbugs.gnu.org
>
> Andrea Corallo <akrl@sdf.org> writes:
>
> >> Btw, all the defcustom's in comp.el will need to have the :version
> >> tag. But we can leave this for later.
> >
> > Okay
>
> I've tagged them up.
Thanks!
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-26 17:26 ` Stefan Kangas
2021-02-26 18:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 19:54 ` Eli Zaretskii
@ 2021-02-26 20:31 ` Glenn Morris
2021-02-27 2:14 ` Stefan Kangas
2 siblings, 1 reply; 24+ messages in thread
From: Glenn Morris @ 2021-02-26 20:31 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Andrea Corallo, larsi, 44743
>>> Btw, all the defcustom's in comp.el will need to have the :version tag.
> I've tagged them up.
Since the whole file is new, you could just tag the defgroup.
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-26 20:31 ` Glenn Morris
@ 2021-02-27 2:14 ` Stefan Kangas
2021-02-27 7:23 ` Eli Zaretskii
0 siblings, 1 reply; 24+ messages in thread
From: Stefan Kangas @ 2021-02-27 2:14 UTC (permalink / raw)
To: Glenn Morris; +Cc: Andrea Corallo, larsi, 44743
Glenn Morris <rgm@gnu.org> writes:
>>>> Btw, all the defcustom's in comp.el will need to have the :version tag.
>
>> I've tagged them up.
>
> Since the whole file is new, you could just tag the defgroup.
Thanks. Will that propagate to the individual options?
This seems not to give the "This variable was introduced" message:
(progn (defgroup foo nil "foo" :version "28.1")
(defcustom bar nil "foo" :group 'foo)
(describe-variable 'bar))
Do we care to have that message?
^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling
2021-02-27 2:14 ` Stefan Kangas
@ 2021-02-27 7:23 ` Eli Zaretskii
0 siblings, 0 replies; 24+ messages in thread
From: Eli Zaretskii @ 2021-02-27 7:23 UTC (permalink / raw)
To: Stefan Kangas; +Cc: rgm, larsi, akrl, 44743
> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 26 Feb 2021 20:14:30 -0600
> Cc: Andrea Corallo <akrl@sdf.org>, Eli Zaretskii <eliz@gnu.org>, 44743@debbugs.gnu.org, larsi@gnus.org
>
> > Since the whole file is new, you could just tag the defgroup.
>
> Thanks. Will that propagate to the individual options?
>
> This seems not to give the "This variable was introduced" message:
>
> (progn (defgroup foo nil "foo" :version "28.1")
> (defcustom bar nil "foo" :group 'foo)
> (describe-variable 'bar))
>
> Do we care to have that message?
I think we do, otherwise why have it?
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2021-02-27 7:23 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 22:24 bug#44743: native-comp: confirm-exit-emacs warns about active processes when compiling Stefan Kangas
2020-11-20 8:35 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-20 11:35 ` Eli Zaretskii
2020-11-21 19:22 ` Stefan Kangas
2020-11-21 19:47 ` Eli Zaretskii
2020-11-21 20:35 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-24 7:52 ` Lars Ingebrigtsen
2020-11-24 15:42 ` Eli Zaretskii
2020-11-24 16:08 ` Stefan Kangas
2020-11-24 16:29 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-25 22:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 0:45 ` Stefan Kangas
2021-02-26 7:05 ` Eli Zaretskii
2021-02-26 13:02 ` Stefan Kangas
2021-02-26 13:44 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 14:12 ` Eli Zaretskii
2021-02-26 14:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 17:26 ` Stefan Kangas
2021-02-26 18:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 19:54 ` Eli Zaretskii
2021-02-26 20:31 ` Glenn Morris
2021-02-27 2:14 ` Stefan Kangas
2021-02-27 7:23 ` Eli Zaretskii
2020-11-24 16:36 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).