* bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t
@ 2022-06-30 0:06 Sean Whitton
2022-06-30 5:53 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Sean Whitton @ 2022-06-30 0:06 UTC (permalink / raw)
To: 56309
When server-process-filter calls server-create-dumb-terminal-frame and
server-create-window-system-frame it passes along frame parameters
supplied on the emacsclient command line, but it doesn't pass these to
server-create-tty-frame.
I'd like to suggest:
diff --git a/lisp/server.el b/lisp/server.el
index 8f47a99a31..a06f2f952f 100644
--- a/lisp/server.el
+++ b/lisp/server.el
@@ -1314,7 +1314,8 @@ server-process-filter
frame-parameters))
;; When resuming on a tty, tty-name is nil.
(tty-name
- (server-create-tty-frame tty-name tty-type proc))
+ (server-create-tty-frame tty-name tty-type proc
+ frame-parameters))
;; If there won't be a current frame to use, fall
;; back to trying to create a new one.
--
Sean Whitton
^ permalink raw reply related [flat|nested] 4+ messages in thread* bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t
2022-06-30 0:06 bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t Sean Whitton
@ 2022-06-30 5:53 ` Eli Zaretskii
2022-06-30 10:11 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2022-06-30 5:53 UTC (permalink / raw)
To: Sean Whitton, Lars Ingebrigtsen; +Cc: 56309
> From: Sean Whitton <spwhitton@spwhitton.name>
> Date: Wed, 29 Jun 2022 17:06:48 -0700
>
> When server-process-filter calls server-create-dumb-terminal-frame and
> server-create-window-system-frame it passes along frame parameters
> supplied on the emacsclient command line, but it doesn't pass these to
> server-create-tty-frame.
>
> I'd like to suggest:
>
> diff --git a/lisp/server.el b/lisp/server.el
> index 8f47a99a31..a06f2f952f 100644
> --- a/lisp/server.el
> +++ b/lisp/server.el
> @@ -1314,7 +1314,8 @@ server-process-filter
> frame-parameters))
> ;; When resuming on a tty, tty-name is nil.
> (tty-name
> - (server-create-tty-frame tty-name tty-type proc))
> + (server-create-tty-frame tty-name tty-type proc
> + frame-parameters))
>
> ;; If there won't be a current frame to use, fall
> ;; back to trying to create a new one.
>
That rang a bell, so I looked in the Git history. It turns out this
was already part of the patch proposed in bug#24147, which introduced
the PARAMETERS argument for server-create-tty-frame, but it was
somehow left out of the changes which were actually applied back then,
see commit 14fc8a1.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t
2022-06-30 5:53 ` Eli Zaretskii
@ 2022-06-30 10:11 ` Lars Ingebrigtsen
2022-07-01 0:05 ` Sean Whitton
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-30 10:11 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 56309, Sean Whitton
Eli Zaretskii <eliz@gnu.org> writes:
> That rang a bell, so I looked in the Git history. It turns out this
> was already part of the patch proposed in bug#24147, which introduced
> the PARAMETERS argument for server-create-tty-frame, but it was
> somehow left out of the changes which were actually applied back then,
> see commit 14fc8a1.
Ah, I must have just missed a merge conflict or something when applying
the patch. I've pushed the parts that were missing to Emacs 29.
Sean, can you check whether this fixes the problem here?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t
2022-06-30 10:11 ` Lars Ingebrigtsen
@ 2022-07-01 0:05 ` Sean Whitton
0 siblings, 0 replies; 4+ messages in thread
From: Sean Whitton @ 2022-07-01 0:05 UTC (permalink / raw)
To: Lars Ingebrigtsen, Eli Zaretskii, 56309-done
Hello,
On Thu 30 Jun 2022 at 12:11PM +02, Lars Ingebrigtsen wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> That rang a bell, so I looked in the Git history. It turns out this
>> was already part of the patch proposed in bug#24147, which introduced
>> the PARAMETERS argument for server-create-tty-frame, but it was
>> somehow left out of the changes which were actually applied back then,
>> see commit 14fc8a1.
>
> Ah, I must have just missed a merge conflict or something when applying
> the patch. I've pushed the parts that were missing to Emacs 29.
>
> Sean, can you check whether this fixes the problem here?
It does indeed, thank you both.
--
Sean Whitton
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-01 0:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-30 0:06 bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t Sean Whitton
2022-06-30 5:53 ` Eli Zaretskii
2022-06-30 10:11 ` Lars Ingebrigtsen
2022-07-01 0:05 ` Sean Whitton
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).