From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t Date: Thu, 30 Jun 2022 08:53:22 +0300 Message-ID: <83iloi66jx.fsf@gnu.org> References: <87bkubm2uf.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35849"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56309@debbugs.gnu.org To: Sean Whitton , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 30 07:54:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6n80-00098R-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jun 2022 07:54:12 +0200 Original-Received: from localhost ([::1]:54102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6n7y-0006F0-Mi for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jun 2022 01:54:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6n7q-0006Eg-BL for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2022 01:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6n7q-0000Ho-1i for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2022 01:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6n7q-0003qT-0b for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2022 01:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jun 2022 05:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56309 X-GNU-PR-Package: emacs Original-Received: via spool by 56309-submit@debbugs.gnu.org id=B56309.165656840914735 (code B ref 56309); Thu, 30 Jun 2022 05:54:01 +0000 Original-Received: (at 56309) by debbugs.gnu.org; 30 Jun 2022 05:53:29 +0000 Original-Received: from localhost ([127.0.0.1]:60802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6n7I-0003pb-Ja for submit@debbugs.gnu.org; Thu, 30 Jun 2022 01:53:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6n7A-0003pD-Lj for 56309@debbugs.gnu.org; Thu, 30 Jun 2022 01:53:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43818) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6n75-0000Dt-49; Thu, 30 Jun 2022 01:53:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JsUPpnmEeM1PdmDUjSrs6EEGWAGBo0hgBoqZ1M1rSVw=; b=HUbZscvQ04Ir 5xNQz6HWBz192M8u+l8aqdmab4TCzjCQfH44nvFXbHtm+o41UzRVzcqKCCmAj14jZUHrH98/NNNoz h1BTNm0YVlQCvUzphtRUrA05oNaledNoWVt/If+/X6eCcogzlxXmyvWU3oIE2DkEd/fELhbFOzGUi g63DhJJEI4/3f8+pP5MNkD2Z5nW5dO6B3BpOWsgGG0yYr92XkUiSmnkcGGBnen9QGTMznqpeWoWT5 JsVqcw0dRpBnx1LPtVjqtZF8s4iN1AIBoUIRwpBVX7JqPgX++BzPg/NjFBlJ/GXVs6NuWrjapYm+g YZsvphIUYY89GS/Y+H9Hhg==; Original-Received: from [87.69.77.57] (port=1440 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6n74-0003H7-JB; Thu, 30 Jun 2022 01:53:14 -0400 In-Reply-To: <87bkubm2uf.fsf@melete.silentflame.com> (message from Sean Whitton on Wed, 29 Jun 2022 17:06:48 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235686 Archived-At: > From: Sean Whitton > Date: Wed, 29 Jun 2022 17:06:48 -0700 > > When server-process-filter calls server-create-dumb-terminal-frame and > server-create-window-system-frame it passes along frame parameters > supplied on the emacsclient command line, but it doesn't pass these to > server-create-tty-frame. > > I'd like to suggest: > > diff --git a/lisp/server.el b/lisp/server.el > index 8f47a99a31..a06f2f952f 100644 > --- a/lisp/server.el > +++ b/lisp/server.el > @@ -1314,7 +1314,8 @@ server-process-filter > frame-parameters)) > ;; When resuming on a tty, tty-name is nil. > (tty-name > - (server-create-tty-frame tty-name tty-type proc)) > + (server-create-tty-frame tty-name tty-type proc > + frame-parameters)) > > ;; If there won't be a current frame to use, fall > ;; back to trying to create a new one. > That rang a bell, so I looked in the Git history. It turns out this was already part of the patch proposed in bug#24147, which introduced the PARAMETERS argument for server-create-tty-frame, but it was somehow left out of the changes which were actually applied back then, see commit 14fc8a1.