From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t Date: Wed, 29 Jun 2022 17:06:48 -0700 Message-ID: <87bkubm2uf.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12557"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu) To: 56309@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 30 02:07:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6hiT-00033Y-Bq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jun 2022 02:07:31 +0200 Original-Received: from localhost ([::1]:50964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6hiR-0003BD-NF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jun 2022 20:07:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6hiC-0003B2-2W for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 20:07:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6hi2-0001yT-Sl for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 20:07:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6hi2-0002Fz-Km for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 20:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jun 2022 00:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56309 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16565476218666 (code B ref -1); Thu, 30 Jun 2022 00:07:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Jun 2022 00:07:01 +0000 Original-Received: from localhost ([127.0.0.1]:60447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6hi0-0002Fg-EX for submit@debbugs.gnu.org; Wed, 29 Jun 2022 20:07:00 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:58436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6hhu-0002FT-PJ for submit@debbugs.gnu.org; Wed, 29 Jun 2022 20:06:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6hhu-00039A-7U for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 20:06:54 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:38099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6hhr-0001wR-2U for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2022 20:06:52 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 467D55C0156 for ; Wed, 29 Jun 2022 20:06:50 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 29 Jun 2022 20:06:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1656547610; x=1656634010; bh=0RJ6SUc7mleFvconjekyk1KdSRugnJRyrkd bN7NOC84=; b=rafVSOX7K6AijvJQ0KOgtJMbQU9b21OHTUAITXItiNy3vLDVK7m 1l6644b+SO0lvnR/kv9vDEsj6rajUW9xeeVJCe3pH3yK5w+Imui78c/zdtXEFN0k b9cjuwEbPRfWqY/NwdBZXroltunaGKWfVXI/A7HkG9GnTmZnfY9Nh78h2lprLcQs 7OCmSE0UGFSRXDUH4AVdHVX38wQRkBUhjxh0x1RS0b+9qAIk1fhsmUVJFJeWKYs5 r6A9AoW1u7AgEI/ha9PE+4B4njtvl+BM97Ub2PKc6rBdglUkRDzsaNmU0bLPP8HR dXbpEUT5VlBKwrOE+kVUJuU8cT7dpz4mA4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656547610; x= 1656634010; bh=0RJ6SUc7mleFvconjekyk1KdSRugnJRyrkdbN7NOC84=; b=L gvG0hHqYoJzZjBVapQ7zc2wQ/NzbcNaQEdQqVJGwZpmVCipF2ENFAd4/2lF/juZ6 wn7sD0L8EsVui3Gd4A51XrNxw8APETHJY7t0xX17mqeq7mnbnfAHOrc7nKOGdT9N 9f5uNXnBLxWeiGknKHbvNZd4ud1VEdgwFAuWzM8CXplcsxw46vTiWWH0Y7IenwoG naGcQ+sPQORaTnxcCrG+jqY4vaRHipn0IJ/cThkV1gehsw59D0ttkJx6Jd3u5JnN j0aFXP7V91v5KO3HxDdOlTNTntkFzVpABQuuDwOhjTy4yDKhv1qdBiRO8XozZEIx i4BpoZv0bCs9/XSBEFAvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehtddgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufgffkfggtgesthdttddttd ertdenucfhrhhomhepufgvrghnucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhp fihhihhtthhonhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeekffevgeeftedvteduhf etffeffeehheekjeefheeiffdvjeelleettdeuiedvieenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhith htohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 29 Jun 2022 20:06:50 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 583CA7E5600; Wed, 29 Jun 2022 17:06:48 -0700 (MST) Received-SPF: pass client-ip=66.111.4.29; envelope-from=spwhitton@spwhitton.name; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235676 Archived-At: When server-process-filter calls server-create-dumb-terminal-frame and server-create-window-system-frame it passes along frame parameters supplied on the emacsclient command line, but it doesn't pass these to server-create-tty-frame. I'd like to suggest: diff --git a/lisp/server.el b/lisp/server.el index 8f47a99a31..a06f2f952f 100644 --- a/lisp/server.el +++ b/lisp/server.el @@ -1314,7 +1314,8 @@ server-process-filter frame-parameters)) ;; When resuming on a tty, tty-name is nil. (tty-name - (server-create-tty-frame tty-name tty-type proc)) + (server-create-tty-frame tty-name tty-type proc + frame-parameters)) ;; If there won't be a current frame to use, fall ;; back to trying to create a new one. -- Sean Whitton