unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Sean Whitton <spwhitton@spwhitton.name>
To: 56309@debbugs.gnu.org
Subject: bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t
Date: Wed, 29 Jun 2022 17:06:48 -0700	[thread overview]
Message-ID: <87bkubm2uf.fsf@melete.silentflame.com> (raw)

When server-process-filter calls server-create-dumb-terminal-frame and
server-create-window-system-frame it passes along frame parameters
supplied on the emacsclient command line, but it doesn't pass these to
server-create-tty-frame.

I'd like to suggest:

diff --git a/lisp/server.el b/lisp/server.el
index 8f47a99a31..a06f2f952f 100644
--- a/lisp/server.el
+++ b/lisp/server.el
@@ -1314,7 +1314,8 @@ server-process-filter
 						       frame-parameters))
 		   ;; When resuming on a tty, tty-name is nil.
 		   (tty-name
-		    (server-create-tty-frame tty-name tty-type proc))
+		    (server-create-tty-frame tty-name tty-type proc
+                                             frame-parameters))
 
                    ;; If there won't be a current frame to use, fall
                    ;; back to trying to create a new one.


-- 
Sean Whitton





             reply	other threads:[~2022-06-30  0:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30  0:06 Sean Whitton [this message]
2022-06-30  5:53 ` bug#56309: 29.0.50; emacsclient's --frame-parameters option ignored when -t Eli Zaretskii
2022-06-30 10:11   ` Lars Ingebrigtsen
2022-07-01  0:05     ` Sean Whitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkubm2uf.fsf@melete.silentflame.com \
    --to=spwhitton@spwhitton.name \
    --cc=56309@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).