unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#51484: [PATCH] Move runtime check for recent giflib to compile time
@ 2021-10-29 14:42 Stefan Kangas
  2021-10-29 16:01 ` Lars Ingebrigtsen
  2021-10-29 16:10 ` Eli Zaretskii
  0 siblings, 2 replies; 6+ messages in thread
From: Stefan Kangas @ 2021-10-29 14:42 UTC (permalink / raw)
  To: 51484

Severity: wishlist

I'm looking into some bugs in how we handle gifs, and I see that we
check for GIFLIB_MAJOR at runtime.  Is there any reason not to do it at
compile-time as in the attached patch?

I expect that GCC is smart enough to see that "5 < 4" is always false
and optimize this all away, and probably also won't include unused
static variables, so maybe this doesn't matter.  But I think it's nice
to be a bit more explicit, and I guess it can't hurt to see warnings if
anyone tries using interlace_start and interlace_increment outside of
their intended use.





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-29 18:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-29 14:42 bug#51484: [PATCH] Move runtime check for recent giflib to compile time Stefan Kangas
2021-10-29 16:01 ` Lars Ingebrigtsen
2021-10-29 16:10 ` Eli Zaretskii
2021-10-29 16:30   ` Stefan Kangas
2021-10-29 17:57     ` Eli Zaretskii
2021-10-29 18:15       ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).