From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 51484@debbugs.gnu.org
Subject: bug#51484: [PATCH] Move runtime check for recent giflib to compile time
Date: Fri, 29 Oct 2021 20:57:52 +0300 [thread overview]
Message-ID: <83y26bpvc0.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmBvYA8ocNL0_=b3XWjWmNOvT54R-2ACzCFimBp01LAeQ@mail.gmail.com> (message from Stefan Kangas on Fri, 29 Oct 2021 09:30:40 -0700)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 29 Oct 2021 09:30:40 -0700
> Cc: 51484@debbugs.gnu.org
>
> > The compiler converts that into a run-time constant anyway. The
> > reason for using such "run-time" testing is usually to have a more
> > readable code, since #ifdef's make the code harder to read. There are
> > no downsides, since the test is compiled away.
>
> Right, hence my asking what you all think of the patch. Which is now
> hopefully also attached.
I generally prefer to avoid #ifdef's, so I think the change you
propose is not for the better. We have similar code elsewhere in
Emacs, and there's nothing wrong with it.
next prev parent reply other threads:[~2021-10-29 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 14:42 bug#51484: [PATCH] Move runtime check for recent giflib to compile time Stefan Kangas
2021-10-29 16:01 ` Lars Ingebrigtsen
2021-10-29 16:10 ` Eli Zaretskii
2021-10-29 16:30 ` Stefan Kangas
2021-10-29 17:57 ` Eli Zaretskii [this message]
2021-10-29 18:15 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y26bpvc0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=51484@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).