From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51484: [PATCH] Move runtime check for recent giflib to compile time Date: Fri, 29 Oct 2021 20:57:52 +0300 Message-ID: <83y26bpvc0.fsf@gnu.org> References: <835ytfrevd.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6018"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51484@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 29 20:03:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mgWDp-0001Nz-1D for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 20:03:21 +0200 Original-Received: from localhost ([::1]:45518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgWDm-0007n5-9Y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 14:03:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgW9e-0003tt-SE for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 13:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44288) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgW9e-00009o-JP for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 13:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgW9e-0005r1-JL for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 13:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Oct 2021 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51484 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51484-submit@debbugs.gnu.org id=B51484.163553029422416 (code B ref 51484); Fri, 29 Oct 2021 17:59:02 +0000 Original-Received: (at 51484) by debbugs.gnu.org; 29 Oct 2021 17:58:14 +0000 Original-Received: from localhost ([127.0.0.1]:55834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgW8s-0005pU-Gj for submit@debbugs.gnu.org; Fri, 29 Oct 2021 13:58:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgW8p-0005pB-Ki for 51484@debbugs.gnu.org; Fri, 29 Oct 2021 13:58:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47678) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgW8k-0008Um-6l; Fri, 29 Oct 2021 13:58:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6EIUyXhAIalwUmaE3/OFMIRbpHywi1gHBfa/7yaUDqA=; b=AOpwSMoDC4FX /avhsXjugEfJUpnF3mX1DE4CNwQT0f4twE3eUD97dbDCs+4j5/H1KjEn4ZdRf2BsmrRd+Em5d7MMT atNq5IoWX8pugC8vCLq9TmXFTUTTZ8Gk5jJdq6Kbxar340VHwFFJAQ1D2hKt4ZxuSJD4uXSHTsC3M Mgu5wy8pNtLED9nwwD2CNEAl4Dks546Iq5aj+gTzRA4lzaEDrvLW/Sr7N97QG9hUPQyV7yOsAlESn B6foyfj+H5C0GXwDEeSnzqVQvGzaQt/zyAehvozu6dQ3c6h9pURXDr7GLfqVJcFiBIQH1w9eaEfS1 KIAYOUEZt0ZaKSkD7z5jrw==; Original-Received: from [87.69.77.57] (port=3293 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgW8j-0008UY-NQ; Fri, 29 Oct 2021 13:58:06 -0400 In-Reply-To: (message from Stefan Kangas on Fri, 29 Oct 2021 09:30:40 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218580 Archived-At: > From: Stefan Kangas > Date: Fri, 29 Oct 2021 09:30:40 -0700 > Cc: 51484@debbugs.gnu.org > > > The compiler converts that into a run-time constant anyway. The > > reason for using such "run-time" testing is usually to have a more > > readable code, since #ifdef's make the code harder to read. There are > > no downsides, since the test is compiled away. > > Right, hence my asking what you all think of the patch. Which is now > hopefully also attached. I generally prefer to avoid #ifdef's, so I think the change you propose is not for the better. We have similar code elsewhere in Emacs, and there's nothing wrong with it.