From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51484: [PATCH] Move runtime check for recent giflib to compile time Date: Fri, 29 Oct 2021 09:30:40 -0700 Message-ID: References: <835ytfrevd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000022f13f05cf80597f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28009"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51484@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 29 18:31:51 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mgUnF-00070w-6L for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 18:31:49 +0200 Original-Received: from localhost ([::1]:57602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgUnD-0006SC-8u for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 12:31:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgUmV-0006QZ-QY for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 12:31:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgUmU-0004qM-HV for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 12:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgUmU-0000nM-89 for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 12:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Oct 2021 16:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51484 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51484-submit@debbugs.gnu.org id=B51484.16355250513038 (code B ref 51484); Fri, 29 Oct 2021 16:31:02 +0000 Original-Received: (at 51484) by debbugs.gnu.org; 29 Oct 2021 16:30:51 +0000 Original-Received: from localhost ([127.0.0.1]:55708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgUmJ-0000mv-1u for submit@debbugs.gnu.org; Fri, 29 Oct 2021 12:30:51 -0400 Original-Received: from mail-pg1-f180.google.com ([209.85.215.180]:38650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgUmF-0000me-Gb for 51484@debbugs.gnu.org; Fri, 29 Oct 2021 12:30:49 -0400 Original-Received: by mail-pg1-f180.google.com with SMTP id e65so10389053pgc.5 for <51484@debbugs.gnu.org>; Fri, 29 Oct 2021 09:30:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=G1GtExnEtSn7P6ytsH2hW4KhuetBarKGbv4hYYKl/W4=; b=D3ZVorl9i1s/JJ7upC9PZmdKB+9U++073JWANJZqbE2I/sVlovFc+CJ7vpSF4dK8tv Ke6FZGZ+qtCFxt0sGVxZNHcdr7/EQB6XOg+HdJ4puMDKkfULwROXHfFKg9+vi9gpHE4n yN9U44OQcSHPwA22lp/AobU/3bvo8GniWJzeo+5/1oitxFSvSPguUQHfTpTC2RA2Ourw S55QwjRKEX2+pGqFuB4nNdK29V2pMxh32ayeRNAiOuKcCA1M+ls/H0mxn7WKHYqhjr99 vX85yFt/WoEc0vJXTak4TZcpUqtBjh8UrCDjuBSkwMhOWIIerbIs4MWf21Og4Qt+A+Mc J30Q== X-Gm-Message-State: AOAM5337DG8cntx5ZBofePAdX6a08b7x3evy2hrgXvBij4C+CCbjVF6+ LUedE3mwnd8J4ibhl+L9FyB9vi0IL6N8k62ZwOI= X-Google-Smtp-Source: ABdhPJxMBB0d1yX72kIjpT+3vI+9CNY5UmS7Io8UTelR5goXcks0mDv/kqHsRh9MTd7+NMl7Jr10Uml3myFuGnbOO4I= X-Received: by 2002:a05:6a00:244d:b0:44d:c279:5155 with SMTP id d13-20020a056a00244d00b0044dc2795155mr11840990pfj.0.1635525041768; Fri, 29 Oct 2021 09:30:41 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 29 Oct 2021 09:30:40 -0700 In-Reply-To: <835ytfrevd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218570 Archived-At: --00000000000022f13f05cf80597f Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > (What patch?) Oops, let's try that again. > The compiler converts that into a run-time constant anyway. The > reason for using such "run-time" testing is usually to have a more > readable code, since #ifdef's make the code harder to read. There are > no downsides, since the test is compiled away. Right, hence my asking what you all think of the patch. Which is now hopefully also attached. --00000000000022f13f05cf80597f Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Move-runtime-check-for-recent-giflib-to-compile-time.patch" Content-Disposition: attachment; filename="0001-Move-runtime-check-for-recent-giflib-to-compile-time.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: fe3ac303bbc902c5_0.1 RnJvbSBlZTk3NWVlNmIyYzk0OTZjNDljZmIzNmFhMjJhY2FiOWNlY2EyZDMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogRnJpLCAyOSBPY3QgMjAyMSAxNToyNDoyNiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIE1vdmUg cnVudGltZSBjaGVjayBmb3IgcmVjZW50IGdpZmxpYiB0byBjb21waWxlIHRpbWUKCiogc3JjL2lt YWdlLmMKKGludGVybGFjZV9zdGFydCwgaW50ZXJsYWNlX2luY3JlbWVudCkgW0dJRkxJQl9NQUpP UiA8IDVdOgpEb24ndCBkZWZpbmUgd2hlbiB1c2luZyByZWNlbnQgZ2lmbGliLgooZ2lmX2xvYWQp OiBSZXBsYWNlIHJ1bnRpbWUgY2hlY2sgZm9yICJHSUZMSUJfTUFKT1IgPCA1IiB3aXRoCnByZXBy b2Nlc3NvciBkaXJlY3RpdmUuCi0tLQogc3JjL2ltYWdlLmMgfCA4ICsrKysrKystCiAxIGZpbGUg Y2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3Jj L2ltYWdlLmMgYi9zcmMvaW1hZ2UuYwppbmRleCA5OTUzM2JiZDFiLi4wZjEwNTEzMWFhIDEwMDY0 NAotLS0gYS9zcmMvaW1hZ2UuYworKysgYi9zcmMvaW1hZ2UuYwpAQCAtODM1OCw4ICs4MzU4LDEw IEBAIGdpZl9jbG9zZSAoR2lmRmlsZVR5cGUgKmdpZiwgaW50ICplcnIpCiAvKiBMb2FkIEdJRiBp bWFnZSBJTUcgZm9yIHVzZSBvbiBmcmFtZSBGLiAgVmFsdWUgaXMgdHJ1ZSBpZgogICAgc3VjY2Vz c2Z1bC4gICovCiAKKyNpZiBHSUZMSUJfTUFKT1IgPCA1CiBzdGF0aWMgY29uc3QgaW50IGludGVy bGFjZV9zdGFydFtdID0gezAsIDQsIDIsIDF9Owogc3RhdGljIGNvbnN0IGludCBpbnRlcmxhY2Vf aW5jcmVtZW50W10gPSB7OCwgOCwgNCwgMn07CisjZW5kaWYKIAogI2RlZmluZSBHSUZfTE9DQUxf REVTQ1JJUFRPUl9FWFRFTlNJT04gMjQ5CiAKQEAgLTg2MjYsNyArODYyOCw4IEBAIGdpZl9sb2Fk IChzdHJ1Y3QgZnJhbWUgKmYsIHN0cnVjdCBpbWFnZSAqaW1nKQogCSAgfQogCiAgICAgICAvKiBB cHBseSB0aGUgcGl4ZWwgdmFsdWVzLiAgKi8KLSAgICAgIGlmIChHSUZMSUJfTUFKT1IgPCA1ICYm IGdpZi0+U2F2ZWRJbWFnZXNbal0uSW1hZ2VEZXNjLkludGVybGFjZSkKKyNpZiBHSUZMSUJfTUFK T1IgPCA1CisgICAgICBpZiAoZ2lmLT5TYXZlZEltYWdlc1tqXS5JbWFnZURlc2MuSW50ZXJsYWNl KQogCXsKIAkgIGludCByb3csIHBhc3M7CiAKQEAgLTg2NTAsNiArODY1Myw3IEBAIGdpZl9sb2Fk IChzdHJ1Y3QgZnJhbWUgKmYsIHN0cnVjdCBpbWFnZSAqaW1nKQogCX0KICAgICAgIGVsc2UKIAl7 CisjZW5kaWYKICAgICAgICAgICBmb3IgKHkgPSAwOyB5IDwgc3ViaW1nX2hlaWdodDsgKyt5KQog CSAgICBmb3IgKHggPSAwOyB4IDwgc3ViaW1nX3dpZHRoOyArK3gpCiAJICAgICAgewpAQCAtODY2 MSw3ICs4NjY1LDkgQEAgZ2lmX2xvYWQgKHN0cnVjdCBmcmFtZSAqZiwgc3RydWN0IGltYWdlICpp bWcpCiAgICAgICAgICAgICAgICAgICB9CiAJICAgICAgfQogCX0KKyNpZiBHSUZMSUJfTUFKT1Ig PCA1CiAgICAgfQorI2VuZGlmCiAKICNpZmRlZiBDT0xPUl9UQUJMRV9TVVBQT1JUCiAgIGltZy0+ Y29sb3JzID0gY29sb3JzX2luX2NvbG9yX3RhYmxlICgmaW1nLT5uY29sb3JzKTsKLS0gCjIuMzAu MgoK --00000000000022f13f05cf80597f--