* bug#15763: autoload-generate-file-autoloads can put package--builtin-versions in wrong file
@ 2013-10-30 20:53 Glenn Morris
2020-12-06 15:14 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2013-10-30 20:53 UTC (permalink / raw)
To: 15763
Package: emacs
Version: 24.3.50
In current trunk, the autoload section of lisp/htmlfontify.el contains:
;;; Generated autoloads from hfy-cmap.el
(push (purecopy '(htmlfontify 0 20)) package--builtin-versions)
That is:
1) Incorrect (htmlfontify.el is at version 0.21, whereas hfy-cmap.el is
at version 0.20).
2) In the wrong file.
I guess autoload-generate-file-autoloads should only do the
package--builtin-versions stuff when writing to the top-level
loaddefs.el file, not when respecting a buffer-local
generated-autoload-file.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#15763: autoload-generate-file-autoloads can put package--builtin-versions in wrong file
2013-10-30 20:53 bug#15763: autoload-generate-file-autoloads can put package--builtin-versions in wrong file Glenn Morris
@ 2020-12-06 15:14 ` Lars Ingebrigtsen
2020-12-06 22:42 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-06 15:14 UTC (permalink / raw)
To: Glenn Morris; +Cc: 15763
Glenn Morris <rgm@gnu.org> writes:
> In current trunk, the autoload section of lisp/htmlfontify.el contains:
>
> ;;; Generated autoloads from hfy-cmap.el
> (push (purecopy '(htmlfontify 0 20)) package--builtin-versions)
>
> That is:
>
> 1) Incorrect (htmlfontify.el is at version 0.21, whereas hfy-cmap.el is
> at version 0.20).
>
> 2) In the wrong file.
>
> I guess autoload-generate-file-autoloads should only do the
> package--builtin-versions stuff when writing to the top-level
> loaddefs.el file, not when respecting a buffer-local
> generated-autoload-file.
I'm guessing this was fixed by this commit:
commit 459cf7cb92445e9336d649f128ec1af274e3f5a1
Author: Phillip Lord <phillip.lord@russet.org.uk>
AuthorDate: Wed Dec 16 23:15:44 2015 +0000
htmlfontify generate autoload to non-versioned file.
* lisp/Makefile.in: Add htmlfontity-loaddefs to autogenel.
* lisp/hfy-cmap.el: Update file local.
* lisp/htmlfontify.el: Remove autoloads, add require.
* test/lisp/htmlfontify-tests.el: Test autoload functionality.
So I'm closing this bug report. Please reopen if there's more to be
done here.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#15763: autoload-generate-file-autoloads can put package--builtin-versions in wrong file
2020-12-06 15:14 ` Lars Ingebrigtsen
@ 2020-12-06 22:42 ` Glenn Morris
2020-12-15 17:42 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2020-12-06 22:42 UTC (permalink / raw)
To: 15763
Lars Ingebrigtsen wrote:
> Glenn Morris <rgm@gnu.org> writes:
>
>> In current trunk, the autoload section of lisp/htmlfontify.el contains:
>>
>> ;;; Generated autoloads from hfy-cmap.el
>> (push (purecopy '(htmlfontify 0 20)) package--builtin-versions)
>>
>> That is:
>>
>> 1) Incorrect (htmlfontify.el is at version 0.21, whereas hfy-cmap.el is
>> at version 0.20).
>>
>> 2) In the wrong file.
>>
>> I guess autoload-generate-file-autoloads should only do the
>> package--builtin-versions stuff when writing to the top-level
>> loaddefs.el file, not when respecting a buffer-local
>> generated-autoload-file.
>
> I'm guessing this was fixed by this commit:
>
> commit 459cf7cb92445e9336d649f128ec1af274e3f5a1
> Author: Phillip Lord <phillip.lord@russet.org.uk>
> AuthorDate: Wed Dec 16 23:15:44 2015 +0000
>
> htmlfontify generate autoload to non-versioned file.
>
> * lisp/Makefile.in: Add htmlfontity-loaddefs to autogenel.
> * lisp/hfy-cmap.el: Update file local.
> * lisp/htmlfontify.el: Remove autoloads, add require.
> * test/lisp/htmlfontify-tests.el: Test autoload functionality.
>
> So I'm closing this bug report. Please reopen if there's more to be
> done here.
FTR, I was reporting a general issue, using htmlfontify as a specific example.
So that change can't have fixed the general issue.
It's still present, but seems not worth fixing.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#15763: autoload-generate-file-autoloads can put package--builtin-versions in wrong file
2020-12-06 22:42 ` Glenn Morris
@ 2020-12-15 17:42 ` Glenn Morris
2020-12-15 17:50 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2020-12-15 17:42 UTC (permalink / raw)
To: 15763
Just found a real example of this problem:
test/lisp/org/org-tests.el: org-package-version fails in both emacs-27
and master. This is because there is no entry for org in
package--builtin-versions. And this is because the entry has gone to
lisp/org/org-loaddefs.el instead of lisp/loaddefs.el.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#15763: autoload-generate-file-autoloads can put package--builtin-versions in wrong file
2020-12-15 17:42 ` Glenn Morris
@ 2020-12-15 17:50 ` Glenn Morris
2020-12-15 18:13 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2020-12-15 17:50 UTC (permalink / raw)
To: 15763
Glenn Morris wrote:
> Just found a real example of this problem:
> test/lisp/org/org-tests.el: org-package-version fails in both emacs-27
> and master. This is because there is no entry for org in
> package--builtin-versions. And this is because the entry has gone to
> lisp/org/org-loaddefs.el instead of lisp/loaddefs.el.
Hmm, actually, that looks like a bug in org.el.
There is now no autoload for org-mode in emacs-27 -Q.
I wonder why org.el now puts all autoloads in org-loaddefs
(and why such a change is in a bugfix release).
There's zero information in the Emacs repository about the
reason behind any of the Org 9.4.1 changes ("Update to Org 9.4.1" is all
we get).
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-15 18:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-30 20:53 bug#15763: autoload-generate-file-autoloads can put package--builtin-versions in wrong file Glenn Morris
2020-12-06 15:14 ` Lars Ingebrigtsen
2020-12-06 22:42 ` Glenn Morris
2020-12-15 17:42 ` Glenn Morris
2020-12-15 17:50 ` Glenn Morris
2020-12-15 18:13 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).