From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#15763: autoload-generate-file-autoloads can put package--builtin-versions in wrong file Date: Sun, 06 Dec 2020 16:14:17 +0100 Message-ID: <87sg8j9dbq.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31745"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 15763@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 06 16:15:36 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klvlA-000875-3U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 16:15:36 +0100 Original-Received: from localhost ([::1]:47792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klvl8-0006rO-Gt for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 10:15:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klvkd-0006qz-Fo for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 10:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klvkc-000402-Mi for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 10:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klvkc-0002AP-Ic for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 10:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Dec 2020 15:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15763 X-GNU-PR-Package: emacs Original-Received: via spool by 15763-submit@debbugs.gnu.org id=B15763.16072676698249 (code B ref 15763); Sun, 06 Dec 2020 15:15:02 +0000 Original-Received: (at 15763) by debbugs.gnu.org; 6 Dec 2020 15:14:29 +0000 Original-Received: from localhost ([127.0.0.1]:50737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klvk4-00028z-Rv for submit@debbugs.gnu.org; Sun, 06 Dec 2020 10:14:29 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:54066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klvk2-00028l-Ph for 15763@debbugs.gnu.org; Sun, 06 Dec 2020 10:14:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+HLzjpiueZLbcOLnrV6br7a0j12Iufvw5GNnNyxztr0=; b=W6Eo2ldHf93RqtVGymJp7jLTXa mkMcQTW9VfsaTNRgyoHBJfO52n12WLTZxP2am/elPxTd00aWb9orL+hoCX3knqTJ0cwwKQA9sUZKd TNiBjc6gf58+JpLLbWYfS3iXuwHmHfs2euaf5IIsd0mK1GaL6dlcI7WMcOLJ5MKgH7R8=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klvju-0005OV-Fe; Sun, 06 Dec 2020 16:14:21 +0100 X-Now-Playing: Jlin's _Pres Rebooted_: "Lotus" In-Reply-To: (Glenn Morris's message of "Wed, 30 Oct 2013 16:53:02 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195112 Archived-At: Glenn Morris writes: > In current trunk, the autoload section of lisp/htmlfontify.el contains: > > ;;; Generated autoloads from hfy-cmap.el > (push (purecopy '(htmlfontify 0 20)) package--builtin-versions) > > That is: > > 1) Incorrect (htmlfontify.el is at version 0.21, whereas hfy-cmap.el is > at version 0.20). > > 2) In the wrong file. > > I guess autoload-generate-file-autoloads should only do the > package--builtin-versions stuff when writing to the top-level > loaddefs.el file, not when respecting a buffer-local > generated-autoload-file. I'm guessing this was fixed by this commit: commit 459cf7cb92445e9336d649f128ec1af274e3f5a1 Author: Phillip Lord AuthorDate: Wed Dec 16 23:15:44 2015 +0000 htmlfontify generate autoload to non-versioned file. * lisp/Makefile.in: Add htmlfontity-loaddefs to autogenel. * lisp/hfy-cmap.el: Update file local. * lisp/htmlfontify.el: Remove autoloads, add require. * test/lisp/htmlfontify-tests.el: Test autoload functionality. So I'm closing this bug report. Please reopen if there's more to be done here. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no