From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#15763: autoload-generate-file-autoloads can put package--builtin-versions in wrong file Date: Sun, 06 Dec 2020 17:42:54 -0500 Message-ID: References: <87sg8j9dbq.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14191"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) To: 15763@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 06 23:44:43 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1km2ln-0003b6-BB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 23:44:43 +0100 Original-Received: from localhost ([::1]:42952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km2lm-00080p-73 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 17:44:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1km2l7-00080c-SW for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 17:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1km2l7-0007eQ-LL for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 17:44:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1km2l7-0007Vq-JT for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 17:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Dec 2020 22:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15763 X-GNU-PR-Package: emacs Original-Received: via spool by 15763-submit@debbugs.gnu.org id=B15763.160729458528805 (code B ref 15763); Sun, 06 Dec 2020 22:44:01 +0000 Original-Received: (at 15763) by debbugs.gnu.org; 6 Dec 2020 22:43:05 +0000 Original-Received: from localhost ([127.0.0.1]:51658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km2kD-0007UX-7m for submit@debbugs.gnu.org; Sun, 06 Dec 2020 17:43:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km2kB-0007U2-4e for 15763@debbugs.gnu.org; Sun, 06 Dec 2020 17:43:03 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44869) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km2k5-0007N8-T6 for 15763@debbugs.gnu.org; Sun, 06 Dec 2020 17:42:57 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1km2k2-0000fA-Ni; Sun, 06 Dec 2020 17:42:54 -0500 X-Spook: Skipjack Nerve agent MS-13 constitution Incident Fort X-Ran: o2_A%jbhMuYY%[]/-0:)hq>2&R]oC*GXcI"fpT4krP:!('X(w_M-;E191(?y~d!vy]z9WS X-Hue: brightblack X-Attribution: GM In-Reply-To: <87sg8j9dbq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 06 Dec 2020 16:14:17 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195185 Archived-At: Lars Ingebrigtsen wrote: > Glenn Morris writes: > >> In current trunk, the autoload section of lisp/htmlfontify.el contains: >> >> ;;; Generated autoloads from hfy-cmap.el >> (push (purecopy '(htmlfontify 0 20)) package--builtin-versions) >> >> That is: >> >> 1) Incorrect (htmlfontify.el is at version 0.21, whereas hfy-cmap.el is >> at version 0.20). >> >> 2) In the wrong file. >> >> I guess autoload-generate-file-autoloads should only do the >> package--builtin-versions stuff when writing to the top-level >> loaddefs.el file, not when respecting a buffer-local >> generated-autoload-file. > > I'm guessing this was fixed by this commit: > > commit 459cf7cb92445e9336d649f128ec1af274e3f5a1 > Author: Phillip Lord > AuthorDate: Wed Dec 16 23:15:44 2015 +0000 > > htmlfontify generate autoload to non-versioned file. > > * lisp/Makefile.in: Add htmlfontity-loaddefs to autogenel. > * lisp/hfy-cmap.el: Update file local. > * lisp/htmlfontify.el: Remove autoloads, add require. > * test/lisp/htmlfontify-tests.el: Test autoload functionality. > > So I'm closing this bug report. Please reopen if there's more to be > done here. FTR, I was reporting a general issue, using htmlfontify as a specific example. So that change can't have fixed the general issue. It's still present, but seems not worth fixing.