unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: 15763@debbugs.gnu.org
Subject: bug#15763: autoload-generate-file-autoloads can put package--builtin-versions in wrong file
Date: Sun, 06 Dec 2020 17:42:54 -0500	[thread overview]
Message-ID: <eqim9e7dzl.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87sg8j9dbq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 06 Dec 2020 16:14:17 +0100")

Lars Ingebrigtsen wrote:

> Glenn Morris <rgm@gnu.org> writes:
>
>> In current trunk, the autoload section of lisp/htmlfontify.el contains:
>>
>>   ;;; Generated autoloads from hfy-cmap.el
>>   (push (purecopy '(htmlfontify 0 20)) package--builtin-versions)
>>
>> That is:
>>
>> 1) Incorrect (htmlfontify.el is at version 0.21, whereas hfy-cmap.el is
>> at version 0.20).
>>
>> 2) In the wrong file.
>>
>> I guess autoload-generate-file-autoloads should only do the
>> package--builtin-versions stuff when writing to the top-level
>> loaddefs.el file, not when respecting a buffer-local
>> generated-autoload-file.
>
> I'm guessing this was fixed by this commit:
>
> commit 459cf7cb92445e9336d649f128ec1af274e3f5a1
> Author:     Phillip Lord <phillip.lord@russet.org.uk>
> AuthorDate: Wed Dec 16 23:15:44 2015 +0000
>
>     htmlfontify generate autoload to non-versioned file.
>     
>     * lisp/Makefile.in: Add htmlfontity-loaddefs to autogenel.
>     * lisp/hfy-cmap.el: Update file local.
>     * lisp/htmlfontify.el: Remove autoloads, add require.
>     * test/lisp/htmlfontify-tests.el: Test autoload functionality.
>
> So I'm closing this bug report.  Please reopen if there's more to be
> done here.

FTR, I was reporting a general issue, using htmlfontify as a specific example.
So that change can't have fixed the general issue.
It's still present, but seems not worth fixing.






  reply	other threads:[~2020-12-06 22:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30 20:53 bug#15763: autoload-generate-file-autoloads can put package--builtin-versions in wrong file Glenn Morris
2020-12-06 15:14 ` Lars Ingebrigtsen
2020-12-06 22:42   ` Glenn Morris [this message]
2020-12-15 17:42     ` Glenn Morris
2020-12-15 17:50       ` Glenn Morris
2020-12-15 18:13         ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eqim9e7dzl.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=15763@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).