unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#57412: Could we make linum.el obsolete?
@ 2022-08-25 18:08 Stefan Kangas
  2022-08-25 18:29 ` Eli Zaretskii
                   ` (2 more replies)
  0 siblings, 3 replies; 13+ messages in thread
From: Stefan Kangas @ 2022-08-25 18:08 UTC (permalink / raw)
  To: 57412; +Cc: monnier

Severity: wishlist

Is there any reason to keep linum.el around any longer, or could it be
marked obsolete in favor of `display-line-numbers-mode'?

Given our obsoletion policy, it would still be around for another
decade, which should give users plenty of time to adapt.





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-25 18:08 bug#57412: Could we make linum.el obsolete? Stefan Kangas
@ 2022-08-25 18:29 ` Eli Zaretskii
  2022-08-26 11:11   ` Lars Ingebrigtsen
  2022-08-26  8:20 ` Colin Baxter
  2022-09-20 19:10 ` Stefan Kangas
  2 siblings, 1 reply; 13+ messages in thread
From: Eli Zaretskii @ 2022-08-25 18:29 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: 57412, monnier

> Cc: monnier@iro.umontreal.ca
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Thu, 25 Aug 2022 18:08:06 +0000
> 
> Severity: wishlist
> 
> Is there any reason to keep linum.el around any longer, or could it be
> marked obsolete in favor of `display-line-numbers-mode'?

The only possible reason is that linum.el allows more freedom in
formatting the line numbers and their faces.  I don't know whether
this reason is serious enough to not obsolete linum.el.





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-25 18:08 bug#57412: Could we make linum.el obsolete? Stefan Kangas
  2022-08-25 18:29 ` Eli Zaretskii
@ 2022-08-26  8:20 ` Colin Baxter
  2022-08-26 10:49   ` Dmitry Gutov
  2022-08-26 16:18   ` Drew Adams
  2022-09-20 19:10 ` Stefan Kangas
  2 siblings, 2 replies; 13+ messages in thread
From: Colin Baxter @ 2022-08-26  8:20 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: 57412, monnier

>>>>> Stefan Kangas <stefankangas@gmail.com> writes:

    > Severity: wishlist Is there any reason to keep linum.el around any
    > longer, or could it be marked obsolete in favor of
    > `display-line-numbers-mode'?

    > Given our obsoletion policy, it would still be around for another
    > decade, which should give users plenty of time to adapt.


Please do not obsolete this. I do not like display-line-numbers-mode,
preferring line numbers in the margin. There must be other users
similarly inclined.

I do not understand this need to obsolete packages that perform
perfectly well. Emacs often has multiple ways of achieving the same
outcome, which is surely a positive.

Best wishes,





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-26  8:20 ` Colin Baxter
@ 2022-08-26 10:49   ` Dmitry Gutov
  2022-08-26 19:00     ` Colin Baxter
  2022-08-26 16:18   ` Drew Adams
  1 sibling, 1 reply; 13+ messages in thread
From: Dmitry Gutov @ 2022-08-26 10:49 UTC (permalink / raw)
  To: m43cap, Stefan Kangas; +Cc: 57412, monnier

On 26.08.2022 11:20, Colin Baxter wrote:
>>>>>> Stefan Kangas<stefankangas@gmail.com>  writes:
>      > Severity: wishlist Is there any reason to keep linum.el around any
>      > longer, or could it be marked obsolete in favor of
>      > `display-line-numbers-mode'?
> 
>      > Given our obsoletion policy, it would still be around for another
>      > decade, which should give users plenty of time to adapt.
> 
> 
> Please do not obsolete this. I do not like display-line-numbers-mode,
> preferring line numbers in the margin. There must be other users
> similarly inclined.

Have you tried nlinum-mode from GNU ELPA? I hear it has better 
performance and apparently fewer bugs.

> I do not understand this need to obsolete packages that perform
> perfectly well. Emacs often has multiple ways of achieving the same
> outcome, which is surely a positive.

It's good to reduce the volume of code we have to support over time.

It would also help people land on a faster and better supported alternative.





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-25 18:29 ` Eli Zaretskii
@ 2022-08-26 11:11   ` Lars Ingebrigtsen
  2022-08-26 11:19     ` Dmitry Gutov
  0 siblings, 1 reply; 13+ messages in thread
From: Lars Ingebrigtsen @ 2022-08-26 11:11 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 57412, Stefan Kangas, monnier

Eli Zaretskii <eliz@gnu.org> writes:

> The only possible reason is that linum.el allows more freedom in
> formatting the line numbers and their faces.  I don't know whether
> this reason is serious enough to not obsolete linum.el.

I think nlinum is supposed to support everything that linum does (and is
faster and less buggy) -- but I haven't looked in detail.

If that's the case, then I think it would make sense to obsolete
linum.el.






^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-26 11:11   ` Lars Ingebrigtsen
@ 2022-08-26 11:19     ` Dmitry Gutov
  2022-08-26 16:55       ` Colin Baxter
  0 siblings, 1 reply; 13+ messages in thread
From: Dmitry Gutov @ 2022-08-26 11:19 UTC (permalink / raw)
  To: Lars Ingebrigtsen, Eli Zaretskii; +Cc: 57412, Stefan Kangas, monnier

On 26.08.2022 14:11, Lars Ingebrigtsen wrote:
> Eli Zaretskii<eliz@gnu.org>  writes:
> 
>> The only possible reason is that linum.el allows more freedom in
>> formatting the line numbers and their faces.  I don't know whether
>> this reason is serious enough to not obsolete linum.el.
> I think nlinum is supposed to support everything that linum does (and is
> faster and less buggy) -- but I haven't looked in detail.

Here's one such case when I ended just just recommending to avoid linum:

https://github.com/company-mode/company-mode/issues/1336





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-26  8:20 ` Colin Baxter
  2022-08-26 10:49   ` Dmitry Gutov
@ 2022-08-26 16:18   ` Drew Adams
  1 sibling, 0 replies; 13+ messages in thread
From: Drew Adams @ 2022-08-26 16:18 UTC (permalink / raw)
  To: m43cap@yandex.com, Stefan Kangas
  Cc: 57412@debbugs.gnu.org, monnier@iro.umontreal.ca

> I do not understand this need to obsolete packages that perform
> perfectly well. Emacs often has multiple ways of achieving the same
> outcome, which is surely a positive.

Marie-Condo Complex?

https://en.wikipedia.org/wiki/Marie_Kondo

Nothing wrong with some wanting to declutter
their _own_ lives and living rooms.  Emacs is
everyone's living room.  The Emacs way would
be to provide decluttering user options, to
let users decide for themselves. ;-)





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-26 11:19     ` Dmitry Gutov
@ 2022-08-26 16:55       ` Colin Baxter
  0 siblings, 0 replies; 13+ messages in thread
From: Colin Baxter @ 2022-08-26 16:55 UTC (permalink / raw)
  To: Dmitry Gutov
  Cc: Lars Ingebrigtsen, Stefan Kangas, Eli Zaretskii, monnier, 57412

>>>>> Dmitry Gutov <dgutov@yandex.ru> writes:

    > On 26.08.2022 14:11, Lars Ingebrigtsen wrote:
    >> Eli Zaretskii<eliz@gnu.org> writes:
    >> 
    >>> The only possible reason is that linum.el allows more freedom in
    >>> formatting the line numbers and their faces.  I don't know
    >>> whether this reason is serious enough to not obsolete linum.el.
    >> I think nlinum is supposed to support everything that linum does
    >> (and is faster and less buggy) -- but I haven't looked in detail.

    > Here's one such case when I ended just just recommending to avoid
    > linum:

    > https://github.com/company-mode/company-mode/issues/1336


I've never experienced any problems with linum.el but then my setup is
super-simple and does not include company-mode.

Best wishes,







^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-26 10:49   ` Dmitry Gutov
@ 2022-08-26 19:00     ` Colin Baxter
  2022-08-26 19:14       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 13+ messages in thread
From: Colin Baxter @ 2022-08-26 19:00 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: 57412, Stefan Kangas, monnier

>>>>> Dmitry Gutov <dgutov@yandex.ru> writes:

    > On 26.08.2022 11:20, Colin Baxter wrote:
    >>>>>>> Stefan Kangas<stefankangas@gmail.com> writes:
    >> > Severity: wishlist Is there any reason to keep linum.el around
    >> any > longer, or could it be marked obsolete in favor of >
    >> `display-line-numbers-mode'?  > Given our obsoletion policy, it
    >> would still be around for another > decade, which should give
    >> users plenty of time to adapt.  Please do not obsolete this. I do
    >> not like display-line-numbers-mode, preferring line numbers in
    >> the margin. There must be other users similarly inclined.

    > Have you tried nlinum-mode from GNU ELPA? I hear it has better
    > performance and apparently fewer bugs.

    >> I do not understand this need to obsolete packages that perform
    >> perfectly well. Emacs often has multiple ways of achieving the
    >> same outcome, which is surely a positive.

    > It's good to reduce the volume of code we have to support over
    > time.

    > It would also help people land on a faster and better supported
    > alternative.

Yes, I understand that and agree. From my perspective, I am disappointed
that candidates for obsolescence seem to be chosen from libraries that
are useful and not from morse, zone and the like.

Best wishes,





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-26 19:00     ` Colin Baxter
@ 2022-08-26 19:14       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2022-08-26 20:17         ` Colin Baxter
  0 siblings, 1 reply; 13+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-08-26 19:14 UTC (permalink / raw)
  To: Colin Baxter; +Cc: 57412, Stefan Kangas, Dmitry Gutov

Colin Baxter [2022-08-26 20:00:40] wrote:
> Yes, I understand that and agree. From my perspective, I am disappointed
> that candidates for obsolescence seem to be chosen from libraries that
> are useful and not from morse, zone and the like.

Those that are useful but suffer from corner-case problems due to the
underlying design are bound to fall into this trap: if they weren't
very useful, noone would bother to reimplement them to fix those
corner cases but since the problems stem from the underlying approach,
the fix requires a significant rewrite which inevitably leads to
a slightly different featureset.

The purpose of obsoleting a library like `nlinum.el` is to help/encourage
people to move to the better options out there (and sometimes also to
discover important use-cases not yet covered by the new code).

The maintenance cost of `nlinum.el` isn't very high, but there's a cost
for users of having to choose between various options, none of which is
a strict superset of the other.


        Stefan






^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-26 19:14       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2022-08-26 20:17         ` Colin Baxter
  2022-08-26 21:11           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 13+ messages in thread
From: Colin Baxter @ 2022-08-26 20:17 UTC (permalink / raw)
  To: 57412; +Cc: stefan, monnier, dgutov

>>>>> Bug reports for GNU Emacs, the Swiss army knife of text editors <Stefan> writes:

    > Colin Baxter [2022-08-26 20:00:40] wrote:
    >> Yes, I understand that and agree. From my perspective, I am
    >> disappointed that candidates for obsolescence seem to be chosen
    >> from libraries that are useful and not from morse, zone and the
    >> like.

    > Those that are useful but suffer from corner-case problems due to
    > the underlying design are bound to fall into this trap: if they
    > weren't very useful, noone would bother to reimplement them to fix
    > those corner cases but since the problems stem from the underlying
    > approach, the fix requires a significant rewrite which inevitably
    > leads to a slightly different featureset.

    > The purpose of obsoleting a library like `nlinum.el` is to
    > help/encourage people to move to the better options out there (and
    > sometimes also to discover important use-cases not yet covered by
    > the new code).

    > The maintenance cost of `nlinum.el` isn't very high, but there's a
    > cost for users of having to choose between various options, none
    > of which is a strict superset of the other.

I am not convinced. However thank you nevertheless for taking the time
and effort to explain.

Best wishes,





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-26 20:17         ` Colin Baxter
@ 2022-08-26 21:11           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 0 replies; 13+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-08-26 21:11 UTC (permalink / raw)
  To: Colin Baxter; +Cc: 57412, Stefan Kangas, Dmitry Gutov

Colin Baxter [2022-08-26 21:17:47] wrote:
> I am not convinced. However thank you nevertheless for taking the time
> and effort to explain.

BTW, obsoleting `linum.el` doesn't mean removing it from Emacs for
several more years.  And even if/when we do decide to remove it, we can
move it to GNU ELPA instead if there's still interest.


        Stefan






^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#57412: Could we make linum.el obsolete?
  2022-08-25 18:08 bug#57412: Could we make linum.el obsolete? Stefan Kangas
  2022-08-25 18:29 ` Eli Zaretskii
  2022-08-26  8:20 ` Colin Baxter
@ 2022-09-20 19:10 ` Stefan Kangas
  2 siblings, 0 replies; 13+ messages in thread
From: Stefan Kangas @ 2022-09-20 19:10 UTC (permalink / raw)
  To: 57412; +Cc: monnier

close 57412 29.1
thanks

Stefan Kangas <stefankangas@gmail.com> writes:

> Is there any reason to keep linum.el around any longer, or could it be
> marked obsolete in favor of `display-line-numbers-mode'?

(That was 4 weeks ago.)

Despite one notable objection on the grounds that it is still useful,
most people here seem to agree that we can go ahead and obsolete it,
given that it can be replaced by `nlinum' (on GNU ELPA) which is faster
and has less bugs.[1]

Meanwhile, Stefan Monnier pointed out that:[2]

> [O]bsoleting `linum.el` doesn't mean removing it from Emacs for
> several more years.  And even if/when we do decide to remove it, we
> can move it to GNU ELPA instead if there's still interest.

So I've now obsoleted linum.el in commit 903de63c6c and d506d91b1f, and
I'm closing this bug.  We recommend `nlinum' as a close to drop-in
replacement, alternatively `display-line-numbers-mode'.

Footnotes:
[1] Users also seem to like `nlinum', see e.g.:
     https://github.com/company-mode/company-mode/issues/1336

[2] Hopefully, however, Emacs will be shipping with nlinum.el included
     in our release tarballs by then.  We just need to figure out how to
     properly integrate GNU ELPA packages first.





^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-09-20 19:10 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-25 18:08 bug#57412: Could we make linum.el obsolete? Stefan Kangas
2022-08-25 18:29 ` Eli Zaretskii
2022-08-26 11:11   ` Lars Ingebrigtsen
2022-08-26 11:19     ` Dmitry Gutov
2022-08-26 16:55       ` Colin Baxter
2022-08-26  8:20 ` Colin Baxter
2022-08-26 10:49   ` Dmitry Gutov
2022-08-26 19:00     ` Colin Baxter
2022-08-26 19:14       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-26 20:17         ` Colin Baxter
2022-08-26 21:11           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-26 16:18   ` Drew Adams
2022-09-20 19:10 ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).