bug#47262: [platform-testers] Emacs 27.2 RC2

bug#47262: [platform-testers] Emacs 27.2 RC2

[Dagobert Michelsen]

Hi Eli,

Am 19.03.2021 um 08:35 schrieb Eli Zaretskii <eliz@gnu.org>:
> The second release candidate for what will be the 27.2 release of Emacs
> (the extensible text editor) is now available at
> 
>  https://alpha.gnu.org/gnu/emacs/pretest/emacs-27.2-rc2.tar.xz
> 
> The tarball is signed; you can get the PGP signature file at
> 
>  https://alpha.gnu.org/gnu/emacs/pretest/emacs-27.2-rc2.tar.xz.sig
> 
> Please give it as much testing as you can.
> 
> As always, if you encounter problems building or using Emacs,
> send a report to bug-gnu-emacs@gnu.org with full details
> (if possible, use M-x report-emacs-bug).
> 
> Thanks for helping to test Emacs.

I have a couple of test failures with Solaris 10 Sparc and Sun Studio:

SUMMARY OF TEST RESULTS
-----------------------
Files examined: 267
Ran 3829 tests, 77 failed to run, 3716 results as expected, 23 unexpected, 90 skipped
3 files did not finish:
  src/emacs-module-tests.log
  lisp/progmodes/sql-tests.log
  lisp/auth-source-tests.log
8 files contained unexpected results:
  lisp/vc/diff-mode-tests.log
  lisp/progmodes/xref-tests.log
  lisp/progmodes/flymake-tests.log
  lisp/net/nsm-tests.log
  lisp/net/network-stream-tests.log
  lisp/files-tests.log
  lisp/filenotify-tests.log
  lisp/cedet/semantic-utest-ia.log
gmake[2]: *** [Makefile:318: check-doit] Error 2

All logfiles are available from the buildfarm at
  http://buildfarm.opencsw.org/~dam/emacs-27.2-rc2-logs.tar.gz


Best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

bug#47262: [platform-testers] Emacs 27.2 RC2

[Eli Zaretskii]

> From: Dagobert Michelsen <dam@opencsw.org>
> Date: Fri, 19 Mar 2021 14:42:23 +0100
> 
> All logfiles are available from the buildfarm at
>   http://buildfarm.opencsw.org/~dam/emacs-27.2-rc2-logs.tar.gz

Thanks.

bug#47262: [platform-testers] Emacs 27.2 RC2

[Robert Pluim]

>>>>> On Fri, 19 Mar 2021 14:42:23 +0100, Dagobert Michelsen <dam@opencsw.org> said:

    Dagobert>   lisp/net/nsm-tests.log

This is Bug#45798, I think, fixed on master by 6dc4fc7d62. Itʼs a
trivial change, I guess we could cherry-pick it to emacs-27, but itʼs
in a code path that no sane user would enable.

    Dagobert>   lisp/net/network-stream-tests.log

And this is 90ac405702, and by extension Bug#46709 and
Bug#46641. Thatʼs probably a bit much to put into emacs-27 (the
underlying code is mostly fine, itʼs the tests that are wrong)

Robert
-- 

bug#47262: [platform-testers] Emacs 27.2 RC2

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: eliz@gnu.org,  47262@debbugs.gnu.org
> Date: Fri, 19 Mar 2021 19:03:09 +0100
> 
> >>>>> On Fri, 19 Mar 2021 14:42:23 +0100, Dagobert Michelsen <dam@opencsw.org> said:
> 
>     Dagobert>   lisp/net/nsm-tests.log
> 
> This is Bug#45798, I think, fixed on master by 6dc4fc7d62. Itʼs a
> trivial change, I guess we could cherry-pick it to emacs-27, but itʼs
> in a code path that no sane user would enable.
> 
>     Dagobert>   lisp/net/network-stream-tests.log
> 
> And this is 90ac405702, and by extension Bug#46709 and
> Bug#46641. Thatʼs probably a bit much to put into emacs-27 (the
> underlying code is mostly fine, itʼs the tests that are wrong)

Thanks.  I think we are good for 27.2.  There's always one more bug.

bug#47262: [platform-testers] Emacs 27.2 RC2

[Michael Albinus]

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

Dagobert Michelsen <dam@opencsw.org> writes:

Hi Dago,

> I have a couple of test failures with Solaris 10 Sparc and Sun Studio:

Thanks a lot!

>   lisp/filenotify-tests.log

These errors are only in the filenotify-tests.el. There's no reason to
stop Emacs 27.2 because of this.

Running 8 tests (2021-03-19 11:06:22+0100, selector `(not (or (tag :expensive-test) (tag :unstable)))')
Library: `gfilenotify'
Monitor: `GFamDirectoryMonitor'

Wow! I know that the GFamDirectoryMonitor exists (it is in the gio
sources), but I couldn't test it ever. Solaris.

Could you pls apply the appended patch to filenotify-tests.el and show
the changed filenotify-tests.log file? Many thanks in advance (and be
prepared, I will exploit you iteratively until all tests pass. If you
agree :-)

> Best regards
>
>   — Dago

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1882 bytes --]

*** /tmp/ediffGmYi43	2021-03-20 09:57:10.563305971 +0100
--- /home/albinus/src/emacs-27/test/lisp/filenotify-tests.el	2021-03-20 09:55:13.121660549 +0100
***************
*** 109,115 ****
      ;; at least on Cygwin.
      ((and (string-equal (file-notify--test-library) "gfilenotify")
            (memq (file-notify--test-monitor)
!                 '(GFamFileMonitor GPollFileMonitor)))
       7)
      ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
      ((file-remote-p temporary-file-directory) 0.1)
--- 109,115 ----
      ;; at least on Cygwin.
      ((and (string-equal (file-notify--test-library) "gfilenotify")
            (memq (file-notify--test-monitor)
!                 '(GFamFileMonitor GFamDirectoryMonitor GPollFileMonitor)))
       7)
      ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
      ((file-remote-p temporary-file-directory) 0.1)
***************
*** 1021,1026 ****
--- 1021,1029 ----
  	     ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  		(changed deleted stopped)))
+ 	     ;; GFamDirectoryMonitor does not report the `changed' event.
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '(deleted stopped))
  	     ;; There could be one or two `changed' events.
  	     (t '((changed deleted stopped)
  		  (changed changed deleted stopped))))
***************
*** 1286,1291 ****
--- 1289,1297 ----
               ;; On cygwin we only get the `changed' event.
               ((eq system-type 'cygwin)
                '(changed))
+ 	     ;; GFamDirectoryMonitor reports only the `changed' event.
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '(changed))
               (t '(renamed created changed)))
            ;; The file is renamed when creating a backup.  It shall
            ;; still be watched.

bug#47262: [platform-testers] Emacs 27.2 RC2

[Dagobert Michelsen]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

Hi Michael,

Am 20.03.2021 um 10:04 schrieb Michael Albinus <michael.albinus@gmx.de>:
> Dagobert Michelsen <dam@opencsw.org> writes:
> Wow! I know that the GFamDirectoryMonitor exists (it is in the gio
> sources), but I couldn't test it ever. Solaris.
> 
> Could you pls apply the appended patch to filenotify-tests.el and show
> the changed filenotify-tests.log file?

Sure, please find the file attached.


[-- Attachment #2: filenotify-tests.log --]
[-- Type: application/octet-stream, Size: 3338 bytes --]

Running 8 tests (2021-03-20 14:07:20+0100, selector `(not (or (tag :expensive-test) (tag :unstable)))')
Library: `gfilenotify'
Monitor: `GFamDirectoryMonitor'
   passed  1/8  file-notify-test00-availability (0.114761 sec)
   passed  2/8  file-notify-test01-add-watch (0.021881 sec)
   passed  3/8  file-notify-test02-rm-watch (0.983746 sec)
Test file-notify-test03-events backtrace:
  signal(ert-test-failed (((should (file-notify--test-with-actions-che
  ert-fail(((should (file-notify--test-with-actions-check actions)) :f
  #f(compiled-function () #<bytecode 0x165123>)()
  ert--run-test-internal(#s(ert--test-execution-info #s(ert-test file-
  ert-run-test(#s(ert-test file-notify-test03-events "Check file creat
  ert-run-or-rerun-test(#s(ert--stats (not ...) [#s(ert-test file-noti
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/filenotify-tests" "-
  command-line()
  normal-top-level()
Test file-notify-test03-events condition:
    (ert-test-failed
     ((should
       (file-notify--test-with-actions-check actions))
      :form
      (file-notify--test-with-actions-check
       ((created changed deleted stopped)))
      :value nil :explanation "Received actions do not match expected actions
(created deleted stopped)
(created changed deleted stopped)"))
   FAILED  4/8  file-notify-test03-events (17.010461 sec)
Reverting buffer `file-notify-test9LC2IC'.
Reverting buffer `file-notify-test9LC2IC'.
   passed  5/8  file-notify-test04-autorevert (18.041446 sec)
Test file-notify-test05-file-validity backtrace:
  signal(ert-test-failed (((should (file-notify--test-with-actions-che
  ert-fail(((should (file-notify--test-with-actions-check actions)) :f
  #f(compiled-function () #<bytecode 0x1655d5>)()
  ert--run-test-internal(#s(ert--test-execution-info #s(ert-test file-
  ert-run-test(#s(ert-test file-notify-test05-file-validity "Check `fi
  ert-run-or-rerun-test(#s(ert--stats (not ...) [#s(ert-test file-noti
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/filenotify-tests" "-
  command-line()
  normal-top-level()
Test file-notify-test05-file-validity condition:
    (ert-test-failed
     ((should
       (file-notify--test-with-actions-check actions))
      :form
      (file-notify--test-with-actions-check
       ((deleted stopped)))
      :value nil :explanation "Received actions do not match expected actions
(changed deleted stopped)
(deleted stopped)"))
   FAILED  6/8  file-notify-test05-file-validity (17.017923 sec)
   passed  7/8  file-notify-test06-dir-validity (3.011006 sec)
   passed  8/8  file-notify-test08-backup (26.051246 sec)

Ran 8 tests, 6 results as expected, 2 unexpected (2021-03-20 14:08:43+0100, 83.188041 sec)

2 unexpected results:
   FAILED  file-notify-test03-events
   FAILED  file-notify-test05-file-validity


[-- Attachment #3: Type: text/plain, Size: 353 bytes --]



> Many thanks in advance (and be
> prepared, I will exploit you iteratively until all tests pass. If you
> agree :-)

Of course :-)


Best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

bug#47262: [platform-testers] Emacs 27.2 RC2

[Michael Albinus]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Dagobert Michelsen <dam@opencsw.org> writes:

> Hi Michael,

Hi Dago,

>> Many thanks in advance (and be
>> prepared, I will exploit you iteratively until all tests pass. If you
>> agree :-)
>
> Of course :-)

Well, here's another patch you could apply instead. I've changed the
tests as indicated in the previous log file. And in order to cut the
number of iterations, I don't let fail the tests any longer, but let
them trace what happens. Could you, pls, send me the next log file,
produced after applying this patch?

> Best regards
>
>   — Dago

Thanks, and best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 5046 bytes --]

*** /tmp/ediffumMrVc	2021-03-20 16:50:58.959414691 +0100
--- /home/albinus/src/emacs-27/test/lisp/filenotify-tests.el	2021-03-20 16:44:46.138512407 +0100
***************
*** 109,115 ****
      ;; at least on Cygwin.
      ((and (string-equal (file-notify--test-library) "gfilenotify")
            (memq (file-notify--test-monitor)
!                 '(GFamFileMonitor GPollFileMonitor)))
       7)
      ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
      ((file-remote-p temporary-file-directory) 0.1)
--- 109,115 ----
      ;; at least on Cygwin.
      ((and (string-equal (file-notify--test-library) "gfilenotify")
            (memq (file-notify--test-monitor)
!                 '(GFamFileMonitor GFamDirectoryMonitor GPollFileMonitor)))
       7)
      ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
      ((file-remote-p temporary-file-directory) 0.1)
***************
*** 607,613 ****
           (ert-fail
            (cadr (ert-test-result-with-condition-condition result)))))
       ;; One of the possible event sequences shall match.
!      (should (file-notify--test-with-actions-check actions))))

  (ert-deftest file-notify-test03-events ()
    "Check file creation/change/removal notifications."
--- 607,617 ----
           (ert-fail
            (cadr (ert-test-result-with-condition-condition result)))))
       ;; One of the possible event sequences shall match.
!      (if (file-notify--test-with-actions-check actions)
!          (message
!           "Success!\n%s"
!           (mapcar #'file-notify--test-event-action file-notify--test-events))
!        (message (file-notify--test-with-actions-explainer actions)))))

  (ert-deftest file-notify-test03-events ()
    "Check file creation/change/removal notifications."
***************
*** 635,640 ****
--- 639,647 ----
               ;; cygwin does not raise a `changed' event.
               ((eq system-type 'cygwin)
                '(created deleted stopped))
+ 	     ;; GFamDirectoryMonitor does not report the `changed' event.
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '(created deleted stopped))
               (t '(created changed deleted stopped)))
            (write-region
             "another text" nil file-notify--test-tmpfile nil 'no-message)
***************
*** 666,672 ****
  	      '((deleted stopped)
  		(changed deleted stopped)))
  	     ;; There could be one or two `changed' events.
! 	     (t '((changed deleted stopped)
  		  (changed changed deleted stopped))))
            (write-region
             "another text" nil file-notify--test-tmpfile nil 'no-message)
--- 673,682 ----
  	      '((deleted stopped)
  		(changed deleted stopped)))
  	     ;; There could be one or two `changed' events.
! 	     ;; GFamDirectoryMonitor does not report the `changed' event.
! 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
! 	      '(deleted stopped))
!  	     (t '((changed deleted stopped)
  		  (changed changed deleted stopped))))
            (write-region
             "another text" nil file-notify--test-tmpfile nil 'no-message)
***************
*** 713,719 ****
  	     ;; cygwin does not raise a `changed' event.
  	     ((eq system-type 'cygwin)
  	      '(created deleted stopped))
! 	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed deleted stopped))
  	     (t '(created changed deleted deleted stopped)))
  	  (write-region
--- 723,732 ----
  	     ;; cygwin does not raise a `changed' event.
  	     ((eq system-type 'cygwin)
  	      '(created deleted stopped))
! 	     ;; GFamDirectoryMonitor does not report the `changed' event.
! 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
! 	      '(created deleted stopped))
!  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed deleted stopped))
  	     (t '(created changed deleted deleted stopped)))
  	  (write-region
***************
*** 1021,1026 ****
--- 1034,1042 ----
  	     ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  		(changed deleted stopped)))
+ 	     ;; GFamDirectoryMonitor does not report the `changed' event.
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '(deleted stopped))
  	     ;; There could be one or two `changed' events.
  	     (t '((changed deleted stopped)
  		  (changed changed deleted stopped))))
***************
*** 1286,1291 ****
--- 1302,1310 ----
               ;; On cygwin we only get the `changed' event.
               ((eq system-type 'cygwin)
                '(changed))
+ 	     ;; GFamDirectoryMonitor reports only the `changed' event.
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '(changed))
               (t '(renamed created changed)))
            ;; The file is renamed when creating a backup.  It shall
            ;; still be watched.

bug#47262: [platform-testers] Emacs 27.2 RC2

[Dagobert Michelsen]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

Hallo Michael,

Am 20.03.2021 um 16:52 schrieb Michael Albinus <michael.albinus@gmx.de>:
> Well, here's another patch you could apply instead. I've changed the
> tests as indicated in the previous log file. And in order to cut the
> number of iterations, I don't let fail the tests any longer, but let
> them trace what happens. Could you, pls, send me the next log file,
> produced after applying this patch?

Here is the log file from the recent patch:


[-- Attachment #2: filenotify-tests.log --]
[-- Type: application/octet-stream, Size: 1624 bytes --]

Running 8 tests (2021-03-20 18:16:55+0100, selector `(not (or (tag :expensive-test) (tag :unstable)))')
Library: `gfilenotify'
Monitor: `GFamDirectoryMonitor'
   passed  1/8  file-notify-test00-availability (0.103754 sec)
   passed  2/8  file-notify-test01-add-watch (0.014330 sec)
   passed  3/8  file-notify-test02-rm-watch (1.003603 sec)
Success!
(created deleted stopped)
Received actions do not match expected actions
(changed deleted stopped)
(deleted stopped)
Success!
(created deleted stopped)
Received actions do not match expected actions
(created created changed changed deleted stopped)
(created changed created changed deleted deleted deleted stopped)
Received actions do not match expected actions
(created created deleted deleted stopped)
(created changed renamed deleted deleted stopped)
Received actions do not match expected actions
nil
(attribute-changed attribute-changed)
   passed  4/8  file-notify-test03-events (144.107015 sec)
Reverting buffer `file-notify-testoR7LG5'.
Reverting buffer `file-notify-testoR7LG5'.
   passed  5/8  file-notify-test04-autorevert (18.063908 sec)
Received actions do not match expected actions
(changed deleted stopped)
(deleted stopped)
Received actions do not match expected actions
(created deleted stopped)
(created changed deleted deleted stopped)
   passed  6/8  file-notify-test05-file-validity (34.039652 sec)
   passed  7/8  file-notify-test06-dir-validity (3.012760 sec)
Success!
(changed)
Success!
(changed)
   passed  8/8  file-notify-test08-backup (26.072395 sec)

Ran 8 tests, 8 results as expected, 0 unexpected (2021-03-20 18:20:42+0100, 226.429326 sec)


[-- Attachment #3: Type: text/plain, Size: 214 bytes --]




Best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

bug#47262: [platform-testers] Emacs 27.2 RC2

[Michael Albinus]

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

Dagobert Michelsen <dam@opencsw.org> writes:

> Hallo Michael,

Hi Dago,

> Here is the log file from the recent patch:

Thanks. I've appended another patch, which should fix all open problems
on Solaris. Could you pls check?

Furthermore, I have seen that you didn't run the expensive tests
file-notify-test07-many-events and
file-notify-test09-watched-file-in-watched-dir. I expect further
problems there, so please call

# make -C test filenotify-tests.log

Likely, there will be other errors. In that case, set file-notify-debug
to t (line 201), and rerun that expensive test. There will be similar
traces in the log file as you have sent already, which shall allow me to
continue to work.

> Best regards
>
>   — Dago

Many thanks, and best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 13038 bytes --]

*** /tmp/ediffpZId9s	2021-03-21 13:38:20.876372597 +0100
--- /usr/local/src/emacs-27/test/lisp/filenotify-tests.el	2021-03-21 13:36:24.497655703 +0100
***************
*** 105,115 ****
     (cond
      ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5.  So we must
      ;; wait at least this time in the GPollFileMonitor case.  A
!     ;; similar timeout seems to be needed in the GFamFileMonitor case,
!     ;; at least on Cygwin.
      ((and (string-equal (file-notify--test-library) "gfilenotify")
            (memq (file-notify--test-monitor)
!                 '(GFamFileMonitor GPollFileMonitor)))
       7)
      ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
      ((file-remote-p temporary-file-directory) 0.1)
--- 105,115 ----
     (cond
      ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5.  So we must
      ;; wait at least this time in the GPollFileMonitor case.  A
!     ;; similar timeout seems to be needed in the GFamFileMonitor and
!     ;; GFamDirectoryMonitor case, at least on cygwin.
      ((and (string-equal (file-notify--test-library) "gfilenotify")
            (memq (file-notify--test-monitor)
!                 '(GFamFileMonitor GFamDirectoryMonitor GPollFileMonitor)))
       7)
      ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
      ((file-remote-p temporary-file-directory) 0.1)
***************
*** 455,461 ****

    (unwind-protect
        ;; Check, that removing watch descriptors out of order do not
!       ;; harm.  This fails on Cygwin because of timing issues unless a
        ;; long `sit-for' is added before the call to
        ;; `file-notify--test-read-event'.
        (unless (eq system-type 'cygwin)
--- 455,461 ----

    (unwind-protect
        ;; Check, that removing watch descriptors out of order do not
!       ;; harm.  This fails on cygwin because of timing issues unless a
        ;; long `sit-for' is added before the call to
        ;; `file-notify--test-read-event'.
        (unless (eq system-type 'cygwin)
***************
*** 542,547 ****
--- 542,551 ----
  	    file-notify--test-results
  	    (append file-notify--test-results `(,result))))))

+ (defun file-notify--test-event-actions ()
+   "Helper function to return retrieved actions, as list."
+   (mapcar #'file-notify--test-event-action file-notify--test-events))
+
  (defun file-notify--test-with-actions-check (actions)
    "Check whether received actions match one of the ACTIONS alternatives."
    (let (result)
***************
*** 550,571 ****
              (or result
                  (if (eq (car elt) :random)
                      (equal (sort (cdr elt) 'string-lessp)
!                            (sort (mapcar #'file-notify--test-event-action
!                                          file-notify--test-events)
                                   'string-lessp))
!                   (equal elt (mapcar #'file-notify--test-event-action
!                                      file-notify--test-events))))))))

  (defun file-notify--test-with-actions-explainer (actions)
    "Explain why `file-notify--test-with-actions-check' fails."
    (if (null (cdr actions))
        (format "Received actions do not match expected actions\n%s\n%s"
!               (mapcar #'file-notify--test-event-action file-notify--test-events)
!               (car actions))
      (format
       "Received actions do not match any sequence of expected actions\n%s\n%s"
!      (mapcar #'file-notify--test-event-action file-notify--test-events)
!      actions)))

  (put 'file-notify--test-with-actions-check 'ert-explainer
       'file-notify--test-with-actions-explainer)
--- 554,578 ----
              (or result
                  (if (eq (car elt) :random)
                      (equal (sort (cdr elt) 'string-lessp)
!                            (sort (file-notify--test-event-actions)
                                   'string-lessp))
!                   (equal elt (file-notify--test-event-actions))))))
!     ;; Do not report result in case we debug.  Write messages instead.
!     (if file-notify-debug
!         (prog1 t
!           (if result
!               (message "Success\n%s" (file-notify--test-event-actions))
!             (message (file-notify--test-with-actions-explainer actions))))
!       result)))

  (defun file-notify--test-with-actions-explainer (actions)
    "Explain why `file-notify--test-with-actions-check' fails."
    (if (null (cdr actions))
        (format "Received actions do not match expected actions\n%s\n%s"
!               (file-notify--test-event-actions) (car actions))
      (format
       "Received actions do not match any sequence of expected actions\n%s\n%s"
!      (file-notify--test-event-actions) actions)))

  (put 'file-notify--test-with-actions-check 'ert-explainer
       'file-notify--test-with-actions-explainer)
***************
*** 635,640 ****
--- 642,650 ----
               ;; cygwin does not raise a `changed' event.
               ((eq system-type 'cygwin)
                '(created deleted stopped))
+ 	     ;; GFamDirectoryMonitor does not report the `changed' event.
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '(created deleted stopped))
               (t '(created changed deleted stopped)))
            (write-region
             "another text" nil file-notify--test-tmpfile nil 'no-message)
***************
*** 665,670 ****
--- 675,685 ----
  	     ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  		(changed deleted stopped)))
+ 	     ;; GFamDirectoryMonitor does not detect the `changed'
+              ;; event reliably.
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '((deleted stopped)
+ 		(changed deleted stopped)))
  	     ;; There could be one or two `changed' events.
  	     (t '((changed deleted stopped)
  		  (changed changed deleted stopped))))
***************
*** 713,718 ****
--- 728,736 ----
  	     ;; cygwin does not raise a `changed' event.
  	     ((eq system-type 'cygwin)
  	      '(created deleted stopped))
+ 	     ;; GFamDirectoryMonitor does not report the `changed' event.
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '(created deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed deleted stopped))
  	     (t '(created changed deleted deleted stopped)))
***************
*** 755,763 ****
  	      '((deleted stopped)
  		(created created deleted stopped)))
  	     ;; There are three `deleted' events, for two files and
! 	     ;; for the directory.  Except for cygwin and kqueue.
  	     ((eq system-type 'cygwin)
  	      '(created created changed changed deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed created changed deleted stopped))
               ;; On emba, `deleted' and `stopped' events of the
--- 773,784 ----
  	      '((deleted stopped)
  		(created created deleted stopped)))
  	     ;; There are three `deleted' events, for two files and
! 	     ;; for the directory.  Except for cygwin,
! 	     ;; GFamDirectoryMonitor and kqueue.
  	     ((eq system-type 'cygwin)
  	      '(created created changed changed deleted stopped))
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '(created created changed changed deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed created changed deleted stopped))
               ;; On emba, `deleted' and `stopped' events of the
***************
*** 813,823 ****
               ((getenv "EMACS_EMBA_CI")
                '(created changed renamed deleted))
  	     ;; There are two `deleted' events, for the file and for
! 	     ;; the directory.  Except for cygwin and kqueue.  And
! 	     ;; cygwin raises `created' and `deleted' events instead
! 	     ;; of a `renamed' event.
  	     ((eq system-type 'cygwin)
  	      '(created created deleted deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed renamed deleted stopped))
  	     (t '(created changed renamed deleted deleted stopped)))
--- 834,847 ----
               ((getenv "EMACS_EMBA_CI")
                '(created changed renamed deleted))
  	     ;; There are two `deleted' events, for the file and for
! 	     ;; the directory.  Except for cygwin,
! 	     ;; GFamDirectoryMonitor and kqueue.  And cygwin and
! 	     ;; GFamDirectoryMonitor raise `created' and `deleted'
! 	     ;; events instead of a `renamed' event.
  	     ((eq system-type 'cygwin)
  	      '(created created deleted deleted stopped))
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '(created created deleted deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed renamed deleted stopped))
  	     (t '(created changed renamed deleted deleted stopped)))
***************
*** 837,844 ****
      (file-notify--test-cleanup))

    (unwind-protect
!       ;; Check attribute change.  Does not work for cygwin.
!       (unless (eq system-type 'cygwin)
  	(setq file-notify--test-tmpfile (file-notify--test-make-temp-name))
  	(write-region
  	 "any text" nil file-notify--test-tmpfile nil 'no-message)
--- 861,870 ----
      (file-notify--test-cleanup))

    (unwind-protect
!       ;; Check attribute change.  Does not work for cygwin and
!       ;; GFamDirectoryMonitor.
!       (unless (or (eq system-type 'cygwin)
!                   (equal (file-notify--test-monitor) 'GFamDirectoryMonitor))
  	(setq file-notify--test-tmpfile (file-notify--test-make-temp-name))
  	(write-region
  	 "any text" nil file-notify--test-tmpfile nil 'no-message)
***************
*** 951,957 ****

  	    ;; Modify file.  We wait for two seconds, in order to
  	    ;; have another timestamp.  One second seems to be too
!             ;; short.  And Cygwin sporadically requires more than two.
              (ert-with-message-capture captured-messages
                (sleep-for (if (eq system-type 'cygwin) 3 2))
                (write-region
--- 977,983 ----

  	    ;; Modify file.  We wait for two seconds, in order to
  	    ;; have another timestamp.  One second seems to be too
!             ;; short.  And cygwin sporadically requires more than two.
              (ert-with-message-capture captured-messages
                (sleep-for (if (eq system-type 'cygwin) 3 2))
                (write-region
***************
*** 1021,1026 ****
--- 1047,1057 ----
  	     ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  		(changed deleted stopped)))
+ 	     ;; GFamDirectoryMonitor does not detect the `changed'
+              ;; event reliably.
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '((deleted stopped)
+ 	        (changed deleted stopped)))
  	     ;; There could be one or two `changed' events.
  	     (t '((changed deleted stopped)
  		  (changed changed deleted stopped))))
***************
*** 1064,1073 ****
  	        '((deleted stopped)
  	          (created deleted stopped)))
  	       ;; There are two `deleted' events, for the file and for
! 	       ;; the directory.  Except for cygwin and kqueue.  And
! 	       ;; cygwin does not raise a `changed' event.
  	       ((eq system-type 'cygwin)
  	        '(created deleted stopped))
  	       ((string-equal (file-notify--test-library) "kqueue")
  	        '(created changed deleted stopped))
  	       (t '(created changed deleted deleted stopped)))
--- 1095,1107 ----
  	        '((deleted stopped)
  	          (created deleted stopped)))
  	       ;; There are two `deleted' events, for the file and for
! 	       ;; the directory.  Except for cygwin,
! 	       ;; GFamDirectoryMonitor and kqueue.  And cygwin and
! 	       ;; GFamDirectoryMonitor do not raise a `changed' event.
  	       ((eq system-type 'cygwin)
  	        '(created deleted stopped))
+ 	       ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	        '(created deleted stopped))
  	       ((string-equal (file-notify--test-library) "kqueue")
  	        '(created changed deleted stopped))
  	       (t '(created changed deleted deleted stopped)))
***************
*** 1286,1291 ****
--- 1320,1328 ----
               ;; On cygwin we only get the `changed' event.
               ((eq system-type 'cygwin)
                '(changed))
+ 	     ;; GFamDirectoryMonitor reports only the `changed' event.
+ 	     ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ 	      '(changed))
               (t '(renamed created changed)))
            ;; The file is renamed when creating a backup.  It shall
            ;; still be watched.

bug#47262: [platform-testers] Emacs 27.2 RC2

[Dagobert Michelsen]

Hi Michael,

Am 21.03.2021 um 13:48 schrieb Michael Albinus <michael.albinus@gmx.de>:
> Thanks. I've appended another patch, which should fix all open problems
> on Solaris. Could you pls check?
> 
> Furthermore, I have seen that you didn't run the expensive tests
> file-notify-test07-many-events and
> file-notify-test09-watched-file-in-watched-dir. I expect further
> problems there, so please call
> 
> # make -C test filenotify-tests.log

This does not terminate in test #7 and I manually needed to kill it:

/bin/bash: line 2: 26390 Terminated              HOME=/nonexistent EMACSLOADPATH= LC_ALL=C EMACS_TEST_DIRECTORY=/home/dam/mgar/pkg/emacs/trunk/work/solaris10-sparc/build-isa-sparcv8plus-features-athena/emacs-27.2/test "../src/emacs" --module-assertions --no-init-file --no-site-file --no-site-lisp -L ":." -l ert -l lisp/filenotify-tests.el --batch --eval '(ert-run-tests-batch-and-exit (quote (not (tag :unstable))))' > lisp/filenotify-tests.log 2>&1


Best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

bug#47262: [platform-testers] Emacs 27.2 RC2

[Michael Albinus]

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

Dagobert Michelsen <dam@opencsw.org> writes:

> Hi Michael,

Hi Dago,

>> # make -C test filenotify-tests.log
>
> This does not terminate in test #7 and I manually needed to kill it:

Oops, yes. file-notify-test07-many-events and
file-notify-test09-watched-file-in-watched-dir run large loops. I've
reduced the number of iterations in both tests, see appended patch. It
contains also some other changes I have applied last days, testing on cygwin.

> Best regards
>
>   — Dago

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 19582 bytes --]

*** /tmp/ediffmmNEZ6	2021-03-22 15:43:13.464939528 +0100
--- /home/albinus/src/emacs-27/test/lisp/filenotify-tests.el	2021-03-22 15:41:35.740131740 +0100
***************
*** 105,115 ****
     (cond
      ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5.  So we must
      ;; wait at least this time in the GPollFileMonitor case.  A
!     ;; similar timeout seems to be needed in the GFamFileMonitor case,
!     ;; at least on Cygwin.
!     ((and (string-equal (file-notify--test-library) "gfilenotify")
!           (memq (file-notify--test-monitor)
!                 '(GFamFileMonitor GPollFileMonitor)))
       7)
      ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
      ((file-remote-p temporary-file-directory) 0.1)
--- 105,114 ----
     (cond
      ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5.  So we must
      ;; wait at least this time in the GPollFileMonitor case.  A
!     ;; similar timeout seems to be needed in the
!     ;; GFam{File,Directory}Monitor case.
!     ((memq (file-notify--test-monitor)
!            '(GFamFileMonitor GFamDirectoryMonitor GPollFileMonitor))
       7)
      ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
      ((file-remote-p temporary-file-directory) 0.1)
***************
*** 263,274 ****
    ;; `gfile-monitor-name' does not return a proper result anymore.
    ;; But we still need this information.
    (unless (file-remote-p temporary-file-directory)
!     (or (cdr (assq file-notify--test-desc file-notify--test-monitors))
          (when (functionp 'gfile-monitor-name)
            (add-to-list 'file-notify--test-monitors
                         (cons file-notify--test-desc
                               (gfile-monitor-name file-notify--test-desc)))
!           (cdr (assq file-notify--test-desc file-notify--test-monitors))))))

  (defmacro file-notify--deftest-remote (test docstring &optional unstable)
    "Define ert `TEST-remote' for remote files.
--- 262,273 ----
    ;; `gfile-monitor-name' does not return a proper result anymore.
    ;; But we still need this information.
    (unless (file-remote-p temporary-file-directory)
!     (or (alist-get file-notify--test-desc file-notify--test-monitors)
          (when (functionp 'gfile-monitor-name)
            (add-to-list 'file-notify--test-monitors
                         (cons file-notify--test-desc
                               (gfile-monitor-name file-notify--test-desc)))
!           (alist-get file-notify--test-desc file-notify--test-monitors)))))

  (defmacro file-notify--deftest-remote (test docstring &optional unstable)
    "Define ert `TEST-remote' for remote files.
***************
*** 455,461 ****

    (unwind-protect
        ;; Check, that removing watch descriptors out of order do not
!       ;; harm.  This fails on Cygwin because of timing issues unless a
        ;; long `sit-for' is added before the call to
        ;; `file-notify--test-read-event'.
        (unless (eq system-type 'cygwin)
--- 454,460 ----

    (unwind-protect
        ;; Check, that removing watch descriptors out of order do not
!       ;; harm.  This fails on cygwin because of timing issues unless a
        ;; long `sit-for' is added before the call to
        ;; `file-notify--test-read-event'.
        (unless (eq system-type 'cygwin)
***************
*** 542,547 ****
--- 541,550 ----
  	    file-notify--test-results
  	    (append file-notify--test-results `(,result))))))

+ (defun file-notify--test-event-actions ()
+   "Helper function to return retrieved actions, as list."
+   (mapcar #'file-notify--test-event-action file-notify--test-events))
+
  (defun file-notify--test-with-actions-check (actions)
    "Check whether received actions match one of the ACTIONS alternatives."
    (let (result)
***************
*** 550,571 ****
              (or result
                  (if (eq (car elt) :random)
                      (equal (sort (cdr elt) 'string-lessp)
!                            (sort (mapcar #'file-notify--test-event-action
!                                          file-notify--test-events)
                                   'string-lessp))
!                   (equal elt (mapcar #'file-notify--test-event-action
!                                      file-notify--test-events))))))))

  (defun file-notify--test-with-actions-explainer (actions)
    "Explain why `file-notify--test-with-actions-check' fails."
    (if (null (cdr actions))
        (format "Received actions do not match expected actions\n%s\n%s"
!               (mapcar #'file-notify--test-event-action file-notify--test-events)
!               (car actions))
      (format
       "Received actions do not match any sequence of expected actions\n%s\n%s"
!      (mapcar #'file-notify--test-event-action file-notify--test-events)
!      actions)))

  (put 'file-notify--test-with-actions-check 'ert-explainer
       'file-notify--test-with-actions-explainer)
--- 553,577 ----
              (or result
                  (if (eq (car elt) :random)
                      (equal (sort (cdr elt) 'string-lessp)
!                            (sort (file-notify--test-event-actions)
                                   'string-lessp))
!                   (equal elt (file-notify--test-event-actions))))))
!     ;; Do not report result in case we debug.  Write messages instead.
!     (if file-notify-debug
!         (prog1 t
!           (if result
!               (message "Success\n%s" (file-notify--test-event-actions))
!             (message (file-notify--test-with-actions-explainer actions))))
!       result)))

  (defun file-notify--test-with-actions-explainer (actions)
    "Explain why `file-notify--test-with-actions-check' fails."
    (if (null (cdr actions))
        (format "Received actions do not match expected actions\n%s\n%s"
!               (file-notify--test-event-actions) (car actions))
      (format
       "Received actions do not match any sequence of expected actions\n%s\n%s"
!      (file-notify--test-event-actions) actions)))

  (put 'file-notify--test-with-actions-check 'ert-explainer
       'file-notify--test-with-actions-explainer)
***************
*** 632,640 ****
  	       (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  	        (created deleted stopped)))
!              ;; cygwin does not raise a `changed' event.
!              ((eq system-type 'cygwin)
!               '(created deleted stopped))
               (t '(created changed deleted stopped)))
            (write-region
             "another text" nil file-notify--test-tmpfile nil 'no-message)
--- 638,647 ----
  	       (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  	        (created deleted stopped)))
! 	     ;; GFam{File,Directory}Monitor do not report the `changed' event.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
! 	      '(created deleted stopped))
               (t '(created changed deleted stopped)))
            (write-region
             "another text" nil file-notify--test-tmpfile nil 'no-message)
***************
*** 665,670 ****
--- 672,683 ----
  	     ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  		(changed deleted stopped)))
+ 	     ;; GFam{File,Directory}Monitor do not detect the
+              ;; `changed' event reliably.
+ 	     ((memq (file-notify--test-monitor)
+                     '(GFamFileMonitor GFamDirectoryMonitor))
+ 	      '((deleted stopped)
+ 		(changed deleted stopped)))
  	     ;; There could be one or two `changed' events.
  	     (t '((changed deleted stopped)
  		  (changed changed deleted stopped))))
***************
*** 709,717 ****
               ((getenv "EMACS_EMBA_CI")
                '(created changed deleted))
  	     ;; There are two `deleted' events, for the file and for
! 	     ;; the directory.  Except for cygwin and kqueue.  And
! 	     ;; cygwin does not raise a `changed' event.
! 	     ((eq system-type 'cygwin)
  	      '(created deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed deleted stopped))
--- 722,732 ----
               ((getenv "EMACS_EMBA_CI")
                '(created changed deleted))
  	     ;; There are two `deleted' events, for the file and for
! 	     ;; the directory.  Except for GFam{File,Directory}Monitor
! 	     ;; and kqueue.  And GFam{File,Directory}Monitor do not
! 	     ;; raise a `changed' event.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
  	      '(created deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed deleted stopped))
***************
*** 755,762 ****
  	      '((deleted stopped)
  		(created created deleted stopped)))
  	     ;; There are three `deleted' events, for two files and
! 	     ;; for the directory.  Except for cygwin and kqueue.
! 	     ((eq system-type 'cygwin)
  	      '(created created changed changed deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed created changed deleted stopped))
--- 770,779 ----
  	      '((deleted stopped)
  		(created created deleted stopped)))
  	     ;; There are three `deleted' events, for two files and
! 	     ;; for the directory.  Except for
! 	     ;; GFam{File,Directory}Monitor and kqueue.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
  	      '(created created changed changed deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed created changed deleted stopped))
***************
*** 813,822 ****
               ((getenv "EMACS_EMBA_CI")
                '(created changed renamed deleted))
  	     ;; There are two `deleted' events, for the file and for
! 	     ;; the directory.  Except for cygwin and kqueue.  And
! 	     ;; cygwin raises `created' and `deleted' events instead
! 	     ;; of a `renamed' event.
! 	     ((eq system-type 'cygwin)
  	      '(created created deleted deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed renamed deleted stopped))
--- 830,841 ----
               ((getenv "EMACS_EMBA_CI")
                '(created changed renamed deleted))
  	     ;; There are two `deleted' events, for the file and for
! 	     ;; the directory.  Except for GFam{File,Directory}Monitor
! 	     ;; and kqueue.  And GFam{File,Directory}Monitor raise
! 	     ;; `created' and `deleted' events instead of a `renamed'
! 	     ;; event.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
  	      '(created created deleted deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed renamed deleted stopped))
***************
*** 837,844 ****
      (file-notify--test-cleanup))

    (unwind-protect
!       ;; Check attribute change.  Does not work for cygwin.
!       (unless (eq system-type 'cygwin)
  	(setq file-notify--test-tmpfile (file-notify--test-make-temp-name))
  	(write-region
  	 "any text" nil file-notify--test-tmpfile nil 'no-message)
--- 856,863 ----
      (file-notify--test-cleanup))

    (unwind-protect
!       ;; Check attribute change.  Does not work for GFam{File,Directory}Monitor.
!       (progn
  	(setq file-notify--test-tmpfile (file-notify--test-make-temp-name))
  	(write-region
  	 "any text" nil file-notify--test-tmpfile nil 'no-message)
***************
*** 847,875 ****
  	       (file-notify--test-add-watch
  		file-notify--test-tmpfile
  		'(attribute-change) #'file-notify--test-event-handler)))
! 	(file-notify--test-with-actions
! 	    (cond
! 	     ;; w32notify does not distinguish between `changed' and
! 	     ;; `attribute-changed'.  Under MS Windows 7, we get four
! 	     ;; `changed' events, and under MS Windows 10 just two.
! 	     ;; Strange.
! 	     ((string-equal (file-notify--test-library) "w32notify")
! 	      '((changed changed)
! 		(changed changed changed changed)))
! 	     ;; For kqueue and in the remote case, `write-region'
! 	     ;; raises also an `attribute-changed' event.
! 	     ((or (string-equal (file-notify--test-library) "kqueue")
! 		  (file-remote-p temporary-file-directory))
! 	      '(attribute-changed attribute-changed attribute-changed))
! 	     (t '(attribute-changed attribute-changed)))
! 	  (write-region
! 	   "any text" nil file-notify--test-tmpfile nil 'no-message)
! 	  (file-notify--test-read-event)
! 	  (set-file-modes file-notify--test-tmpfile 000)
! 	  (file-notify--test-read-event)
! 	  (set-file-times file-notify--test-tmpfile '(0 0))
! 	  (file-notify--test-read-event)
! 	  (delete-file file-notify--test-tmpfile))
          (file-notify-rm-watch file-notify--test-desc)

          ;; The environment shall be cleaned up.
--- 866,896 ----
  	       (file-notify--test-add-watch
  		file-notify--test-tmpfile
  		'(attribute-change) #'file-notify--test-event-handler)))
! 	(unless (memq (file-notify--test-monitor)
!                       '(GFamFileMonitor GFamDirectoryMonitor))
! 	  (file-notify--test-with-actions
! 	      (cond
! 	       ;; w32notify does not distinguish between `changed' and
! 	       ;; `attribute-changed'.  Under MS Windows 7, we get
! 	       ;; four `changed' events, and under MS Windows 10 just
! 	       ;; two.  Strange.
! 	       ((string-equal (file-notify--test-library) "w32notify")
! 		'((changed changed)
! 		  (changed changed changed changed)))
! 	       ;; For kqueue and in the remote case, `write-region'
! 	       ;; raises also an `attribute-changed' event.
! 	       ((or (string-equal (file-notify--test-library) "kqueue")
! 		    (file-remote-p temporary-file-directory))
! 		'(attribute-changed attribute-changed attribute-changed))
! 	       (t '(attribute-changed attribute-changed)))
! 	    (write-region
! 	     "any text" nil file-notify--test-tmpfile nil 'no-message)
! 	    (file-notify--test-read-event)
! 	    (set-file-modes file-notify--test-tmpfile 000)
! 	    (file-notify--test-read-event)
! 	    (set-file-times file-notify--test-tmpfile '(0 0))
! 	    (file-notify--test-read-event)
! 	    (delete-file file-notify--test-tmpfile)))
          (file-notify-rm-watch file-notify--test-desc)

          ;; The environment shall be cleaned up.
***************
*** 951,957 ****

  	    ;; Modify file.  We wait for two seconds, in order to
  	    ;; have another timestamp.  One second seems to be too
!             ;; short.  And Cygwin sporadically requires more than two.
              (ert-with-message-capture captured-messages
                (sleep-for (if (eq system-type 'cygwin) 3 2))
                (write-region
--- 972,978 ----

  	    ;; Modify file.  We wait for two seconds, in order to
  	    ;; have another timestamp.  One second seems to be too
!             ;; short.  And cygwin sporadically requires more than two.
              (ert-with-message-capture captured-messages
                (sleep-for (if (eq system-type 'cygwin) 3 2))
                (write-region
***************
*** 1021,1026 ****
--- 1042,1053 ----
  	     ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  		(changed deleted stopped)))
+ 	     ;; GFam{File,Directory}Monitor do not detect the
+              ;; `changed' event reliably.
+ 	     ((memq (file-notify--test-monitor)
+                     '(GFamFileMonitor GFamDirectoryMonitor))
+ 	      '((deleted stopped)
+ 	        (changed deleted stopped)))
  	     ;; There could be one or two `changed' events.
  	     (t '((changed deleted stopped)
  		  (changed changed deleted stopped))))
***************
*** 1064,1072 ****
  	        '((deleted stopped)
  	          (created deleted stopped)))
  	       ;; There are two `deleted' events, for the file and for
! 	       ;; the directory.  Except for cygwin and kqueue.  And
! 	       ;; cygwin does not raise a `changed' event.
! 	       ((eq system-type 'cygwin)
  	        '(created deleted stopped))
  	       ((string-equal (file-notify--test-library) "kqueue")
  	        '(created changed deleted stopped))
--- 1091,1102 ----
  	        '((deleted stopped)
  	          (created deleted stopped)))
  	       ;; There are two `deleted' events, for the file and for
! 	       ;; the directory.  Except for
! 	       ;; GFam{File,Directory}Monitor and kqueue.  And
! 	       ;; GFam{File,Directory}Monitor do not raise a `changed'
! 	       ;; event.
! 	       ((memq (file-notify--test-monitor)
!                       '(GFamFileMonitor GFamDirectoryMonitor))
  	        '(created deleted stopped))
  	       ((string-equal (file-notify--test-library) "kqueue")
  	        '(created changed deleted stopped))
***************
*** 1169,1175 ****
  	  file-notify--test-tmpfile
  	  '(change) #'file-notify--test-event-handler)))
    (unwind-protect
!       (let ((n 1000)
              source-file-list target-file-list
              (default-directory file-notify--test-tmpfile))
          (dotimes (i n)
--- 1199,1205 ----
  	  file-notify--test-tmpfile
  	  '(change) #'file-notify--test-event-handler)))
    (unwind-protect
!       (let ((n 10);00)
              source-file-list target-file-list
              (default-directory file-notify--test-tmpfile))
          (dotimes (i n)
***************
*** 1283,1291 ****
          (should (file-notify-valid-p file-notify--test-desc))
          (file-notify--test-with-actions
              (cond
!              ;; On cygwin we only get the `changed' event.
!              ((eq system-type 'cygwin)
!               '(changed))
               (t '(renamed created changed)))
            ;; The file is renamed when creating a backup.  It shall
            ;; still be watched.
--- 1313,1322 ----
          (should (file-notify-valid-p file-notify--test-desc))
          (file-notify--test-with-actions
              (cond
! 	     ;; GFam{File,Directory}Monitor report only the `changed' event.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
! 	      '(changed))
               (t '(renamed created changed)))
            ;; The file is renamed when creating a backup.  It shall
            ;; still be watched.
***************
*** 1355,1361 ****
          (should (file-notify-valid-p file-notify--test-desc1))
          (should (file-notify-valid-p file-notify--test-desc2))
          (should-not (equal file-notify--test-desc1 file-notify--test-desc2))
!         (let ((n 100))
            ;; Run the test.
            (file-notify--test-with-actions
                ;; There could be one or two `changed' events.
--- 1386,1392 ----
          (should (file-notify-valid-p file-notify--test-desc1))
          (should (file-notify-valid-p file-notify--test-desc2))
          (should-not (equal file-notify--test-desc1 file-notify--test-desc2))
!         (let ((n 10));0))
            ;; Run the test.
            (file-notify--test-with-actions
                ;; There could be one or two `changed' events.

bug#47262: [platform-testers] Emacs 27.2 RC2

[Dagobert Michelsen]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

Hi Michael,

Am 22.03.2021 um 15:47 schrieb Michael Albinus <michael.albinus@gmx.de>:
> Oops, yes. file-notify-test07-many-events and
> file-notify-test09-watched-file-in-watched-dir run large loops. I've
> reduced the number of iterations in both tests, see appended patch. It
> contains also some other changes I have applied last days, testing on cygwin.

Please find the logfiles for the latest patch attached. This looks good,
now all tests pass :-)


[-- Attachment #2: filenotify-tests.log --]
[-- Type: application/octet-stream, Size: 828 bytes --]

Running 8 tests (2021-03-22 17:48:46+0100, selector `(not (or (tag :expensive-test) (tag :unstable)))')
Library: `gfilenotify'
Monitor: `GFamDirectoryMonitor'
   passed  1/8  file-notify-test00-availability (0.102576 sec)
   passed  2/8  file-notify-test01-add-watch (0.014409 sec)
   passed  3/8  file-notify-test02-rm-watch (1.007739 sec)
   passed  4/8  file-notify-test03-events (113.057275 sec)
Reverting buffer `file-notify-testN00ey6'.
Reverting buffer `file-notify-testN00ey6'.
   passed  5/8  file-notify-test04-autorevert (18.041154 sec)
   passed  6/8  file-notify-test05-file-validity (34.025455 sec)
   passed  7/8  file-notify-test06-dir-validity (3.011377 sec)
   passed  8/8  file-notify-test08-backup (26.050180 sec)

Ran 8 tests, 8 results as expected, 0 unexpected (2021-03-22 17:52:02+0100, 195.320520 sec)


[-- Attachment #3: Type: text/plain, Size: 214 bytes --]




Best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

bug#47262: [platform-testers] Emacs 27.2 RC2

[Michael Albinus]

Dagobert Michelsen <dam@opencsw.org> writes:

> Hi Michael,

Hi Dago,

> Please find the logfiles for the latest patch attached. This looks good,
> now all tests pass :-)

Thanks a lot! This is good progress.

> Running 8 tests (2021-03-22 17:48:46+0100, selector `(not (or (tag :expensive-test) (tag :unstable)))')

These are the not expensive tests. Do you see a chance to run

# make -C test filenotify-tests.log SELECTOR='(not "remote")'

? This runs all local tests, expensive ones included, but avoids the
remote tests (which might be problematic). And in case there are errors
with the expensive tests, could you rerun this with file-notify-debug
set to t in the test file?

> Best regards
>
>   — Dago

Thanks, and best regards, Michael.

bug#47262: [platform-testers] Emacs 27.2 RC2

[Dagobert Michelsen]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

Hi Michael,

Am 23.03.2021 um 09:17 schrieb Michael Albinus <michael.albinus@gmx.de>:
> These are the not expensive tests.

Ahh sorry, I tend to forget to execute this.

> Do you see a chance to run
> 
> # make -C test filenotify-tests.log SELECTOR='(not "remote")'
> 
> ? This runs all local tests, expensive ones included, but avoids the
> remote tests (which might be problematic). And in case there are errors
> with the expensive tests, could you rerun this with file-notify-debug
> set to t in the test file?

Please find the new log attached.


[-- Attachment #2: filenotify-tests.log --]
[-- Type: application/octet-stream, Size: 4953 bytes --]

Running 11 tests (2021-03-23 09:25:41+0100, selector `(not "remote")')
Library: `gfilenotify'
Monitor: `GFamDirectoryMonitor'
   passed   1/11  file-notify-test00-availability (0.314023 sec)
   passed   2/11  file-notify-test01-add-watch (0.015639 sec)
   passed   3/11  file-notify-test02-rm-watch (1.115934 sec)
   passed   4/11  file-notify-test03-events (113.061687 sec)
Reverting buffer `file-notify-test0ZX8Re'.
Reverting buffer `file-notify-test0ZX8Re'.
   passed   5/11  file-notify-test04-autorevert (18.041596 sec)
   passed   6/11  file-notify-test05-file-validity (34.026242 sec)
   passed   7/11  file-notify-test06-dir-validity (3.011524 sec)
Test file-notify-test07-many-events backtrace:
  signal(ert-test-failed (((should (file-notify--test-with-actions-che
  ert-fail(((should (file-notify--test-with-actions-check actions)) :f
  (if (unwind-protect (setq value-338 (apply fn-336 args-337)) (setq f
  (let (form-description-340) (if (unwind-protect (setq value-338 (app
  (let ((value-338 'ert-form-evaluation-aborted-339)) (let (form-descr
  (let* ((fn-336 #'file-notify--test-with-actions-check) (args-337 (co
  (let* ((actions (if (consp (car (cond (... ...) (... ...) (t ...))))
  (let ((n 10) source-file-list target-file-list (default-directory fi
  (unwind-protect (let ((n 10) source-file-list target-file-list (defa
  (closure (t) nil (let* ((fn-322 #'file-notify--test-local-enabled) (
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name file-notify-test07-many-events :docum
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not "remote") #f(compiled-function (event-type &rest 
  ert-run-tests-batch((not "remote"))
  ert-run-tests-batch-and-exit((not "remote"))
  eval((ert-run-tests-batch-and-exit '(not "remote")) t)
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/filenotify-tests.el"
  command-line()
  normal-top-level()
Test file-notify-test07-many-events condition:
    (ert-test-failed
     ((should
       (file-notify--test-with-actions-check actions))
      :form
      (file-notify--test-with-actions-check
       ((renamed renamed renamed renamed renamed renamed renamed renamed renamed renamed)))
      :value nil :explanation "Received actions do not match expected actions
(changed deleted changed deleted changed deleted changed deleted changed deleted changed deleted changed deleted changed deleted changed deleted changed deleted)
(renamed renamed renamed renamed renamed renamed renamed renamed renamed renamed)"))
   FAILED   8/11  file-notify-test07-many-events (230.052797 sec)
   passed   9/11  file-notify-test08-backup (26.051370 sec)
Test file-notify-test09-watched-file-in-watched-dir backtrace:
  signal(ert-test-failed (((should (file-notify--test-with-actions-che
  ert-fail(((should (file-notify--test-with-actions-check actions)) :f
  (if (unwind-protect (setq value-445 (apply fn-443 args-444)) (setq f
  (let (form-description-447) (if (unwind-protect (setq value-445 (app
  (let ((value-445 'ert-form-evaluation-aborted-446)) (let (form-descr
  (let* ((fn-443 #'file-notify--test-with-actions-check) (args-444 (co
  (let* ((actions (if (consp (car (cond (... ...) (t ...)))) (cond ((o
  (progn (let ((value-404 (gensym "ert-form-evaluation-aborted-"))) (l
  (let* ((--cl-dir-callback-- #'(lambda (event file) (let (...) (file-
  (unwind-protect (let* ((--cl-dir-callback-- #'(lambda (event file) (
  (closure (t) nil (let* ((fn-395 #'file-notify--test-local-enabled) (
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name file-notify-test09-watched-file-in-wa
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not "remote") #f(compiled-function (event-type &rest 
  ert-run-tests-batch((not "remote"))
  ert-run-tests-batch-and-exit((not "remote"))
  eval((ert-run-tests-batch-and-exit '(not "remote")) t)
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/filenotify-tests.el"
  command-line()
  normal-top-level()
Test file-notify-test09-watched-file-in-watched-dir condition:
    (ert-test-failed
     ((should
       (file-notify--test-with-actions-check actions))
      :form
      (file-notify--test-with-actions-check
       ((deleted deleted deleted deleted deleted deleted stopped)))
      :value nil :explanation "Received actions do not match expected actions
(deleted stopped)
(deleted deleted deleted deleted deleted deleted stopped)"))
   FAILED  10/11  file-notify-test09-watched-file-in-watched-dir (100.035757 sec)
  skipped  11/11  file-notify-test10-sufficient-resources (0.001596 sec)

Ran 11 tests, 8 results as expected, 2 unexpected, 1 skipped (2021-03-23 09:34:34+0100, 533.237428 sec)

2 unexpected results:
   FAILED  file-notify-test07-many-events
   FAILED  file-notify-test09-watched-file-in-watched-dir

1 skipped results:
  SKIPPED  file-notify-test10-sufficient-resources


[-- Attachment #3: Type: text/plain, Size: 214 bytes --]




Best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

bug#47262: [platform-testers] Emacs 27.2 RC2

[Michael Albinus]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Dagobert Michelsen <dam@opencsw.org> writes:

> Hi Michael,

Hi Dago,

> Please find the new log attached.

Thanks! Appended the next patch iteration. And I'm quite optimistic that
it is the last one :-)

Could you pls check? As a reminder, pls call

# make -C test filenotify-tests.log SELECTOR='(not "remote")'

> Best regards
>
>   — Dago

Thanks, and best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 21426 bytes --]

*** /tmp/ediffpkAKG4	2021-03-23 10:28:18.611288593 +0100
--- /usr/local/src/emacs-27/test/lisp/filenotify-tests.el	2021-03-23 10:10:45.362714979 +0100
***************
*** 105,115 ****
     (cond
      ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5.  So we must
      ;; wait at least this time in the GPollFileMonitor case.  A
!     ;; similar timeout seems to be needed in the GFamFileMonitor case,
!     ;; at least on Cygwin.
!     ((and (string-equal (file-notify--test-library) "gfilenotify")
!           (memq (file-notify--test-monitor)
!                 '(GFamFileMonitor GPollFileMonitor)))
       7)
      ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
      ((file-remote-p temporary-file-directory) 0.1)
--- 105,114 ----
     (cond
      ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5.  So we must
      ;; wait at least this time in the GPollFileMonitor case.  A
!     ;; similar timeout seems to be needed in the
!     ;; GFam{File,Directory}Monitor case.
!     ((memq (file-notify--test-monitor)
!            '(GFamFileMonitor GFamDirectoryMonitor GPollFileMonitor))
       7)
      ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
      ((file-remote-p temporary-file-directory) 0.1)
***************
*** 263,274 ****
    ;; `gfile-monitor-name' does not return a proper result anymore.
    ;; But we still need this information.
    (unless (file-remote-p temporary-file-directory)
!     (or (cdr (assq file-notify--test-desc file-notify--test-monitors))
          (when (functionp 'gfile-monitor-name)
            (add-to-list 'file-notify--test-monitors
                         (cons file-notify--test-desc
                               (gfile-monitor-name file-notify--test-desc)))
!           (cdr (assq file-notify--test-desc file-notify--test-monitors))))))

  (defmacro file-notify--deftest-remote (test docstring &optional unstable)
    "Define ert `TEST-remote' for remote files.
--- 262,273 ----
    ;; `gfile-monitor-name' does not return a proper result anymore.
    ;; But we still need this information.
    (unless (file-remote-p temporary-file-directory)
!     (or (alist-get file-notify--test-desc file-notify--test-monitors)
          (when (functionp 'gfile-monitor-name)
            (add-to-list 'file-notify--test-monitors
                         (cons file-notify--test-desc
                               (gfile-monitor-name file-notify--test-desc)))
!           (alist-get file-notify--test-desc file-notify--test-monitors)))))

  (defmacro file-notify--deftest-remote (test docstring &optional unstable)
    "Define ert `TEST-remote' for remote files.
***************
*** 455,461 ****

    (unwind-protect
        ;; Check, that removing watch descriptors out of order do not
!       ;; harm.  This fails on Cygwin because of timing issues unless a
        ;; long `sit-for' is added before the call to
        ;; `file-notify--test-read-event'.
        (unless (eq system-type 'cygwin)
--- 454,460 ----

    (unwind-protect
        ;; Check, that removing watch descriptors out of order do not
!       ;; harm.  This fails on cygwin because of timing issues unless a
        ;; long `sit-for' is added before the call to
        ;; `file-notify--test-read-event'.
        (unless (eq system-type 'cygwin)
***************
*** 542,547 ****
--- 541,550 ----
  	    file-notify--test-results
  	    (append file-notify--test-results `(,result))))))

+ (defun file-notify--test-event-actions ()
+   "Helper function to return retrieved actions, as list."
+   (mapcar #'file-notify--test-event-action file-notify--test-events))
+
  (defun file-notify--test-with-actions-check (actions)
    "Check whether received actions match one of the ACTIONS alternatives."
    (let (result)
***************
*** 550,571 ****
              (or result
                  (if (eq (car elt) :random)
                      (equal (sort (cdr elt) 'string-lessp)
!                            (sort (mapcar #'file-notify--test-event-action
!                                          file-notify--test-events)
                                   'string-lessp))
!                   (equal elt (mapcar #'file-notify--test-event-action
!                                      file-notify--test-events))))))))

  (defun file-notify--test-with-actions-explainer (actions)
    "Explain why `file-notify--test-with-actions-check' fails."
    (if (null (cdr actions))
        (format "Received actions do not match expected actions\n%s\n%s"
!               (mapcar #'file-notify--test-event-action file-notify--test-events)
!               (car actions))
      (format
       "Received actions do not match any sequence of expected actions\n%s\n%s"
!      (mapcar #'file-notify--test-event-action file-notify--test-events)
!      actions)))

  (put 'file-notify--test-with-actions-check 'ert-explainer
       'file-notify--test-with-actions-explainer)
--- 553,577 ----
              (or result
                  (if (eq (car elt) :random)
                      (equal (sort (cdr elt) 'string-lessp)
!                            (sort (file-notify--test-event-actions)
                                   'string-lessp))
!                   (equal elt (file-notify--test-event-actions))))))
!     ;; Do not report result in case we debug.  Write messages instead.
!     (if file-notify-debug
!         (prog1 t
!           (if result
!               (message "Success\n%s" (file-notify--test-event-actions))
!             (message (file-notify--test-with-actions-explainer actions))))
!       result)))

  (defun file-notify--test-with-actions-explainer (actions)
    "Explain why `file-notify--test-with-actions-check' fails."
    (if (null (cdr actions))
        (format "Received actions do not match expected actions\n%s\n%s"
!               (file-notify--test-event-actions) (car actions))
      (format
       "Received actions do not match any sequence of expected actions\n%s\n%s"
!      (file-notify--test-event-actions) actions)))

  (put 'file-notify--test-with-actions-check 'ert-explainer
       'file-notify--test-with-actions-explainer)
***************
*** 632,640 ****
  	       (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  	        (created deleted stopped)))
!              ;; cygwin does not raise a `changed' event.
!              ((eq system-type 'cygwin)
!               '(created deleted stopped))
               (t '(created changed deleted stopped)))
            (write-region
             "another text" nil file-notify--test-tmpfile nil 'no-message)
--- 638,647 ----
  	       (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  	        (created deleted stopped)))
! 	     ;; GFam{File,Directory}Monitor do not report the `changed' event.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
! 	      '(created deleted stopped))
               (t '(created changed deleted stopped)))
            (write-region
             "another text" nil file-notify--test-tmpfile nil 'no-message)
***************
*** 665,670 ****
--- 672,683 ----
  	     ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  		(changed deleted stopped)))
+ 	     ;; GFam{File,Directory}Monitor do not detect the
+              ;; `changed' event reliably.
+ 	     ((memq (file-notify--test-monitor)
+                     '(GFamFileMonitor GFamDirectoryMonitor))
+ 	      '((deleted stopped)
+ 		(changed deleted stopped)))
  	     ;; There could be one or two `changed' events.
  	     (t '((changed deleted stopped)
  		  (changed changed deleted stopped))))
***************
*** 709,717 ****
               ((getenv "EMACS_EMBA_CI")
                '(created changed deleted))
  	     ;; There are two `deleted' events, for the file and for
! 	     ;; the directory.  Except for cygwin and kqueue.  And
! 	     ;; cygwin does not raise a `changed' event.
! 	     ((eq system-type 'cygwin)
  	      '(created deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed deleted stopped))
--- 722,732 ----
               ((getenv "EMACS_EMBA_CI")
                '(created changed deleted))
  	     ;; There are two `deleted' events, for the file and for
! 	     ;; the directory.  Except for GFam{File,Directory}Monitor
! 	     ;; and kqueue.  And GFam{File,Directory}Monitor do not
! 	     ;; raise a `changed' event.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
  	      '(created deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed deleted stopped))
***************
*** 755,762 ****
  	      '((deleted stopped)
  		(created created deleted stopped)))
  	     ;; There are three `deleted' events, for two files and
! 	     ;; for the directory.  Except for cygwin and kqueue.
! 	     ((eq system-type 'cygwin)
  	      '(created created changed changed deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed created changed deleted stopped))
--- 770,779 ----
  	      '((deleted stopped)
  		(created created deleted stopped)))
  	     ;; There are three `deleted' events, for two files and
! 	     ;; for the directory.  Except for
! 	     ;; GFam{File,Directory}Monitor and kqueue.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
  	      '(created created changed changed deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed created changed deleted stopped))
***************
*** 813,822 ****
               ((getenv "EMACS_EMBA_CI")
                '(created changed renamed deleted))
  	     ;; There are two `deleted' events, for the file and for
! 	     ;; the directory.  Except for cygwin and kqueue.  And
! 	     ;; cygwin raises `created' and `deleted' events instead
! 	     ;; of a `renamed' event.
! 	     ((eq system-type 'cygwin)
  	      '(created created deleted deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed renamed deleted stopped))
--- 830,841 ----
               ((getenv "EMACS_EMBA_CI")
                '(created changed renamed deleted))
  	     ;; There are two `deleted' events, for the file and for
! 	     ;; the directory.  Except for GFam{File,Directory}Monitor
! 	     ;; and kqueue.  And GFam{File,Directory}Monitor raise
! 	     ;; `created' and `deleted' events instead of a `renamed'
! 	     ;; event.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
  	      '(created created deleted deleted stopped))
  	     ((string-equal (file-notify--test-library) "kqueue")
  	      '(created changed renamed deleted stopped))
***************
*** 837,844 ****
      (file-notify--test-cleanup))

    (unwind-protect
!       ;; Check attribute change.  Does not work for cygwin.
!       (unless (eq system-type 'cygwin)
  	(setq file-notify--test-tmpfile (file-notify--test-make-temp-name))
  	(write-region
  	 "any text" nil file-notify--test-tmpfile nil 'no-message)
--- 856,863 ----
      (file-notify--test-cleanup))

    (unwind-protect
!       ;; Check attribute change.  Does not work for GFam{File,Directory}Monitor.
!       (progn
  	(setq file-notify--test-tmpfile (file-notify--test-make-temp-name))
  	(write-region
  	 "any text" nil file-notify--test-tmpfile nil 'no-message)
***************
*** 847,875 ****
  	       (file-notify--test-add-watch
  		file-notify--test-tmpfile
  		'(attribute-change) #'file-notify--test-event-handler)))
! 	(file-notify--test-with-actions
! 	    (cond
! 	     ;; w32notify does not distinguish between `changed' and
! 	     ;; `attribute-changed'.  Under MS Windows 7, we get four
! 	     ;; `changed' events, and under MS Windows 10 just two.
! 	     ;; Strange.
! 	     ((string-equal (file-notify--test-library) "w32notify")
! 	      '((changed changed)
! 		(changed changed changed changed)))
! 	     ;; For kqueue and in the remote case, `write-region'
! 	     ;; raises also an `attribute-changed' event.
! 	     ((or (string-equal (file-notify--test-library) "kqueue")
! 		  (file-remote-p temporary-file-directory))
! 	      '(attribute-changed attribute-changed attribute-changed))
! 	     (t '(attribute-changed attribute-changed)))
! 	  (write-region
! 	   "any text" nil file-notify--test-tmpfile nil 'no-message)
! 	  (file-notify--test-read-event)
! 	  (set-file-modes file-notify--test-tmpfile 000)
! 	  (file-notify--test-read-event)
! 	  (set-file-times file-notify--test-tmpfile '(0 0))
! 	  (file-notify--test-read-event)
! 	  (delete-file file-notify--test-tmpfile))
          (file-notify-rm-watch file-notify--test-desc)

          ;; The environment shall be cleaned up.
--- 866,896 ----
  	       (file-notify--test-add-watch
  		file-notify--test-tmpfile
  		'(attribute-change) #'file-notify--test-event-handler)))
! 	(unless (memq (file-notify--test-monitor)
!                       '(GFamFileMonitor GFamDirectoryMonitor))
! 	  (file-notify--test-with-actions
! 	      (cond
! 	       ;; w32notify does not distinguish between `changed' and
! 	       ;; `attribute-changed'.  Under MS Windows 7, we get
! 	       ;; four `changed' events, and under MS Windows 10 just
! 	       ;; two.  Strange.
! 	       ((string-equal (file-notify--test-library) "w32notify")
! 		'((changed changed)
! 		  (changed changed changed changed)))
! 	       ;; For kqueue and in the remote case, `write-region'
! 	       ;; raises also an `attribute-changed' event.
! 	       ((or (string-equal (file-notify--test-library) "kqueue")
! 		    (file-remote-p temporary-file-directory))
! 		'(attribute-changed attribute-changed attribute-changed))
! 	       (t '(attribute-changed attribute-changed)))
! 	    (write-region
! 	     "any text" nil file-notify--test-tmpfile nil 'no-message)
! 	    (file-notify--test-read-event)
! 	    (set-file-modes file-notify--test-tmpfile 000)
! 	    (file-notify--test-read-event)
! 	    (set-file-times file-notify--test-tmpfile '(0 0))
! 	    (file-notify--test-read-event)
! 	    (delete-file file-notify--test-tmpfile)))
          (file-notify-rm-watch file-notify--test-desc)

          ;; The environment shall be cleaned up.
***************
*** 951,957 ****

  	    ;; Modify file.  We wait for two seconds, in order to
  	    ;; have another timestamp.  One second seems to be too
!             ;; short.  And Cygwin sporadically requires more than two.
              (ert-with-message-capture captured-messages
                (sleep-for (if (eq system-type 'cygwin) 3 2))
                (write-region
--- 972,978 ----

  	    ;; Modify file.  We wait for two seconds, in order to
  	    ;; have another timestamp.  One second seems to be too
!             ;; short.  And cygwin sporadically requires more than two.
              (ert-with-message-capture captured-messages
                (sleep-for (if (eq system-type 'cygwin) 3 2))
                (write-region
***************
*** 1021,1026 ****
--- 1042,1053 ----
  	     ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe")
  	      '((deleted stopped)
  		(changed deleted stopped)))
+ 	     ;; GFam{File,Directory}Monitor do not detect the
+              ;; `changed' event reliably.
+ 	     ((memq (file-notify--test-monitor)
+                     '(GFamFileMonitor GFamDirectoryMonitor))
+ 	      '((deleted stopped)
+ 	        (changed deleted stopped)))
  	     ;; There could be one or two `changed' events.
  	     (t '((changed deleted stopped)
  		  (changed changed deleted stopped))))
***************
*** 1064,1072 ****
  	        '((deleted stopped)
  	          (created deleted stopped)))
  	       ;; There are two `deleted' events, for the file and for
! 	       ;; the directory.  Except for cygwin and kqueue.  And
! 	       ;; cygwin does not raise a `changed' event.
! 	       ((eq system-type 'cygwin)
  	        '(created deleted stopped))
  	       ((string-equal (file-notify--test-library) "kqueue")
  	        '(created changed deleted stopped))
--- 1091,1102 ----
  	        '((deleted stopped)
  	          (created deleted stopped)))
  	       ;; There are two `deleted' events, for the file and for
! 	       ;; the directory.  Except for
! 	       ;; GFam{File,Directory}Monitor and kqueue.  And
! 	       ;; GFam{File,Directory}Monitor do not raise a `changed'
! 	       ;; event.
! 	       ((memq (file-notify--test-monitor)
!                       '(GFamFileMonitor GFamDirectoryMonitor))
  	        '(created deleted stopped))
  	       ((string-equal (file-notify--test-library) "kqueue")
  	        '(created changed deleted stopped))
***************
*** 1169,1175 ****
  	  file-notify--test-tmpfile
  	  '(change) #'file-notify--test-event-handler)))
    (unwind-protect
!       (let ((n 1000)
              source-file-list target-file-list
              (default-directory file-notify--test-tmpfile))
          (dotimes (i n)
--- 1199,1205 ----
  	  file-notify--test-tmpfile
  	  '(change) #'file-notify--test-event-handler)))
    (unwind-protect
!       (let ((n 10);00)
              source-file-list target-file-list
              (default-directory file-notify--test-tmpfile))
          (dotimes (i n)
***************
*** 1198,1206 ****
  		(dotimes (_i n)
  		  (setq r (append '(deleted renamed) r)))
  		r))
! 	     ;; cygwin fires `changed' and `deleted' events, sometimes
! 	     ;; in random order.
! 	     ((eq system-type 'cygwin)
  	      (let (r)
  		(dotimes (_i n)
  		  (setq r (append '(changed deleted) r)))
--- 1228,1237 ----
  		(dotimes (_i n)
  		  (setq r (append '(deleted renamed) r)))
  		r))
! 	     ;; GFam{File,Directory}Monitor fire `changed' and
! 	     ;; `deleted' events, sometimes in random order.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
  	      (let (r)
  		(dotimes (_i n)
  		  (setq r (append '(changed deleted) r)))
***************
*** 1283,1291 ****
          (should (file-notify-valid-p file-notify--test-desc))
          (file-notify--test-with-actions
              (cond
!              ;; On cygwin we only get the `changed' event.
!              ((eq system-type 'cygwin)
!               '(changed))
               (t '(renamed created changed)))
            ;; The file is renamed when creating a backup.  It shall
            ;; still be watched.
--- 1314,1323 ----
          (should (file-notify-valid-p file-notify--test-desc))
          (file-notify--test-with-actions
              (cond
! 	     ;; GFam{File,Directory}Monitor report only the `changed' event.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
! 	      '(changed))
               (t '(renamed created changed)))
            ;; The file is renamed when creating a backup.  It shall
            ;; still be watched.
***************
*** 1355,1361 ****
          (should (file-notify-valid-p file-notify--test-desc1))
          (should (file-notify-valid-p file-notify--test-desc2))
          (should-not (equal file-notify--test-desc1 file-notify--test-desc2))
!         (let ((n 100))
            ;; Run the test.
            (file-notify--test-with-actions
                ;; There could be one or two `changed' events.
--- 1387,1393 ----
          (should (file-notify-valid-p file-notify--test-desc1))
          (should (file-notify-valid-p file-notify--test-desc2))
          (should-not (equal file-notify--test-desc1 file-notify--test-desc2))
!         (let ((n 10));0))
            ;; Run the test.
            (file-notify--test-with-actions
                ;; There could be one or two `changed' events.
***************
*** 1407,1416 ****
          ;; Now we delete the directory.
          (file-notify--test-with-actions
              (cond
!              ;; In kqueue and for cygwin, just one `deleted' event for
!              ;; the directory is received.
!              ((or (eq system-type 'cygwin)
! 		  (string-equal (file-notify--test-library) "kqueue"))
                '(deleted stopped))
               (t (append
                   ;; The directory monitor raises a `deleted' event for
--- 1439,1450 ----
          ;; Now we delete the directory.
          (file-notify--test-with-actions
              (cond
!              ;; GFam{File,Directory}Monitor and kqueue raise just one
!              ;; `deleted' event for the directory.
! 	     ((memq (file-notify--test-monitor)
!                     '(GFamFileMonitor GFamDirectoryMonitor))
!               '(deleted stopped))
! 	     ((string-equal (file-notify--test-library) "kqueue")
                '(deleted stopped))
               (t (append
                   ;; The directory monitor raises a `deleted' event for

bug#47262: [platform-testers] Emacs 27.2 RC2

[Dagobert Michelsen]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

Hi Michael,

Am 23.03.2021 um 10:32 schrieb Michael Albinus <michael.albinus@gmx.de>:
> Thanks! Appended the next patch iteration. And I'm quite optimistic that
> it is the last one :-)
> 
> Could you pls check? As a reminder, pls call
> 
> # make -C test filenotify-tests.log SELECTOR='(not "remote")'

Please find the log attached.


[-- Attachment #2: filenotify-tests.log --]
[-- Type: application/octet-stream, Size: 1116 bytes --]

Running 11 tests (2021-03-23 12:17:03+0100, selector `(not "remote")')
Library: `gfilenotify'
Monitor: `GFamDirectoryMonitor'
   passed   1/11  file-notify-test00-availability (0.104734 sec)
   passed   2/11  file-notify-test01-add-watch (0.015828 sec)
   passed   3/11  file-notify-test02-rm-watch (1.126690 sec)
   passed   4/11  file-notify-test03-events (113.101214 sec)
Reverting buffer `file-notify-testNLyzfF'.
Reverting buffer `file-notify-testNLyzfF'.
   passed   5/11  file-notify-test04-autorevert (18.061405 sec)
   passed   6/11  file-notify-test05-file-validity (34.041062 sec)
   passed   7/11  file-notify-test06-dir-validity (3.018815 sec)
   passed   8/11  file-notify-test07-many-events (313.080747 sec)
   passed   9/11  file-notify-test08-backup (26.063838 sec)
   passed  10/11  file-notify-test09-watched-file-in-watched-dir (100.049620 sec)
  skipped  11/11  file-notify-test10-sufficient-resources (0.003505 sec)

Ran 11 tests, 10 results as expected, 0 unexpected, 1 skipped (2021-03-23 12:27:12+0100, 608.684862 sec)

1 skipped results:
  SKIPPED  file-notify-test10-sufficient-resources


[-- Attachment #3: Type: text/plain, Size: 214 bytes --]




Best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

bug#47262: [platform-testers] Emacs 27.2 RC2

[Michael Albinus]

Dagobert Michelsen <dam@opencsw.org> writes:

> Hi Michael,

Hi Dago,

>> Thanks! Appended the next patch iteration. And I'm quite optimistic that
>> it is the last one :-)
>
> Ran 11 tests, 10 results as expected, 0 unexpected, 1 skipped (2021-03-23 12:27:12+0100, 608.684862 sec)

So that's it, all tests pass :-)

I'll push the changed filenotify-tests.el to the emacs-27 branch after
the release of Emacs 27.2.

> Best regards
>
>   — Dago

Thanks again for your continuous support in testing!

Best regards, Michael.

bug#47262: [platform-testers] Emacs 27.2 RC2

[Stefan Kangas]

Dagobert Michelsen <dam@opencsw.org> writes:

> Am 19.03.2021 um 08:35 schrieb Eli Zaretskii <eliz@gnu.org>:
>> The second release candidate for what will be the 27.2 release of Emacs
>> (the extensible text editor) is now available at
[...]
>
> I have a couple of test failures with Solaris 10 Sparc and Sun Studio:
>
> SUMMARY OF TEST RESULTS
> -----------------------
> Files examined: 267
> Ran 3829 tests, 77 failed to run, 3716 results as expected, 23 unexpected, 90 skipped
> 3 files did not finish:
>   src/emacs-module-tests.log
>   lisp/progmodes/sql-tests.log
>   lisp/auth-source-tests.log
> 8 files contained unexpected results:
>   lisp/vc/diff-mode-tests.log
>   lisp/progmodes/xref-tests.log
>   lisp/progmodes/flymake-tests.log
>   lisp/net/nsm-tests.log
>   lisp/net/network-stream-tests.log
>   lisp/files-tests.log
>   lisp/filenotify-tests.log
>   lisp/cedet/semantic-utest-ia.log
> gmake[2]: *** [Makefile:318: check-doit] Error 2
>
> All logfiles are available from the buildfarm at
>   http://buildfarm.opencsw.org/~dam/emacs-27.2-rc2-logs.tar.gz

Thank you for this.  We will release a new prerelease of Emacs soon, for
what will become the new Emacs 28.1, and if you could repeat these tests
for that version, that will be greatly appreciated.

Meanwhile, does it make sense to keep this bug report open?  I skimmed
the discussion and it seems like several issues were fixed, but perhaps
many of them still remain?

bug#47262: [platform-testers] Emacs 27.2 RC2

[Dagobert Michelsen]

Hi Stefan,

Am 21.10.2021 um 23:19 schrieb Stefan Kangas <stefan@marxist.se>:
> Thank you for this.  We will release a new prerelease of Emacs soon, for
> what will become the new Emacs 28.1, and if you could repeat these tests
> for that version, that will be greatly appreciated.

Sure, just drop me a note prior to release.

> Meanwhile, does it make sense to keep this bug report open?  I skimmed
> the discussion and it seems like several issues were fixed, but perhaps
> many of them still remain?

Probably, maybe until it is verified that all issues are vanished in the
upcoming release.


Best regards

  — Dago 


-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

bug#47262: [platform-testers] Emacs 27.2 RC2

[Stefan Kangas]

Hi Dagobert,

Dagobert Michelsen <dam@opencsw.org> writes:

>> Thank you for this.  We will release a new prerelease of Emacs soon, for
>> what will become the new Emacs 28.1, and if you could repeat these tests
>> for that version, that will be greatly appreciated.
>
> Sure, just drop me a note prior to release.

I just sent the announcement for the first pretest of Emacs 28.1:

  The first pretest for what will be the 28.1 release of Emacs (the
  extensible text editor) is available at:

    https://alpha.gnu.org/gnu/emacs/pretest/emacs-28.0.90.tar.xz

  The tarball is signed; you can get the PGP signature file at:

    https://alpha.gnu.org/gnu/emacs/pretest/emacs-28.0.90.tar.xz.sig

Any testing you can provide is most appreciated.  Thanks in advance.

bug#47262: [platform-testers] Emacs 27.2 RC2

[Dagobert Michelsen]

Hi Stefan,

Am 02.12.2021 um 23:41 schrieb Stefan Kangas <stefan@marxist.se>:
> Dagobert Michelsen <dam@opencsw.org> writes:
> 
>>> Thank you for this.  We will release a new prerelease of Emacs soon, for
>>> what will become the new Emacs 28.1, and if you could repeat these tests
>>> for that version, that will be greatly appreciated.
>> 
>> Sure, just drop me a note prior to release.
> 
> I just sent the announcement for the first pretest of Emacs 28.1:
> 
>  The first pretest for what will be the 28.1 release of Emacs (the
>  extensible text editor) is available at:
> 
>    https://alpha.gnu.org/gnu/emacs/pretest/emacs-28.0.90.tar.xz
> 
>  The tarball is signed; you can get the PGP signature file at:
> 
>    https://alpha.gnu.org/gnu/emacs/pretest/emacs-28.0.90.tar.xz.sig
> 
> Any testing you can provide is most appreciated.  Thanks in advance.

I have a build failure on Solaris 10 x86 with this version:

gmake[1]: Entering directory '/home/dam/mgar/pkg/emacs/trunk/work/solaris10-i386/build-isa-pentium_pro-features-athena/emacs-28.0.90/lib-src'
/opt/csw/bin/gcc-5.5   -fno-common -Wall -Wdate-time -Wdisabled-optimization -Wdouble-promotion -Wextra -Wformat-signedness -Winit-self -Winvalid-pch -Wlogical-op -Wmissing-declarations -Wmissing-include-dirs -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wopenmp-simd -Wpacked -Wpointer-arith -Wstrict-prototypes -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wsuggest-final-methods -Wsuggest-final-types -Wtrampolines -Wuninitialized -Wunknown-pragmas -Wunused-macros -Wvariadic-macros -Wvector-operation-performance -Warray-bounds=2 -Wformat=2 -Wredundant-decls -Wno-missing-field-initializers -Wno-override-init -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-format-nonliteral  -I. -I../src -I../lib -I. -I./../src -I./../lib  -m32 -march=pentiumpro -L/opt/csw/lib -L/usr/openwin/lib -I/opt/csw/include -O2 -pipe -fno-omit-frame-pointer -m32 -march=pentiumpro emacsclient.c \
    ../lib/libgnu.a -lsocket -lnsl \
    -lgen  -o emacsclient
Undefined                       first referenced
 symbol                             in file
acl_trivial                         ../lib/libgnu.a(file-has-acl.o)
ld: fatal: symbol referencing errors. No output written to emacsclient
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:401: emacsclient] Error 1


Best regards

  — Dago

bug#47262: [platform-testers] Emacs 27.2 RC2

[Eli Zaretskii]

> From: Dagobert Michelsen <dam@opencsw.org>
> Date: Sun, 5 Dec 2021 11:09:22 +0100
> Cc: Eli Zaretskii <eliz@gnu.org>,
>  47262@debbugs.gnu.org
> 
> I have a build failure on Solaris 10 x86 with this version:
> 
> gmake[1]: Entering directory '/home/dam/mgar/pkg/emacs/trunk/work/solaris10-i386/build-isa-pentium_pro-features-athena/emacs-28.0.90/lib-src'
> /opt/csw/bin/gcc-5.5   -fno-common -Wall -Wdate-time -Wdisabled-optimization -Wdouble-promotion -Wextra -Wformat-signedness -Winit-self -Winvalid-pch -Wlogical-op -Wmissing-declarations -Wmissing-include-dirs -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wopenmp-simd -Wpacked -Wpointer-arith -Wstrict-prototypes -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wsuggest-final-methods -Wsuggest-final-types -Wtrampolines -Wuninitialized -Wunknown-pragmas -Wunused-macros -Wvariadic-macros -Wvector-operation-performance -Warray-bounds=2 -Wformat=2 -Wredundant-decls -Wno-missing-field-initializers -Wno-override-init -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-format-nonliteral  -I. -I../src -I../lib -I. -I./../src -I./../lib  -m32 -march=pentiumpro -L/o
 pt/csw/lib -L/usr/openwin/lib -I/opt/csw/include -O2 -pipe -fno-omit-frame-pointer -m32 -march=pentiumpro emacsclient.c \
>     ../lib/libgnu.a -lsocket -lnsl \
>     -lgen  -o emacsclient
> Undefined                       first referenced
>  symbol                             in file
> acl_trivial                         ../lib/libgnu.a(file-has-acl.o)
> ld: fatal: symbol referencing errors. No output written to emacsclient
> collect2: error: ld returned 1 exit status
> gmake[1]: *** [Makefile:401: emacsclient] Error 1

Please try the latest emacs-28 branch (if you can), it's possible that
this was recently fixed.

bug#47262: [platform-testers] Emacs 27.2 RC2

[Dagobert Michelsen]

Hi Eli,

Am 05.12.2021 um 11:42 schrieb Eli Zaretskii <eliz@gnu.org>:
>> I have a build failure on Solaris 10 x86 with this version:
>> 
>> gmake[1]: Entering directory '/home/dam/mgar/pkg/emacs/trunk/work/solaris10-i386/build-isa-pentium_pro-features-athena/emacs-28.0.90/lib-src'
>> /opt/csw/bin/gcc-5.5   -fno-common -Wall -Wdate-time -Wdisabled-optimization -Wdouble-promotion -Wextra -Wformat-signedness -Winit-self -Winvalid-pch -Wlogical-op -Wmissing-declarations -Wmissing-include-dirs -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wopenmp-simd -Wpacked -Wpointer-arith -Wstrict-prototypes -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wsuggest-final-methods -Wsuggest-final-types -Wtrampolines -Wuninitialized -Wunknown-pragmas -Wunused-macros -Wvariadic-macros -Wvector-operation-performance -Warray-bounds=2 -Wformat=2 -Wredundant-decls -Wno-missing-field-initializers -Wno-override-init -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-format-nonliteral  -I. -I../src -I../lib -I. -I./../src -I./../lib  -m32 -march=pentiumpro -L/opt/csw/lib -L/usr/openwin/lib -I/opt/csw/include -O2 -pipe -fno-omit-frame-pointer -m32 -march=pentiumpro emacsclient.c \
>>    ../lib/libgnu.a -lsocket -lnsl \
>>    -lgen  -o emacsclient
>> Undefined                       first referenced
>> symbol                             in file
>> acl_trivial                         ../lib/libgnu.a(file-has-acl.o)
>> ld: fatal: symbol referencing errors. No output written to emacsclient
>> collect2: error: ld returned 1 exit status
>> gmake[1]: *** [Makefile:401: emacsclient] Error 1
> 
> Please try the latest emacs-28 branch (if you can), it's possible that
> this was recently fixed.

Unfortunately this requires bootstrapping which is pretty hard in my
environment. Is there a chance for a bootstrapped tarball?


Best regards

  — Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

bug#47262: [platform-testers] Emacs 27.2 RC2

[Eli Zaretskii]

> From: Dagobert Michelsen <dam@opencsw.org>
> Date: Sun, 5 Dec 2021 12:34:41 +0100
> Cc: stefan@marxist.se,
>  47262@debbugs.gnu.org
> 
> Am 05.12.2021 um 11:42 schrieb Eli Zaretskii <eliz@gnu.org>:
> >> I have a build failure on Solaris 10 x86 with this version:
> >> 
> >> gmake[1]: Entering directory '/home/dam/mgar/pkg/emacs/trunk/work/solaris10-i386/build-isa-pentium_pro-features-athena/emacs-28.0.90/lib-src'
> >> /opt/csw/bin/gcc-5.5   -fno-common -Wall -Wdate-time -Wdisabled-optimization -Wdouble-promotion -Wextra -Wformat-signedness -Winit-self -Winvalid-pch -Wlogical-op -Wmissing-declarations -Wmissing-include-dirs -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wopenmp-simd -Wpacked -Wpointer-arith -Wstrict-prototypes -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wsuggest-final-methods -Wsuggest-final-types -Wtrampolines -Wuninitialized -Wunknown-pragmas -Wunused-macros -Wvariadic-macros -Wvector-operation-performance -Warray-bounds=2 -Wformat=2 -Wredundant-decls -Wno-missing-field-initializers -Wno-override-init -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-format-nonliteral  -I. -I../src -I../lib -I. -I./../src -I./../lib  -m32 -march=pentiumpro -
 L/opt/csw/lib -L/usr/openwin/lib -I/opt/csw/include -O2 -pipe -fno-omit-frame-pointer -m32 -march=pentiumpro emacsclient.c \
> >>    ../lib/libgnu.a -lsocket -lnsl \
> >>    -lgen  -o emacsclient
> >> Undefined                       first referenced
> >> symbol                             in file
> >> acl_trivial                         ../lib/libgnu.a(file-has-acl.o)
> >> ld: fatal: symbol referencing errors. No output written to emacsclient
> >> collect2: error: ld returned 1 exit status
> >> gmake[1]: *** [Makefile:401: emacsclient] Error 1
> > 
> > Please try the latest emacs-28 branch (if you can), it's possible that
> > this was recently fixed.
> 
> Unfortunately this requires bootstrapping which is pretty hard in my
> environment. Is there a chance for a bootstrapped tarball?

Sorry, I cannot produce one.  maybe you could just apply the patches
from these two commits:

  fed35a89517aa4e282273f7e3c75bafd4e698ce4
  9c222b9c1a7f91497a37567b4d7de3a511fff069

Please apply them in the order shown, lest Patch fails.

bug#47262: [platform-testers] Emacs 27.2 RC2

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Sorry, I cannot produce one.  maybe you could just apply the patches
> from these two commits:
>
>   fed35a89517aa4e282273f7e3c75bafd4e698ce4
>   9c222b9c1a7f91497a37567b4d7de3a511fff069
>
> Please apply them in the order shown, lest Patch fails.

This bug report was about build errors of the previous release, and
skimming it, it seems like most of them are probably fixed in the
current release?  So I'm closing this bug report, but feel free to open
a new one if there are problems in 28.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no