From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#47262: [platform-testers] Emacs 27.2 RC2 Date: Sun, 21 Mar 2021 13:48:07 +0100 Message-ID: <87lfag7jw8.fsf@gmx.de> References: <835z1nfvdw.fsf@gnu.org> <736DA57A-EA29-4133-9D70-1467B3B8D7A6@opencsw.org> <87tup66vrp.fsf@gmx.de> <35210B18-1068-41CF-A18E-318E9C37CEDC@opencsw.org> <87pmzt7rh9.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36099"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47262@debbugs.gnu.org To: Dagobert Michelsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 21 13:49:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNxW2-0009F3-JA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 13:49:10 +0100 Original-Received: from localhost ([::1]:59126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNxW1-0007a1-Jx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 08:49:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNxVu-0007Zh-Vs for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 08:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNxVu-0006eu-F3 for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 08:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNxVu-0008OH-BH for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 08:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Mar 2021 12:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47262 X-GNU-PR-Package: emacs Original-Received: via spool by 47262-submit@debbugs.gnu.org id=B47262.161633089932203 (code B ref 47262); Sun, 21 Mar 2021 12:49:02 +0000 Original-Received: (at 47262) by debbugs.gnu.org; 21 Mar 2021 12:48:19 +0000 Original-Received: from localhost ([127.0.0.1]:53728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNxVC-0008NK-Ot for submit@debbugs.gnu.org; Sun, 21 Mar 2021 08:48:19 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:46475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNxVA-0008N6-5h for 47262@debbugs.gnu.org; Sun, 21 Mar 2021 08:48:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1616330889; bh=bWKClXPvt1KPrOXNWODO6YX1xWgbqZWXVqFFUfSeznE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=cbSOWuDf0hu0ZKmq+Oj+GltAE53QmuqAg2PxGAjVW5ISuLYWsLPhzZj3zH0Pviesl QhuuYLe2PAhDHJ8uY8A/tMwP+EptdCQyZY3ed51wSYPbWXNC+LReHrrXqcaX83voXd 4fFBJtwM7RVr9tKI27q1EuTxT41bNb4nO6/BK2Hw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.37.61]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MmULr-1m5qyP4A6b-00iT52; Sun, 21 Mar 2021 13:48:09 +0100 In-Reply-To: (Dagobert Michelsen's message of "Sat, 20 Mar 2021 21:02:51 +0100") X-Provags-ID: V03:K1:0M6QQ6pu0GlfYFQu2+uLwieyzBYLzT6PBInFOBNNnJTwBYsf9gH AxYxJzWBPZqmf+Vv9FHEkquMkL9uG8JgH1yeVJXZpcsDHrYBrMYMDz98fuoQgHqjdhV/j4N gtxkt/cRtE0teYnk4XdQFdB5qC3kJ5iSu+ikunEX+kSYMcyQzrb+1ZT2F/V0ANGifINpFoJ WBxz3dDf9+XM3LKHT/1Hw== X-UI-Out-Filterresults: notjunk:1;V03:K0:xC1wF2B3QFg=:Wz6IrPWKMUhvNuFzFjO5cf 6HYpheANb2QXXrLrcbsaCK1I4lb6I7nvJBDuxy2JpYeqUb3ukpnXCfe1wYaY6+/srCBekJzz7 1ZC00jPqtFCx8SXSkEBWSTniT/LPtt8faNcIjij0uQDKR/Sg3VVA/IIKapS7y8JC7IDTrD8DL mroQxTJNMA4/TAXinA14kz97RAGTrBWgSbhqrkRavjgkM3G4Ruyu6QEz8kxvun0ZkfaCpjOcp mFE8kzxskVa0ySqo/7Uh5eQGhKFSaAHDZjcrvcWPEqcnY3Fy+Sn1l685SqD8vX5ClIFEmUJwl KpKdXfGWagJbp+1IhVtun1OVYascEIam4D7B2SLtzAtE71nTkXeXq5aDKQn5cxuol/d77RIq1 +7peZ2B4MYoiVwHzMl5dCCpSP0vFgUWm9P0GshemIJXnGJU7xnJpMVOdY65GWXgg6TftbLZa/ CBiHAy3YBo7KbjokN308VzQgxSg6z+qMFyCdwmUYwrEHcXNBYZAzJ9rqCPWABZ7uRJtJy5wqM 1B0ACW6S8gIojf6PDPIvkV/fdBKRiZIX46TSMV5h7TVj5dY4SPtN2xZifgWbOZWi1nn/LbFGV RcZ63jwaiOLFThSD4Yfq15SjRnS3/zhr9yID9jX1Qte+EDcPCdBdzVsh0Cz1TDpz2Snwk4FXD oXGOiuHbqAwa3JPAdPpSO9UjAPxTpgzOOJHAK/Aro/AP9MYKqjSl91WPu7LXVROR16Hxibhxk IF4jqXAaPPmTg8XiZHDOwHq8JHXFhFa5bDm/ORW/KKR0gwWMVHA8/5qOK56Kc6F3lxghXrO4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202771 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dagobert Michelsen writes: > Hallo Michael, Hi Dago, > Here is the log file from the recent patch: Thanks. I've appended another patch, which should fix all open problems on Solaris. Could you pls check? Furthermore, I have seen that you didn't run the expensive tests file-notify-test07-many-events and file-notify-test09-watched-file-in-watched-dir. I expect further problems there, so please call # make -C test filenotify-tests.log Likely, there will be other errors. In that case, set file-notify-debug to t (line 201), and rerun that expensive test. There will be similar traces in the log file as you have sent already, which shall allow me to continue to work. > Best regards > > =E2=80=94 Dago Many thanks, and best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable *** /tmp/ediffpZId9s 2021-03-21 13:38:20.876372597 +0100 =2D-- /usr/local/src/emacs-27/test/lisp/filenotify-tests.el 2021-03-21 13:= 36:24.497655703 +0100 *************** *** 105,115 **** (cond ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5. So we must ;; wait at least this time in the GPollFileMonitor case. A ! ;; similar timeout seems to be needed in the GFamFileMonitor case, ! ;; at least on Cygwin. ((and (string-equal (file-notify--test-library) "gfilenotify") (memq (file-notify--test-monitor) ! '(GFamFileMonitor GPollFileMonitor))) 7) ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1= ) ((file-remote-p temporary-file-directory) 0.1) =2D-- 105,115 ---- (cond ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5. So we must ;; wait at least this time in the GPollFileMonitor case. A ! ;; similar timeout seems to be needed in the GFamFileMonitor and ! ;; GFamDirectoryMonitor case, at least on cygwin. ((and (string-equal (file-notify--test-library) "gfilenotify") (memq (file-notify--test-monitor) ! '(GFamFileMonitor GFamDirectoryMonitor GPollFileMonitor)= )) 7) ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1= ) ((file-remote-p temporary-file-directory) 0.1) *************** *** 455,461 **** (unwind-protect ;; Check, that removing watch descriptors out of order do not ! ;; harm. This fails on Cygwin because of timing issues unless a ;; long `sit-for' is added before the call to ;; `file-notify--test-read-event'. (unless (eq system-type 'cygwin) =2D-- 455,461 ---- (unwind-protect ;; Check, that removing watch descriptors out of order do not ! ;; harm. This fails on cygwin because of timing issues unless a ;; long `sit-for' is added before the call to ;; `file-notify--test-read-event'. (unless (eq system-type 'cygwin) *************** *** 542,547 **** =2D-- 542,551 ---- file-notify--test-results (append file-notify--test-results `(,result)))))) + (defun file-notify--test-event-actions () + "Helper function to return retrieved actions, as list." + (mapcar #'file-notify--test-event-action file-notify--test-events)) + (defun file-notify--test-with-actions-check (actions) "Check whether received actions match one of the ACTIONS alternatives.= " (let (result) *************** *** 550,571 **** (or result (if (eq (car elt) :random) (equal (sort (cdr elt) 'string-lessp) ! (sort (mapcar #'file-notify--test-event-actio= n ! file-notify--test-events) 'string-lessp)) ! (equal elt (mapcar #'file-notify--test-event-action ! file-notify--test-events)))))))) (defun file-notify--test-with-actions-explainer (actions) "Explain why `file-notify--test-with-actions-check' fails." (if (null (cdr actions)) (format "Received actions do not match expected actions\n%s\n%s" ! (mapcar #'file-notify--test-event-action file-notify--test= -events) ! (car actions)) (format "Received actions do not match any sequence of expected actions\n%s= \n%s" ! (mapcar #'file-notify--test-event-action file-notify--test-events) ! actions))) (put 'file-notify--test-with-actions-check 'ert-explainer 'file-notify--test-with-actions-explainer) =2D-- 554,578 ---- (or result (if (eq (car elt) :random) (equal (sort (cdr elt) 'string-lessp) ! (sort (file-notify--test-event-actions) 'string-lessp)) ! (equal elt (file-notify--test-event-actions)))))) ! ;; Do not report result in case we debug. Write messages instead. ! (if file-notify-debug ! (prog1 t ! (if result ! (message "Success\n%s" (file-notify--test-event-actions)) ! (message (file-notify--test-with-actions-explainer actions))= )) ! result))) (defun file-notify--test-with-actions-explainer (actions) "Explain why `file-notify--test-with-actions-check' fails." (if (null (cdr actions)) (format "Received actions do not match expected actions\n%s\n%s" ! (file-notify--test-event-actions) (car actions)) (format "Received actions do not match any sequence of expected actions\n%s= \n%s" ! (file-notify--test-event-actions) actions))) (put 'file-notify--test-with-actions-check 'ert-explainer 'file-notify--test-with-actions-explainer) *************** *** 635,640 **** =2D-- 642,650 ---- ;; cygwin does not raise a `changed' event. ((eq system-type 'cygwin) '(created deleted stopped)) + ;; GFamDirectoryMonitor does not report the `changed' event. + ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor) + '(created deleted stopped)) (t '(created changed deleted stopped))) (write-region "another text" nil file-notify--test-tmpfile nil 'no-message) *************** *** 665,670 **** =2D-- 675,685 ---- ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") '((deleted stopped) (changed deleted stopped))) + ;; GFamDirectoryMonitor does not detect the `changed' + ;; event reliably. + ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor) + '((deleted stopped) + (changed deleted stopped))) ;; There could be one or two `changed' events. (t '((changed deleted stopped) (changed changed deleted stopped)))) *************** *** 713,718 **** =2D-- 728,736 ---- ;; cygwin does not raise a `changed' event. ((eq system-type 'cygwin) '(created deleted stopped)) + ;; GFamDirectoryMonitor does not report the `changed' event. + ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor) + '(created deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed deleted stopped)) (t '(created changed deleted deleted stopped))) *************** *** 755,763 **** '((deleted stopped) (created created deleted stopped))) ;; There are three `deleted' events, for two files and ! ;; for the directory. Except for cygwin and kqueue. ((eq system-type 'cygwin) '(created created changed changed deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed created changed deleted stopped)) ;; On emba, `deleted' and `stopped' events of the =2D-- 773,784 ---- '((deleted stopped) (created created deleted stopped))) ;; There are three `deleted' events, for two files and ! ;; for the directory. Except for cygwin, ! ;; GFamDirectoryMonitor and kqueue. ((eq system-type 'cygwin) '(created created changed changed deleted stopped)) + ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor) + '(created created changed changed deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed created changed deleted stopped)) ;; On emba, `deleted' and `stopped' events of the *************** *** 813,823 **** ((getenv "EMACS_EMBA_CI") '(created changed renamed deleted)) ;; There are two `deleted' events, for the file and for ! ;; the directory. Except for cygwin and kqueue. And ! ;; cygwin raises `created' and `deleted' events instead ! ;; of a `renamed' event. ((eq system-type 'cygwin) '(created created deleted deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed renamed deleted stopped)) (t '(created changed renamed deleted deleted stopped))) =2D-- 834,847 ---- ((getenv "EMACS_EMBA_CI") '(created changed renamed deleted)) ;; There are two `deleted' events, for the file and for ! ;; the directory. Except for cygwin, ! ;; GFamDirectoryMonitor and kqueue. And cygwin and ! ;; GFamDirectoryMonitor raise `created' and `deleted' ! ;; events instead of a `renamed' event. ((eq system-type 'cygwin) '(created created deleted deleted stopped)) + ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor) + '(created created deleted deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed renamed deleted stopped)) (t '(created changed renamed deleted deleted stopped))) *************** *** 837,844 **** (file-notify--test-cleanup)) (unwind-protect ! ;; Check attribute change. Does not work for cygwin. ! (unless (eq system-type 'cygwin) (setq file-notify--test-tmpfile (file-notify--test-make-temp-name)) (write-region "any text" nil file-notify--test-tmpfile nil 'no-message) =2D-- 861,870 ---- (file-notify--test-cleanup)) (unwind-protect ! ;; Check attribute change. Does not work for cygwin and ! ;; GFamDirectoryMonitor. ! (unless (or (eq system-type 'cygwin) ! (equal (file-notify--test-monitor) 'GFamDirectoryMonit= or)) (setq file-notify--test-tmpfile (file-notify--test-make-temp-name)) (write-region "any text" nil file-notify--test-tmpfile nil 'no-message) *************** *** 951,957 **** ;; Modify file. We wait for two seconds, in order to ;; have another timestamp. One second seems to be too ! ;; short. And Cygwin sporadically requires more than two. (ert-with-message-capture captured-messages (sleep-for (if (eq system-type 'cygwin) 3 2)) (write-region =2D-- 977,983 ---- ;; Modify file. We wait for two seconds, in order to ;; have another timestamp. One second seems to be too ! ;; short. And cygwin sporadically requires more than two. (ert-with-message-capture captured-messages (sleep-for (if (eq system-type 'cygwin) 3 2)) (write-region *************** *** 1021,1026 **** =2D-- 1047,1057 ---- ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") '((deleted stopped) (changed deleted stopped))) + ;; GFamDirectoryMonitor does not detect the `changed' + ;; event reliably. + ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor) + '((deleted stopped) + (changed deleted stopped))) ;; There could be one or two `changed' events. (t '((changed deleted stopped) (changed changed deleted stopped)))) *************** *** 1064,1073 **** '((deleted stopped) (created deleted stopped))) ;; There are two `deleted' events, for the file and for ! ;; the directory. Except for cygwin and kqueue. And ! ;; cygwin does not raise a `changed' event. ((eq system-type 'cygwin) '(created deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed deleted stopped)) (t '(created changed deleted deleted stopped))) =2D-- 1095,1107 ---- '((deleted stopped) (created deleted stopped))) ;; There are two `deleted' events, for the file and for ! ;; the directory. Except for cygwin, ! ;; GFamDirectoryMonitor and kqueue. And cygwin and ! ;; GFamDirectoryMonitor do not raise a `changed' event. ((eq system-type 'cygwin) '(created deleted stopped)) + ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor) + '(created deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed deleted stopped)) (t '(created changed deleted deleted stopped))) *************** *** 1286,1291 **** =2D-- 1320,1328 ---- ;; On cygwin we only get the `changed' event. ((eq system-type 'cygwin) '(changed)) + ;; GFamDirectoryMonitor reports only the `changed' event. + ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor) + '(changed)) (t '(renamed created changed))) ;; The file is renamed when creating a backup. It shall ;; still be watched. --=-=-=--