From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#47262: [platform-testers] Emacs 27.2 RC2 Date: Tue, 23 Mar 2021 10:32:29 +0100 Message-ID: <87r1k65i6q.fsf@gmx.de> References: <835z1nfvdw.fsf@gnu.org> <736DA57A-EA29-4133-9D70-1467B3B8D7A6@opencsw.org> <87tup66vrp.fsf@gmx.de> <35210B18-1068-41CF-A18E-318E9C37CEDC@opencsw.org> <87pmzt7rh9.fsf@gmx.de> <87lfag7jw8.fsf@gmx.de> <4390F29D-9987-42C5-AE07-0CE61EB52C55@opencsw.org> <87czvr6y9k.fsf@gmx.de> <944B539E-7F0A-4F25-AACD-584AA3880001@opencsw.org> <878s6e708f.fsf@gmx.de> <91A7B63E-E725-4A81-86B4-93F45AB71AC5@opencsw.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14548"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47262@debbugs.gnu.org To: Dagobert Michelsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 23 10:33:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOdPW-0003aV-3t for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Mar 2021 10:33:14 +0100 Original-Received: from localhost ([::1]:45468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOdPV-0008OB-2t for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Mar 2021 05:33:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOdPK-0008O4-GN for bug-gnu-emacs@gnu.org; Tue, 23 Mar 2021 05:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47980) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOdPK-0005g8-90 for bug-gnu-emacs@gnu.org; Tue, 23 Mar 2021 05:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lOdPK-0002v9-5Q for bug-gnu-emacs@gnu.org; Tue, 23 Mar 2021 05:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Mar 2021 09:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47262 X-GNU-PR-Package: emacs Original-Received: via spool by 47262-submit@debbugs.gnu.org id=B47262.161649196311202 (code B ref 47262); Tue, 23 Mar 2021 09:33:02 +0000 Original-Received: (at 47262) by debbugs.gnu.org; 23 Mar 2021 09:32:43 +0000 Original-Received: from localhost ([127.0.0.1]:59526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOdP0-0002ub-7W for submit@debbugs.gnu.org; Tue, 23 Mar 2021 05:32:43 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:49209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOdOx-0002uI-GQ for 47262@debbugs.gnu.org; Tue, 23 Mar 2021 05:32:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1616491951; bh=sLwXf10Bnjf7gnQBxOysDypVVYWdEGkfRYkLRHZxZf0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=jjk7NbOffwz/SBwrUJSNY5F2hd8EBPBbFecalDQLHSbKXH6PPMr9RzW9VBzdGTOZl flBizCJ/UrNsfNc88rAx8pWcLY3Ai4JY2uev9kXToptwBoENiolgmB8AhTaTqJaRMU 0sllPAZoesoTBpWWKqMdZNt4IhA9fRSIu2bcS+Ac= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.243.117]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MC34h-1lW1mE1bJ7-00CQp5; Tue, 23 Mar 2021 10:32:31 +0100 In-Reply-To: <91A7B63E-E725-4A81-86B4-93F45AB71AC5@opencsw.org> (Dagobert Michelsen's message of "Tue, 23 Mar 2021 09:42:26 +0100") X-Provags-ID: V03:K1:lvFPZpdJuEAkjvPOf+fck3ECOB9dZjx/mar9mo0a+YF2QW0D47e xZadmKHQvLPeOQAme9jcfN+DgKxy3MGhkNOL5vaf7J3KAKpyVuCt7Uf/KA4qFJrXFDr5kqm jpy4cc5q7NxzzJe5pcebPeYUB4KpMDmNiumFUsA3M90tzuLJCvnUjWzsaXUbAgT6ls0sFW0 1+6HzA+OeUAUog5BjOdmw== X-UI-Out-Filterresults: notjunk:1;V03:K0:EXv6RaVYM+g=:bZUir/VgzKUyTWidMoMKH2 0X1Uv+/1Zusapmp33aAbkltS9nAipOJ2rMYJVohkXkHnccpYdgTIAjChpg2sb67WVFCfJvUVZ aJ6emM7AQhUtPZLvjr+kjCdGVxd8hmS+AfWDOg+EYRPuS099jLlYwd0y3gfYVmJ8/VsguS0bO 4GwgM+3+X4TKyum7HEXUY5GhiDcwBMMPaYz71jrOEs1I9Bc+orGGV437uxSCaKB2CXBs8BpNA DeozAa7582dr6Nb4rFX4ROk/Gpekau5uz1PEhxuzgTh9EHZ2TreAIbzpAutsinzvCHx8MTmpI THxNVAm4Hxb3An62pFucblP0YmnBwwn2nh3hBx8eFclnj5Y58eVmtAtUzGjZtfhxJS/JbBJdn +vxq43U4Rcut3eZS2fG5Xy7oeSCJdpHSYVRDPF58KB6RbqY9rv47x435N8vjG+1WvOG4yk2xR 5TlnkO4HVB/TA0hU8cmv7qJx4nbQrY0RNclNLlcrYQBMzS9BdgQNQpRASEr+d5h5oMO21SKOp COHgbfwmUP3qPzrdOoOMEHFewr01B1o2KQ1NKh6aQA8CxTHKxIIaKVYkIg1gdxlI0VjTToXjE tRLIvoUXeHj//6s8SUoud8LZuDN4M2ehhb1L7AnST45y8mVT0K+JPSKksTGYhz8aR1ZL0EDTR XFpDke1Wu/RRiPyCCuZX1mmDSGgRp58s+uqjFL7qzNlPsLmoo8qghi8uzjTBmbwtj3534oXfS XueAZJP0GPFm6RT1wCHcXsI1V/RwAeFoi0/ckdNQRPX7wtH4UZUd2iSyVJ63gvtPR2Fo/sg2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202887 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dagobert Michelsen writes: > Hi Michael, Hi Dago, > Please find the new log attached. Thanks! Appended the next patch iteration. And I'm quite optimistic that it is the last one :-) Could you pls check? As a reminder, pls call # make -C test filenotify-tests.log SELECTOR=3D'(not "remote")' > Best regards > > =E2=80=94 Dago Thanks, and best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable *** /tmp/ediffpkAKG4 2021-03-23 10:28:18.611288593 +0100 =2D-- /usr/local/src/emacs-27/test/lisp/filenotify-tests.el 2021-03-23 10:= 10:45.362714979 +0100 *************** *** 105,115 **** (cond ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5. So we must ;; wait at least this time in the GPollFileMonitor case. A ! ;; similar timeout seems to be needed in the GFamFileMonitor case, ! ;; at least on Cygwin. ! ((and (string-equal (file-notify--test-library) "gfilenotify") ! (memq (file-notify--test-monitor) ! '(GFamFileMonitor GPollFileMonitor))) 7) ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1= ) ((file-remote-p temporary-file-directory) 0.1) =2D-- 105,114 ---- (cond ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5. So we must ;; wait at least this time in the GPollFileMonitor case. A ! ;; similar timeout seems to be needed in the ! ;; GFam{File,Directory}Monitor case. ! ((memq (file-notify--test-monitor) ! '(GFamFileMonitor GFamDirectoryMonitor GPollFileMonitor)) 7) ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1= ) ((file-remote-p temporary-file-directory) 0.1) *************** *** 263,274 **** ;; `gfile-monitor-name' does not return a proper result anymore. ;; But we still need this information. (unless (file-remote-p temporary-file-directory) ! (or (cdr (assq file-notify--test-desc file-notify--test-monitors)) (when (functionp 'gfile-monitor-name) (add-to-list 'file-notify--test-monitors (cons file-notify--test-desc (gfile-monitor-name file-notify--test-desc)= )) ! (cdr (assq file-notify--test-desc file-notify--test-monitors))= )))) (defmacro file-notify--deftest-remote (test docstring &optional unstable= ) "Define ert `TEST-remote' for remote files. =2D-- 262,273 ---- ;; `gfile-monitor-name' does not return a proper result anymore. ;; But we still need this information. (unless (file-remote-p temporary-file-directory) ! (or (alist-get file-notify--test-desc file-notify--test-monitors) (when (functionp 'gfile-monitor-name) (add-to-list 'file-notify--test-monitors (cons file-notify--test-desc (gfile-monitor-name file-notify--test-desc)= )) ! (alist-get file-notify--test-desc file-notify--test-monitors))= ))) (defmacro file-notify--deftest-remote (test docstring &optional unstable= ) "Define ert `TEST-remote' for remote files. *************** *** 455,461 **** (unwind-protect ;; Check, that removing watch descriptors out of order do not ! ;; harm. This fails on Cygwin because of timing issues unless a ;; long `sit-for' is added before the call to ;; `file-notify--test-read-event'. (unless (eq system-type 'cygwin) =2D-- 454,460 ---- (unwind-protect ;; Check, that removing watch descriptors out of order do not ! ;; harm. This fails on cygwin because of timing issues unless a ;; long `sit-for' is added before the call to ;; `file-notify--test-read-event'. (unless (eq system-type 'cygwin) *************** *** 542,547 **** =2D-- 541,550 ---- file-notify--test-results (append file-notify--test-results `(,result)))))) + (defun file-notify--test-event-actions () + "Helper function to return retrieved actions, as list." + (mapcar #'file-notify--test-event-action file-notify--test-events)) + (defun file-notify--test-with-actions-check (actions) "Check whether received actions match one of the ACTIONS alternatives.= " (let (result) *************** *** 550,571 **** (or result (if (eq (car elt) :random) (equal (sort (cdr elt) 'string-lessp) ! (sort (mapcar #'file-notify--test-event-actio= n ! file-notify--test-events) 'string-lessp)) ! (equal elt (mapcar #'file-notify--test-event-action ! file-notify--test-events)))))))) (defun file-notify--test-with-actions-explainer (actions) "Explain why `file-notify--test-with-actions-check' fails." (if (null (cdr actions)) (format "Received actions do not match expected actions\n%s\n%s" ! (mapcar #'file-notify--test-event-action file-notify--test= -events) ! (car actions)) (format "Received actions do not match any sequence of expected actions\n%s= \n%s" ! (mapcar #'file-notify--test-event-action file-notify--test-events) ! actions))) (put 'file-notify--test-with-actions-check 'ert-explainer 'file-notify--test-with-actions-explainer) =2D-- 553,577 ---- (or result (if (eq (car elt) :random) (equal (sort (cdr elt) 'string-lessp) ! (sort (file-notify--test-event-actions) 'string-lessp)) ! (equal elt (file-notify--test-event-actions)))))) ! ;; Do not report result in case we debug. Write messages instead. ! (if file-notify-debug ! (prog1 t ! (if result ! (message "Success\n%s" (file-notify--test-event-actions)) ! (message (file-notify--test-with-actions-explainer actions))= )) ! result))) (defun file-notify--test-with-actions-explainer (actions) "Explain why `file-notify--test-with-actions-check' fails." (if (null (cdr actions)) (format "Received actions do not match expected actions\n%s\n%s" ! (file-notify--test-event-actions) (car actions)) (format "Received actions do not match any sequence of expected actions\n%s= \n%s" ! (file-notify--test-event-actions) actions))) (put 'file-notify--test-with-actions-check 'ert-explainer 'file-notify--test-with-actions-explainer) *************** *** 632,640 **** (file-notify--test-library) "gvfs-monitor-dir.exe") '((deleted stopped) (created deleted stopped))) ! ;; cygwin does not raise a `changed' event. ! ((eq system-type 'cygwin) ! '(created deleted stopped)) (t '(created changed deleted stopped))) (write-region "another text" nil file-notify--test-tmpfile nil 'no-message) =2D-- 638,647 ---- (file-notify--test-library) "gvfs-monitor-dir.exe") '((deleted stopped) (created deleted stopped))) ! ;; GFam{File,Directory}Monitor do not report the `changed' event. ! ((memq (file-notify--test-monitor) ! '(GFamFileMonitor GFamDirectoryMonitor)) ! '(created deleted stopped)) (t '(created changed deleted stopped))) (write-region "another text" nil file-notify--test-tmpfile nil 'no-message) *************** *** 665,670 **** =2D-- 672,683 ---- ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") '((deleted stopped) (changed deleted stopped))) + ;; GFam{File,Directory}Monitor do not detect the + ;; `changed' event reliably. + ((memq (file-notify--test-monitor) + '(GFamFileMonitor GFamDirectoryMonitor)) + '((deleted stopped) + (changed deleted stopped))) ;; There could be one or two `changed' events. (t '((changed deleted stopped) (changed changed deleted stopped)))) *************** *** 709,717 **** ((getenv "EMACS_EMBA_CI") '(created changed deleted)) ;; There are two `deleted' events, for the file and for ! ;; the directory. Except for cygwin and kqueue. And ! ;; cygwin does not raise a `changed' event. ! ((eq system-type 'cygwin) '(created deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed deleted stopped)) =2D-- 722,732 ---- ((getenv "EMACS_EMBA_CI") '(created changed deleted)) ;; There are two `deleted' events, for the file and for ! ;; the directory. Except for GFam{File,Directory}Monitor ! ;; and kqueue. And GFam{File,Directory}Monitor do not ! ;; raise a `changed' event. ! ((memq (file-notify--test-monitor) ! '(GFamFileMonitor GFamDirectoryMonitor)) '(created deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed deleted stopped)) *************** *** 755,762 **** '((deleted stopped) (created created deleted stopped))) ;; There are three `deleted' events, for two files and ! ;; for the directory. Except for cygwin and kqueue. ! ((eq system-type 'cygwin) '(created created changed changed deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed created changed deleted stopped)) =2D-- 770,779 ---- '((deleted stopped) (created created deleted stopped))) ;; There are three `deleted' events, for two files and ! ;; for the directory. Except for ! ;; GFam{File,Directory}Monitor and kqueue. ! ((memq (file-notify--test-monitor) ! '(GFamFileMonitor GFamDirectoryMonitor)) '(created created changed changed deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed created changed deleted stopped)) *************** *** 813,822 **** ((getenv "EMACS_EMBA_CI") '(created changed renamed deleted)) ;; There are two `deleted' events, for the file and for ! ;; the directory. Except for cygwin and kqueue. And ! ;; cygwin raises `created' and `deleted' events instead ! ;; of a `renamed' event. ! ((eq system-type 'cygwin) '(created created deleted deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed renamed deleted stopped)) =2D-- 830,841 ---- ((getenv "EMACS_EMBA_CI") '(created changed renamed deleted)) ;; There are two `deleted' events, for the file and for ! ;; the directory. Except for GFam{File,Directory}Monitor ! ;; and kqueue. And GFam{File,Directory}Monitor raise ! ;; `created' and `deleted' events instead of a `renamed' ! ;; event. ! ((memq (file-notify--test-monitor) ! '(GFamFileMonitor GFamDirectoryMonitor)) '(created created deleted deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed renamed deleted stopped)) *************** *** 837,844 **** (file-notify--test-cleanup)) (unwind-protect ! ;; Check attribute change. Does not work for cygwin. ! (unless (eq system-type 'cygwin) (setq file-notify--test-tmpfile (file-notify--test-make-temp-name)) (write-region "any text" nil file-notify--test-tmpfile nil 'no-message) =2D-- 856,863 ---- (file-notify--test-cleanup)) (unwind-protect ! ;; Check attribute change. Does not work for GFam{File,Directory}= Monitor. ! (progn (setq file-notify--test-tmpfile (file-notify--test-make-temp-name)) (write-region "any text" nil file-notify--test-tmpfile nil 'no-message) *************** *** 847,875 **** (file-notify--test-add-watch file-notify--test-tmpfile '(attribute-change) #'file-notify--test-event-handler))) ! (file-notify--test-with-actions ! (cond ! ;; w32notify does not distinguish between `changed' and ! ;; `attribute-changed'. Under MS Windows 7, we get four ! ;; `changed' events, and under MS Windows 10 just two. ! ;; Strange. ! ((string-equal (file-notify--test-library) "w32notify") ! '((changed changed) ! (changed changed changed changed))) ! ;; For kqueue and in the remote case, `write-region' ! ;; raises also an `attribute-changed' event. ! ((or (string-equal (file-notify--test-library) "kqueue") ! (file-remote-p temporary-file-directory)) ! '(attribute-changed attribute-changed attribute-changed)) ! (t '(attribute-changed attribute-changed))) ! (write-region ! "any text" nil file-notify--test-tmpfile nil 'no-message) ! (file-notify--test-read-event) ! (set-file-modes file-notify--test-tmpfile 000) ! (file-notify--test-read-event) ! (set-file-times file-notify--test-tmpfile '(0 0)) ! (file-notify--test-read-event) ! (delete-file file-notify--test-tmpfile)) (file-notify-rm-watch file-notify--test-desc) ;; The environment shall be cleaned up. =2D-- 866,896 ---- (file-notify--test-add-watch file-notify--test-tmpfile '(attribute-change) #'file-notify--test-event-handler))) ! (unless (memq (file-notify--test-monitor) ! '(GFamFileMonitor GFamDirectoryMonitor)) ! (file-notify--test-with-actions ! (cond ! ;; w32notify does not distinguish between `changed' and ! ;; `attribute-changed'. Under MS Windows 7, we get ! ;; four `changed' events, and under MS Windows 10 just ! ;; two. Strange. ! ((string-equal (file-notify--test-library) "w32notify") ! '((changed changed) ! (changed changed changed changed))) ! ;; For kqueue and in the remote case, `write-region' ! ;; raises also an `attribute-changed' event. ! ((or (string-equal (file-notify--test-library) "kqueue") ! (file-remote-p temporary-file-directory)) ! '(attribute-changed attribute-changed attribute-changed)) ! (t '(attribute-changed attribute-changed))) ! (write-region ! "any text" nil file-notify--test-tmpfile nil 'no-message) ! (file-notify--test-read-event) ! (set-file-modes file-notify--test-tmpfile 000) ! (file-notify--test-read-event) ! (set-file-times file-notify--test-tmpfile '(0 0)) ! (file-notify--test-read-event) ! (delete-file file-notify--test-tmpfile))) (file-notify-rm-watch file-notify--test-desc) ;; The environment shall be cleaned up. *************** *** 951,957 **** ;; Modify file. We wait for two seconds, in order to ;; have another timestamp. One second seems to be too ! ;; short. And Cygwin sporadically requires more than two. (ert-with-message-capture captured-messages (sleep-for (if (eq system-type 'cygwin) 3 2)) (write-region =2D-- 972,978 ---- ;; Modify file. We wait for two seconds, in order to ;; have another timestamp. One second seems to be too ! ;; short. And cygwin sporadically requires more than two. (ert-with-message-capture captured-messages (sleep-for (if (eq system-type 'cygwin) 3 2)) (write-region *************** *** 1021,1026 **** =2D-- 1042,1053 ---- ((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") '((deleted stopped) (changed deleted stopped))) + ;; GFam{File,Directory}Monitor do not detect the + ;; `changed' event reliably. + ((memq (file-notify--test-monitor) + '(GFamFileMonitor GFamDirectoryMonitor)) + '((deleted stopped) + (changed deleted stopped))) ;; There could be one or two `changed' events. (t '((changed deleted stopped) (changed changed deleted stopped)))) *************** *** 1064,1072 **** '((deleted stopped) (created deleted stopped))) ;; There are two `deleted' events, for the file and for ! ;; the directory. Except for cygwin and kqueue. And ! ;; cygwin does not raise a `changed' event. ! ((eq system-type 'cygwin) '(created deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed deleted stopped)) =2D-- 1091,1102 ---- '((deleted stopped) (created deleted stopped))) ;; There are two `deleted' events, for the file and for ! ;; the directory. Except for ! ;; GFam{File,Directory}Monitor and kqueue. And ! ;; GFam{File,Directory}Monitor do not raise a `changed' ! ;; event. ! ((memq (file-notify--test-monitor) ! '(GFamFileMonitor GFamDirectoryMonitor)) '(created deleted stopped)) ((string-equal (file-notify--test-library) "kqueue") '(created changed deleted stopped)) *************** *** 1169,1175 **** file-notify--test-tmpfile '(change) #'file-notify--test-event-handler))) (unwind-protect ! (let ((n 1000) source-file-list target-file-list (default-directory file-notify--test-tmpfile)) (dotimes (i n) =2D-- 1199,1205 ---- file-notify--test-tmpfile '(change) #'file-notify--test-event-handler))) (unwind-protect ! (let ((n 10);00) source-file-list target-file-list (default-directory file-notify--test-tmpfile)) (dotimes (i n) *************** *** 1198,1206 **** (dotimes (_i n) (setq r (append '(deleted renamed) r))) r)) ! ;; cygwin fires `changed' and `deleted' events, sometimes ! ;; in random order. ! ((eq system-type 'cygwin) (let (r) (dotimes (_i n) (setq r (append '(changed deleted) r))) =2D-- 1228,1237 ---- (dotimes (_i n) (setq r (append '(deleted renamed) r))) r)) ! ;; GFam{File,Directory}Monitor fire `changed' and ! ;; `deleted' events, sometimes in random order. ! ((memq (file-notify--test-monitor) ! '(GFamFileMonitor GFamDirectoryMonitor)) (let (r) (dotimes (_i n) (setq r (append '(changed deleted) r))) *************** *** 1283,1291 **** (should (file-notify-valid-p file-notify--test-desc)) (file-notify--test-with-actions (cond ! ;; On cygwin we only get the `changed' event. ! ((eq system-type 'cygwin) ! '(changed)) (t '(renamed created changed))) ;; The file is renamed when creating a backup. It shall ;; still be watched. =2D-- 1314,1323 ---- (should (file-notify-valid-p file-notify--test-desc)) (file-notify--test-with-actions (cond ! ;; GFam{File,Directory}Monitor report only the `changed' event. ! ((memq (file-notify--test-monitor) ! '(GFamFileMonitor GFamDirectoryMonitor)) ! '(changed)) (t '(renamed created changed))) ;; The file is renamed when creating a backup. It shall ;; still be watched. *************** *** 1355,1361 **** (should (file-notify-valid-p file-notify--test-desc1)) (should (file-notify-valid-p file-notify--test-desc2)) (should-not (equal file-notify--test-desc1 file-notify--test-des= c2)) ! (let ((n 100)) ;; Run the test. (file-notify--test-with-actions ;; There could be one or two `changed' events. =2D-- 1387,1393 ---- (should (file-notify-valid-p file-notify--test-desc1)) (should (file-notify-valid-p file-notify--test-desc2)) (should-not (equal file-notify--test-desc1 file-notify--test-des= c2)) ! (let ((n 10));0)) ;; Run the test. (file-notify--test-with-actions ;; There could be one or two `changed' events. *************** *** 1407,1416 **** ;; Now we delete the directory. (file-notify--test-with-actions (cond ! ;; In kqueue and for cygwin, just one `deleted' event for ! ;; the directory is received. ! ((or (eq system-type 'cygwin) ! (string-equal (file-notify--test-library) "kqueue")) '(deleted stopped)) (t (append ;; The directory monitor raises a `deleted' event for =2D-- 1439,1450 ---- ;; Now we delete the directory. (file-notify--test-with-actions (cond ! ;; GFam{File,Directory}Monitor and kqueue raise just one ! ;; `deleted' event for the directory. ! ((memq (file-notify--test-monitor) ! '(GFamFileMonitor GFamDirectoryMonitor)) ! '(deleted stopped)) ! ((string-equal (file-notify--test-library) "kqueue") '(deleted stopped)) (t (append ;; The directory monitor raises a `deleted' event for --=-=-=--