From: Michael Albinus <michael.albinus@gmx.de>
To: Dagobert Michelsen <dam@opencsw.org>
Cc: 47262@debbugs.gnu.org
Subject: bug#47262: [platform-testers] Emacs 27.2 RC2
Date: Sat, 20 Mar 2021 16:52:02 +0100 [thread overview]
Message-ID: <87pmzt7rh9.fsf@gmx.de> (raw)
In-Reply-To: <35210B18-1068-41CF-A18E-318E9C37CEDC@opencsw.org> (Dagobert Michelsen's message of "Sat, 20 Mar 2021 15:14:27 +0100")
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
Dagobert Michelsen <dam@opencsw.org> writes:
> Hi Michael,
Hi Dago,
>> Many thanks in advance (and be
>> prepared, I will exploit you iteratively until all tests pass. If you
>> agree :-)
>
> Of course :-)
Well, here's another patch you could apply instead. I've changed the
tests as indicated in the previous log file. And in order to cut the
number of iterations, I don't let fail the tests any longer, but let
them trace what happens. Could you, pls, send me the next log file,
produced after applying this patch?
> Best regards
>
> — Dago
Thanks, and best regards, Michael.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 5046 bytes --]
*** /tmp/ediffumMrVc 2021-03-20 16:50:58.959414691 +0100
--- /home/albinus/src/emacs-27/test/lisp/filenotify-tests.el 2021-03-20 16:44:46.138512407 +0100
***************
*** 109,115 ****
;; at least on Cygwin.
((and (string-equal (file-notify--test-library) "gfilenotify")
(memq (file-notify--test-monitor)
! '(GFamFileMonitor GPollFileMonitor)))
7)
((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
((file-remote-p temporary-file-directory) 0.1)
--- 109,115 ----
;; at least on Cygwin.
((and (string-equal (file-notify--test-library) "gfilenotify")
(memq (file-notify--test-monitor)
! '(GFamFileMonitor GFamDirectoryMonitor GPollFileMonitor)))
7)
((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe") 1)
((file-remote-p temporary-file-directory) 0.1)
***************
*** 607,613 ****
(ert-fail
(cadr (ert-test-result-with-condition-condition result)))))
;; One of the possible event sequences shall match.
! (should (file-notify--test-with-actions-check actions))))
(ert-deftest file-notify-test03-events ()
"Check file creation/change/removal notifications."
--- 607,617 ----
(ert-fail
(cadr (ert-test-result-with-condition-condition result)))))
;; One of the possible event sequences shall match.
! (if (file-notify--test-with-actions-check actions)
! (message
! "Success!\n%s"
! (mapcar #'file-notify--test-event-action file-notify--test-events))
! (message (file-notify--test-with-actions-explainer actions)))))
(ert-deftest file-notify-test03-events ()
"Check file creation/change/removal notifications."
***************
*** 635,640 ****
--- 639,647 ----
;; cygwin does not raise a `changed' event.
((eq system-type 'cygwin)
'(created deleted stopped))
+ ;; GFamDirectoryMonitor does not report the `changed' event.
+ ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ '(created deleted stopped))
(t '(created changed deleted stopped)))
(write-region
"another text" nil file-notify--test-tmpfile nil 'no-message)
***************
*** 666,672 ****
'((deleted stopped)
(changed deleted stopped)))
;; There could be one or two `changed' events.
! (t '((changed deleted stopped)
(changed changed deleted stopped))))
(write-region
"another text" nil file-notify--test-tmpfile nil 'no-message)
--- 673,682 ----
'((deleted stopped)
(changed deleted stopped)))
;; There could be one or two `changed' events.
! ;; GFamDirectoryMonitor does not report the `changed' event.
! ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
! '(deleted stopped))
! (t '((changed deleted stopped)
(changed changed deleted stopped))))
(write-region
"another text" nil file-notify--test-tmpfile nil 'no-message)
***************
*** 713,719 ****
;; cygwin does not raise a `changed' event.
((eq system-type 'cygwin)
'(created deleted stopped))
! ((string-equal (file-notify--test-library) "kqueue")
'(created changed deleted stopped))
(t '(created changed deleted deleted stopped)))
(write-region
--- 723,732 ----
;; cygwin does not raise a `changed' event.
((eq system-type 'cygwin)
'(created deleted stopped))
! ;; GFamDirectoryMonitor does not report the `changed' event.
! ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
! '(created deleted stopped))
! ((string-equal (file-notify--test-library) "kqueue")
'(created changed deleted stopped))
(t '(created changed deleted deleted stopped)))
(write-region
***************
*** 1021,1026 ****
--- 1034,1042 ----
((string-equal (file-notify--test-library) "gvfs-monitor-dir.exe")
'((deleted stopped)
(changed deleted stopped)))
+ ;; GFamDirectoryMonitor does not report the `changed' event.
+ ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ '(deleted stopped))
;; There could be one or two `changed' events.
(t '((changed deleted stopped)
(changed changed deleted stopped))))
***************
*** 1286,1291 ****
--- 1302,1310 ----
;; On cygwin we only get the `changed' event.
((eq system-type 'cygwin)
'(changed))
+ ;; GFamDirectoryMonitor reports only the `changed' event.
+ ((equal (file-notify--test-monitor) 'GFamDirectoryMonitor)
+ '(changed))
(t '(renamed created changed)))
;; The file is renamed when creating a backup. It shall
;; still be watched.
next prev parent reply other threads:[~2021-03-20 15:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <835z1nfvdw.fsf@gnu.org>
2021-03-19 13:42 ` bug#47262: [platform-testers] Emacs 27.2 RC2 Dagobert Michelsen
2021-03-19 14:05 ` Eli Zaretskii
2021-03-19 18:03 ` Robert Pluim
2021-03-19 20:09 ` Eli Zaretskii
2021-03-20 9:04 ` Michael Albinus
2021-03-20 14:14 ` Dagobert Michelsen
2021-03-20 15:52 ` Michael Albinus [this message]
2021-03-20 20:02 ` Dagobert Michelsen
2021-03-21 12:48 ` Michael Albinus
2021-03-22 14:17 ` Dagobert Michelsen
2021-03-22 14:47 ` Michael Albinus
2021-03-23 7:38 ` Dagobert Michelsen
2021-03-23 8:17 ` Michael Albinus
2021-03-23 8:42 ` Dagobert Michelsen
2021-03-23 9:32 ` Michael Albinus
2021-03-23 11:52 ` Dagobert Michelsen
2021-03-23 12:08 ` Michael Albinus
2021-10-21 21:19 ` Stefan Kangas
2021-10-22 6:32 ` Dagobert Michelsen
2021-12-02 22:41 ` Stefan Kangas
2021-12-05 10:09 ` Dagobert Michelsen
2021-12-05 10:42 ` Eli Zaretskii
2021-12-05 11:34 ` Dagobert Michelsen
2021-12-05 13:51 ` Eli Zaretskii
2022-06-25 12:00 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmzt7rh9.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=47262@debbugs.gnu.org \
--cc=dam@opencsw.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).