* bug#4221: improve font-lock-comment-face on dark background low color terminals
@ 2009-08-21 4:30 Dan Nicolaescu
2011-07-12 21:06 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Dan Nicolaescu @ 2009-08-21 4:30 UTC (permalink / raw)
To: bug-gnu-emacs
The patch below uses the high contrast "yellow" color for
font-lock-comment-face on low color terminals using a dark background
color.
Yellow is not used by many other font-lock faces on such terminals.
This will enable us to eliminate the need for the
font-lock-comment-delimiter-face. (which the patch does not do, it just
makes it identical to font-lock-comment-face, it will be done in an
incremental patch).
Index: lisp/font-lock.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/font-lock.el,v
retrieving revision 1.351
diff -u -3 -p -r1.351 font-lock.el
--- lisp/font-lock.el 2 Aug 2009 14:20:10 -0000 1.351
+++ lisp/font-lock.el 19 Aug 2009 05:15:42 -0000
@@ -1853,19 +1853,13 @@ Sets various variables using `font-lock-
(((class color) (min-colors 8) (background light))
(:foreground "red"))
(((class color) (min-colors 8) (background dark))
- )
+ (:foreground "yellow"))
(t (:weight bold :slant italic)))
"Font Lock mode face used to highlight comments."
:group 'font-lock-faces)
(defface font-lock-comment-delimiter-face
- '((default :inherit font-lock-comment-face)
- (((class grayscale)))
- (((class color) (min-colors 16)))
- (((class color) (min-colors 8) (background light))
- :foreground "red")
- (((class color) (min-colors 8) (background dark))
- :foreground "red1"))
+ '((default :inherit font-lock-comment-face))
"Font Lock mode face used to highlight comment delimiters."
:group 'font-lock-faces)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#4221: improve font-lock-comment-face on dark background low color terminals
2009-08-21 4:30 bug#4221: improve font-lock-comment-face on dark background low color terminals Dan Nicolaescu
@ 2011-07-12 21:06 ` Lars Magne Ingebrigtsen
2011-07-13 4:20 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-12 21:06 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: 4221
Dan Nicolaescu <dann@ics.uci.edu> writes:
> The patch below uses the high contrast "yellow" color for
> font-lock-comment-face on low color terminals using a dark background
> color.
> Yellow is not used by many other font-lock faces on such terminals.
>
> This will enable us to eliminate the need for the
> font-lock-comment-delimiter-face. (which the patch does not do, it just
> makes it identical to font-lock-comment-face, it will be done in an
> incremental patch).
That will make the delimiters the same colour as the comments. Is that
what we want?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#4221: improve font-lock-comment-face on dark background low color terminals
2011-07-12 21:06 ` Lars Magne Ingebrigtsen
@ 2011-07-13 4:20 ` Stefan Monnier
2011-07-13 15:33 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2011-07-13 4:20 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: Dan Nicolaescu, 4221
>> The patch below uses the high contrast "yellow" color for
>> font-lock-comment-face on low color terminals using a dark background
>> color.
>> Yellow is not used by many other font-lock faces on such terminals.
>>
>> This will enable us to eliminate the need for the
>> font-lock-comment-delimiter-face. (which the patch does not do, it just
>> makes it identical to font-lock-comment-face, it will be done in an
>> incremental patch).
> That will make the delimiters the same colour as the comments. Is that
> what we want?
I've always disliked the addition of font-lock-comment-delimiter-face,
so yes, I do want that.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#4221: improve font-lock-comment-face on dark background low color terminals
2011-07-13 4:20 ` Stefan Monnier
@ 2011-07-13 15:33 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-13 15:33 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Dan Nicolaescu, 4221
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I've always disliked the addition of font-lock-comment-delimiter-face,
> so yes, I do want that.
Ok; I've now applied the patch.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-13 15:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-21 4:30 bug#4221: improve font-lock-comment-face on dark background low color terminals Dan Nicolaescu
2011-07-12 21:06 ` Lars Magne Ingebrigtsen
2011-07-13 4:20 ` Stefan Monnier
2011-07-13 15:33 ` Lars Magne Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).