unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: bug-gnu-emacs@gnu.org
Subject: bug#4221: improve font-lock-comment-face on dark background low color terminals
Date: Thu, 20 Aug 2009 21:30:57 -0700 (PDT)	[thread overview]
Message-ID: <200908210430.n7L4Uvjq015595@godzilla.ics.uci.edu> (raw)


The patch below uses the high contrast "yellow" color for
font-lock-comment-face on low color terminals using a dark background
color.
Yellow is not used by many other font-lock faces on such terminals.

This will enable us to eliminate the need for the
font-lock-comment-delimiter-face. (which the patch does not do, it just
makes it identical to font-lock-comment-face, it will be done in an
incremental patch).


Index: lisp/font-lock.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/font-lock.el,v
retrieving revision 1.351
diff -u -3 -p -r1.351 font-lock.el
--- lisp/font-lock.el 2 Aug 2009 14:20:10 -0000 1.351
+++ lisp/font-lock.el 19 Aug 2009 05:15:42 -0000
@@ -1853,19 +1853,13 @@ Sets various variables using `font-lock-
     (((class color) (min-colors 8) (background light))
      (:foreground "red"))
     (((class color) (min-colors 8) (background dark))
-     )
+     (:foreground "yellow"))
     (t (:weight bold :slant italic)))
   "Font Lock mode face used to highlight comments."
   :group 'font-lock-faces)
 
 (defface font-lock-comment-delimiter-face
-  '((default :inherit font-lock-comment-face)
-    (((class grayscale)))
-    (((class color) (min-colors 16)))
-    (((class color) (min-colors 8) (background light))
-     :foreground "red")
-    (((class color) (min-colors 8) (background dark))
-     :foreground "red1"))
+  '((default :inherit font-lock-comment-face))
   "Font Lock mode face used to highlight comment delimiters."
   :group 'font-lock-faces)
 






             reply	other threads:[~2009-08-21  4:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-21  4:30 Dan Nicolaescu [this message]
2011-07-12 21:06 ` bug#4221: improve font-lock-comment-face on dark background low color terminals Lars Magne Ingebrigtsen
2011-07-13  4:20   ` Stefan Monnier
2011-07-13 15:33     ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908210430.n7L4Uvjq015595@godzilla.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=4221@emacsbugs.donarmstrong.com \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).