From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#4221: improve font-lock-comment-face on dark background low color terminals Date: Thu, 20 Aug 2009 21:30:57 -0700 (PDT) Message-ID: <200908210430.n7L4Uvjq015595@godzilla.ics.uci.edu> Reply-To: Dan Nicolaescu , 4221@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1250830036 4922 80.91.229.12 (21 Aug 2009 04:47:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Aug 2009 04:47:16 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 21 06:47:09 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MeM1s-0000Qr-Ps for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Aug 2009 06:47:09 +0200 Original-Received: from localhost ([127.0.0.1]:59966 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeM1r-0006BY-Rs for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Aug 2009 00:47:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeM1k-0006AU-Ur for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:47:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeM1f-000647-4f for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:46:59 -0400 Original-Received: from [199.232.76.173] (port=46864 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeM1e-00063s-Tb for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:46:54 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:57132) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MeM1d-00072S-Kv for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:46:54 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7L4kpQY010451; Thu, 20 Aug 2009 21:46:51 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7L4e5EU009528; Thu, 20 Aug 2009 21:40:05 -0700 Resent-Date: Thu, 20 Aug 2009 21:40:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 21 Aug 2009 04:40:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 4221 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12508291658554 (code B ref -1); Fri, 21 Aug 2009 04:40:05 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 21 Aug 2009 04:32:45 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7L4Whog008502 for ; Thu, 20 Aug 2009 21:32:44 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeLnv-0007rk-BF for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:32:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeLns-0007rY-0Y for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:32:43 -0400 Original-Received: from [199.232.76.173] (port=38785 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeLnr-0007rV-P5 for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:32:39 -0400 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:40369) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MeLnq-0004Tu-VI for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 00:32:39 -0400 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7L4Uvru006430 for ; Thu, 20 Aug 2009 21:30:57 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7L4Uvjq015595; Thu, 20 Aug 2009 21:30:57 -0700 (PDT) Original-Lines: 41 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7L4Uvru006430 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 21 Aug 2009 00:46:59 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30406 Archived-At: The patch below uses the high contrast "yellow" color for font-lock-comment-face on low color terminals using a dark background color. Yellow is not used by many other font-lock faces on such terminals. This will enable us to eliminate the need for the font-lock-comment-delimiter-face. (which the patch does not do, it just makes it identical to font-lock-comment-face, it will be done in an incremental patch). Index: lisp/font-lock.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/font-lock.el,v retrieving revision 1.351 diff -u -3 -p -r1.351 font-lock.el --- lisp/font-lock.el 2 Aug 2009 14:20:10 -0000 1.351 +++ lisp/font-lock.el 19 Aug 2009 05:15:42 -0000 @@ -1853,19 +1853,13 @@ Sets various variables using `font-lock- (((class color) (min-colors 8) (background light)) (:foreground "red")) (((class color) (min-colors 8) (background dark)) - ) + (:foreground "yellow")) (t (:weight bold :slant italic))) "Font Lock mode face used to highlight comments." :group 'font-lock-faces) (defface font-lock-comment-delimiter-face - '((default :inherit font-lock-comment-face) - (((class grayscale))) - (((class color) (min-colors 16))) - (((class color) (min-colors 8) (background light)) - :foreground "red") - (((class color) (min-colors 8) (background dark)) - :foreground "red1")) + '((default :inherit font-lock-comment-face)) "Font Lock mode face used to highlight comment delimiters." :group 'font-lock-faces)