From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4221: improve font-lock-comment-face on dark background low color terminals Date: Wed, 13 Jul 2011 00:20:54 -0400 Message-ID: References: <200908210430.n7L4Uvjq015595@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1310530945 4558 80.91.229.12 (13 Jul 2011 04:22:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2011 04:22:25 +0000 (UTC) Cc: Dan Nicolaescu , 4221@debbugs.gnu.org To: Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 13 06:22:20 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgqxo-0003YU-G7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jul 2011 06:22:20 +0200 Original-Received: from localhost ([::1]:41097 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qgqxn-00012F-Ln for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jul 2011 00:22:19 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:54596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgqxX-000126-7q for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 00:22:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QgqxW-0006Eb-9j for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 00:22:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgqxW-0006EN-2Q for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2011 00:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QgqxV-0001RJ-Ru; Wed, 13 Jul 2011 00:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2011 04:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4221 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 4221-submit@debbugs.gnu.org id=B4221.13105308665472 (code B ref 4221); Wed, 13 Jul 2011 04:22:01 +0000 Original-Received: (at 4221) by debbugs.gnu.org; 13 Jul 2011 04:21:06 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgqwa-0001QA-If for submit@debbugs.gnu.org; Wed, 13 Jul 2011 00:21:06 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgqwY-0001PX-Ey for 4221@debbugs.gnu.org; Wed, 13 Jul 2011 00:21:03 -0400 Original-Received: from cpe-66-108-39-217.nyc.res.rr.com ([66.108.39.217]:43113 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QgqwR-0002vX-7l; Wed, 13 Jul 2011 00:20:55 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 4FB96660D5; Wed, 13 Jul 2011 00:20:54 -0400 (EDT) In-Reply-To: (Lars Magne Ingebrigtsen's message of "Tue, 12 Jul 2011 23:06:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 13 Jul 2011 00:22:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:48824 Archived-At: >> The patch below uses the high contrast "yellow" color for >> font-lock-comment-face on low color terminals using a dark background >> color. >> Yellow is not used by many other font-lock faces on such terminals. >> >> This will enable us to eliminate the need for the >> font-lock-comment-delimiter-face. (which the patch does not do, it just >> makes it identical to font-lock-comment-face, it will be done in an >> incremental patch). > That will make the delimiters the same colour as the comments. Is that > what we want? I've always disliked the addition of font-lock-comment-delimiter-face, so yes, I do want that. Stefan