From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#3746: M-r in comint mode should use isearch Date: Wed, 8 Jul 2009 16:49:20 -0700 (PDT) Message-ID: <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> Reply-To: Dan Nicolaescu , 3746@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1247097467 4014 80.91.229.12 (8 Jul 2009 23:57:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Jul 2009 23:57:47 +0000 (UTC) Cc: 3746@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 09 01:57:40 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MOh19-0002K8-90 for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Jul 2009 01:57:39 +0200 Original-Received: from localhost ([127.0.0.1]:42923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOh18-0005iG-KT for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Jul 2009 19:57:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOh13-0005h7-HB for bug-gnu-emacs@gnu.org; Wed, 08 Jul 2009 19:57:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOh0z-0005df-Qu for bug-gnu-emacs@gnu.org; Wed, 08 Jul 2009 19:57:33 -0400 Original-Received: from [199.232.76.173] (port=57661 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOh0z-0005dT-HK for bug-gnu-emacs@gnu.org; Wed, 08 Jul 2009 19:57:29 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50649) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MOh0y-0001vH-T2 for bug-gnu-emacs@gnu.org; Wed, 08 Jul 2009 19:57:29 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n68NvQaq032715; Wed, 8 Jul 2009 16:57:27 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n68Nt6tU032121; Wed, 8 Jul 2009 16:55:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 08 Jul 2009 23:55:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124709697931269 (code B ref 3746); Wed, 08 Jul 2009 23:55:06 +0000 Original-Received: (at 3746) by emacsbugs.donarmstrong.com; 8 Jul 2009 23:49:39 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n68NnXsS031242 for <3746@emacsbugs.donarmstrong.com>; Wed, 8 Jul 2009 16:49:34 -0700 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n68NnKBF018364; Wed, 8 Jul 2009 16:49:20 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n68NnKRj025444; Wed, 8 Jul 2009 16:49:20 -0700 (PDT) In-Reply-To: <87skh8ynnm.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 08 Jul 2009 03:45:05 +0300") Original-Lines: 40 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n68NnKBF018364 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 08 Jul 2009 19:57:33 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:29268 Archived-At: Juri Linkov writes: > > > > The problem with that is that C-s (and C-r) already have bindings in > > > > comint modes, and changing them would not be liked by most users. > > > > Doing M-r and then C-s/C-r seems a bit cumbersome. > > > > IMHO just using M-r for incremental history search will provide no > > > > surprises for the user, and it seems like a natural extension of the > > > > current behavior. > > > > > > Currently M-r typed in the shell buffer activates the minibuffer with > > > the prompt "Previous input matching (regexp): ". I doubt that users > > > will like to see Isearch activated instead of this minibuffer. > > > > Why not? It does provide the same functionality and it seems easier to > > use. Maybe the prompt would need to be adjusted, but, IMHO, it's > > doubtful the users would be unpleasantly surprised by the behavior... > > M-r has a different UI. Its main difference that it is a non-incremental > regexp search unlike C-s that is an incremental string search. Is there any reason not to have an incremental search for M-r too? > Both bash and the Emacs minibuffer activate Isearch on C-s, so it > would be natural to do the same in shell buffers. We could try the > same context-dependent dwim approach used by the option of > `dired-isearch-filenames', i.e. "When point is on a file name > initially, search file names". So when point is on the shell prompt > then run Isearch on the shell history, otherwise run Isearch on the > shell buffer. That sounds fine, but it's not exclusive with M-r being an incremental search too. We are at the beginning of a release cycle, so we can experiment, if the users hate the change, there's enough time to change back. > What to do with the prompt is more difficult problem. Bash replaces the > shell prompt with the search prompt. Perhaps we should do the same. Agreed.