A small patch for org.el to fix error in clojure babel src block code ref

A small patch for org.el to fix error in clojure babel src block code ref

[numbchild]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Here is the original discussion we disscusses.
https://github.com/jkitchin/org-ref/issues/433

And Here is the patch:

#+BEGIN_SRC diff
modified   lisp/org.el
@@ -9730,7 +9730,7 @@ active region."
      (setq sfuns
    (delq
     nil (mapcar (lambda (f)
-  (let (fs) (if (funcall f) (push f fs))))
+  (let (fs) (if (and (stringp f) (funcall f)) (push f fs))))
  (org-store-link-functions)))
    sfunsn (mapcar (lambda (fu) (symbol-name (car fu))) sfuns))
      (or (and (cdr sfuns)
#+END_SRC

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

[-- Attachment #2: Type: text/html, Size: 3014 bytes --]

Re: A small patch for org.el to fix error in clojure babel src block code ref

[Nicolas Goaziou]

Hello,

"numbchild@gmail.com" <numbchild@gmail.com> writes:

> Here is the original discussion we disscusses.
> https://github.com/jkitchin/org-ref/issues/433
>
> And Here is the patch:
>
> #+BEGIN_SRC diff
> modified   lisp/org.el
> @@ -9730,7 +9730,7 @@ active region."
>       (setq sfuns
>     (delq
>      nil (mapcar (lambda (f)
> -  (let (fs) (if (funcall f) (push f fs))))
> +  (let (fs) (if (and (stringp f) (funcall f)) (push f fs))))
>   (org-store-link-functions)))

The change above doesn't make sense, does it?

If F is a string, it cannot be funcall'ed. Since
`org-store-link-functions' only contains functions, this patch is
basically skipping the whole variable.

Regards,

-- 
Nicolas Goaziou

Re: A small patch for org.el to fix error in clojure babel src block code ref

[numbchild]

[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]

Weird, but this patch does fixed my issue. When I `org-store-link` in
opened clojure babel src block will has this issue. But not in other
languages babel src blocks like Python, Ruby, C etc.

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

On Tue, May 9, 2017 at 2:41 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> "numbchild@gmail.com" <numbchild@gmail.com> writes:
>
> > Here is the original discussion we disscusses.
> > https://github.com/jkitchin/org-ref/issues/433
> >
> > And Here is the patch:
> >
> > #+BEGIN_SRC diff
> > modified   lisp/org.el
> > @@ -9730,7 +9730,7 @@ active region."
> >       (setq sfuns
> >     (delq
> >      nil (mapcar (lambda (f)
> > -  (let (fs) (if (funcall f) (push f fs))))
> > +  (let (fs) (if (and (stringp f) (funcall f)) (push f fs))))
> >   (org-store-link-functions)))
>
> The change above doesn't make sense, does it?
>
> If F is a string, it cannot be funcall'ed. Since
> `org-store-link-functions' only contains functions, this patch is
> basically skipping the whole variable.
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #2: Type: text/html, Size: 2361 bytes --]

Re: A small patch for org.el to fix error in clojure babel src block code ref

[numbchild]

[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]

​Is there any other possible potential functions will have relation with
this issue?​

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

On Tue, May 9, 2017 at 2:41 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> "numbchild@gmail.com" <numbchild@gmail.com> writes:
>
> > Here is the original discussion we disscusses.
> > https://github.com/jkitchin/org-ref/issues/433
> >
> > And Here is the patch:
> >
> > #+BEGIN_SRC diff
> > modified   lisp/org.el
> > @@ -9730,7 +9730,7 @@ active region."
> >       (setq sfuns
> >     (delq
> >      nil (mapcar (lambda (f)
> > -  (let (fs) (if (funcall f) (push f fs))))
> > +  (let (fs) (if (and (stringp f) (funcall f)) (push f fs))))
> >   (org-store-link-functions)))
>
> The change above doesn't make sense, does it?
>
> If F is a string, it cannot be funcall'ed. Since
> `org-store-link-functions' only contains functions, this patch is
> basically skipping the whole variable.
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #2: Type: text/html, Size: 2271 bytes --]

Re: A small patch for org.el to fix error in clojure babel src block code ref

[Nicolas Goaziou]

"numbchild@gmail.com" <numbchild@gmail.com> writes:

> ​Is there any other possible potential functions will have relation with
> this issue?​

According to the backtrace mentioned in the bug report, the culprit is
probably `org-label-store-link', which is probably one of the functions
returned by `org-store-link-functions'.

Since a consequence of your patch is to ignore all functions returned by
`org-store-link-functions', it "solves" the issue you're having, in
a way.

Anyway, there is no such function in Org code base, so you may want to
check where it is defined.

Regards,

Re: A small patch for org.el to fix error in clojure babel src block code ref

[John Kitchin]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

On Tue, May 9, 2017 at 6:51 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> org-store-link-functions


That is a function in org-ref. I will check it out this morning.  Thanks
for the pointer to the root of the issue!


John

-----------------------------------
Professor John Kitchin
Doherty Hall A207F
Department of Chemical Engineering
Carnegie Mellon University
Pittsburgh, PA 15213
412-268-7803
@johnkitchin
http://kitchingroup.cheme.cmu.edu

[-- Attachment #2: Type: text/html, Size: 1051 bytes --]

Re: A small patch for org.el to fix error in clojure babel src block code ref

[John Kitchin]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

I think I have just fixed it. The offending command was trying to get an
org-element in the special edit buffer which wasn't in org-mode. Its not
clear why it worked in some codes and not others though!

John

-----------------------------------
Professor John Kitchin
Doherty Hall A207F
Department of Chemical Engineering
Carnegie Mellon University
Pittsburgh, PA 15213
412-268-7803
@johnkitchin
http://kitchingroup.cheme.cmu.edu


On Tue, May 9, 2017 at 7:01 AM, John Kitchin <jkitchin@andrew.cmu.edu>
wrote:

>
> On Tue, May 9, 2017 at 6:51 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
> wrote:
>
>> org-store-link-functions
>
>
> That is a function in org-ref. I will check it out this morning.  Thanks
> for the pointer to the root of the issue!
>
>
> John
>
> -----------------------------------
> Professor John Kitchin
> Doherty Hall A207F
> Department of Chemical Engineering
> Carnegie Mellon University
> Pittsburgh, PA 15213
> 412-268-7803 <(412)%20268-7803>
> @johnkitchin
> http://kitchingroup.cheme.cmu.edu
>
>

[-- Attachment #2: Type: text/html, Size: 2236 bytes --]

Re: A small patch for org.el to fix error in clojure babel src block code ref

[numbchild]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

Thanks for fixing, John.

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

On Tue, May 9, 2017 at 7:14 PM, John Kitchin <jkitchin@andrew.cmu.edu>
wrote:

> I think I have just fixed it. The offending command was trying to get an
> org-element in the special edit buffer which wasn't in org-mode. Its not
> clear why it worked in some codes and not others though!
>
> John
>
> -----------------------------------
> Professor John Kitchin
> Doherty Hall A207F
> Department of Chemical Engineering
> Carnegie Mellon University
> Pittsburgh, PA 15213
> 412-268-7803 <(412)%20268-7803>
> @johnkitchin
> http://kitchingroup.cheme.cmu.edu
>
>
> On Tue, May 9, 2017 at 7:01 AM, John Kitchin <jkitchin@andrew.cmu.edu>
> wrote:
>
>>
>> On Tue, May 9, 2017 at 6:51 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> wrote:
>>
>>> org-store-link-functions
>>
>>
>> That is a function in org-ref. I will check it out this morning.  Thanks
>> for the pointer to the root of the issue!
>>
>>
>> John
>>
>> -----------------------------------
>> Professor John Kitchin
>> Doherty Hall A207F
>> Department of Chemical Engineering
>> Carnegie Mellon University
>> Pittsburgh, PA 15213
>> 412-268-7803 <(412)%20268-7803>
>> @johnkitchin
>> http://kitchingroup.cheme.cmu.edu
>>
>>
>

[-- Attachment #2: Type: text/html, Size: 3402 bytes --]