From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "numbchild@gmail.com" <numbchild@gmail.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: A small patch for org.el to fix error in clojure babel src block code ref
Date: Tue, 09 May 2017 08:41:55 +0200 [thread overview]
Message-ID: <877f1q5y6k.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAL1eYu+xNd0N6Vtjesmsja7CUTc3FSGLUS6uQ5xaPUbOGbdhpw@mail.gmail.com> (numbchild@gmail.com's message of "Tue, 9 May 2017 09:21:20 +0800")
Hello,
"numbchild@gmail.com" <numbchild@gmail.com> writes:
> Here is the original discussion we disscusses.
> https://github.com/jkitchin/org-ref/issues/433
>
> And Here is the patch:
>
> #+BEGIN_SRC diff
> modified lisp/org.el
> @@ -9730,7 +9730,7 @@ active region."
> (setq sfuns
> (delq
> nil (mapcar (lambda (f)
> - (let (fs) (if (funcall f) (push f fs))))
> + (let (fs) (if (and (stringp f) (funcall f)) (push f fs))))
> (org-store-link-functions)))
The change above doesn't make sense, does it?
If F is a string, it cannot be funcall'ed. Since
`org-store-link-functions' only contains functions, this patch is
basically skipping the whole variable.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-05-09 6:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 1:21 A small patch for org.el to fix error in clojure babel src block code ref numbchild
2017-05-09 6:41 ` Nicolas Goaziou [this message]
2017-05-09 8:06 ` numbchild
2017-05-09 8:07 ` numbchild
2017-05-09 10:51 ` Nicolas Goaziou
2017-05-09 11:01 ` John Kitchin
2017-05-09 11:14 ` John Kitchin
2017-05-10 2:01 ` numbchild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f1q5y6k.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).