From: "numbchild@gmail.com" <numbchild@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: A small patch for org.el to fix error in clojure babel src block code ref
Date: Tue, 9 May 2017 16:07:58 +0800 [thread overview]
Message-ID: <CAL1eYuLC=S9kuAZ7zs75ZN1WmGAWg+xp1ddv8aYFP-PnS-+YiA@mail.gmail.com> (raw)
In-Reply-To: <877f1q5y6k.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
Is there any other possible potential functions will have relation with
this issue?
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Tue, May 9, 2017 at 2:41 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Hello,
>
> "numbchild@gmail.com" <numbchild@gmail.com> writes:
>
> > Here is the original discussion we disscusses.
> > https://github.com/jkitchin/org-ref/issues/433
> >
> > And Here is the patch:
> >
> > #+BEGIN_SRC diff
> > modified lisp/org.el
> > @@ -9730,7 +9730,7 @@ active region."
> > (setq sfuns
> > (delq
> > nil (mapcar (lambda (f)
> > - (let (fs) (if (funcall f) (push f fs))))
> > + (let (fs) (if (and (stringp f) (funcall f)) (push f fs))))
> > (org-store-link-functions)))
>
> The change above doesn't make sense, does it?
>
> If F is a string, it cannot be funcall'ed. Since
> `org-store-link-functions' only contains functions, this patch is
> basically skipping the whole variable.
>
> Regards,
>
> --
> Nicolas Goaziou
>
[-- Attachment #2: Type: text/html, Size: 2271 bytes --]
next prev parent reply other threads:[~2017-05-09 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 1:21 A small patch for org.el to fix error in clojure babel src block code ref numbchild
2017-05-09 6:41 ` Nicolas Goaziou
2017-05-09 8:06 ` numbchild
2017-05-09 8:07 ` numbchild [this message]
2017-05-09 10:51 ` Nicolas Goaziou
2017-05-09 11:01 ` John Kitchin
2017-05-09 11:14 ` John Kitchin
2017-05-10 2:01 ` numbchild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1eYuLC=S9kuAZ7zs75ZN1WmGAWg+xp1ddv8aYFP-PnS-+YiA@mail.gmail.com' \
--to=numbchild@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).