From: Tomi Ollila <tomi.ollila@iki.fi>
To: Blake Jones <blakej@foo.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 05/10] install: check for non-SysV version (Solaris support)
Date: Tue, 06 Nov 2012 18:51:43 +0200 [thread overview]
Message-ID: <m2vcdiznc0.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1352142123-18286-6-git-send-email-blakej@foo.net>
On Mon, Nov 05 2012, Blake Jones <blakej@foo.net> wrote:
Some quick comments, haven't got time to test yet.
// stuff deleted //
> diff --git a/vim/Makefile b/vim/Makefile
> index f17bebf..7ceba7a 100644
> --- a/vim/Makefile
> +++ b/vim/Makefile
> @@ -5,8 +5,6 @@ files = plugin/notmuch.vim \
> prefix = $(HOME)/.vim
> destdir = $(prefix)/plugin
>
> -INSTALL = install -D -m644
> -
> all: help
>
> help:
> @@ -17,7 +15,7 @@ help:
> @echo " make symlink - create symlinks in ~/.vim (useful for development)"
>
> install:
> - @for x in $(files); do $(INSTALL) $(CURDIR)/$$x $(prefix)/$$x; done
> + @for x in $(files); do $(INSTALL) -D -m644 $(CURDIR)/$$x $(prefix)/$$x; done
>
> -link symlink: INSTALL = ln -fs
> link symlink: install
> + @for x in $(files); do ln -fs $(CURDIR)/$$x $(prefix)/$$x; done
> --
Here you'd need to remove the 'install' dependency as it would first
do it and then overwriting the results with dependency..
another option is to use other variable like
__INSTALL = $(INSTALL) -D -m644
and then replace other uses of INSTALL with __INSTALL
(this doesn't look too good but that was what I could come
quickly)
> 1.7.3.2
Tomi
next prev parent reply other threads:[~2012-11-06 16:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 19:01 [PATCH v2 00/10] Solaris support Blake Jones
2012-11-05 19:01 ` [PATCH v2 01/10] getpwuid: check for standards compliance (Solaris support) Blake Jones
2012-11-05 19:01 ` [PATCH v2 02/10] asctime: " Blake Jones
2012-11-05 19:01 ` [PATCH v2 03/10] gethostbyname: check for libnsl " Blake Jones
2012-11-05 19:01 ` [PATCH v2 04/10] configure: check for -Wl,-rpath " Blake Jones
2012-11-05 19:01 ` [PATCH v2 05/10] install: check for non-SysV version " Blake Jones
2012-11-06 16:51 ` Tomi Ollila [this message]
2012-11-08 6:22 ` Blake Jones
2012-11-05 19:01 ` [PATCH v2 06/10] strsep: check for availability " Blake Jones
2012-11-05 19:02 ` [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output " Blake Jones
2012-11-06 16:58 ` Tomi Ollila
2012-11-08 6:29 ` Blake Jones
2012-11-08 8:55 ` Tomi Ollila
2012-11-08 15:40 ` Blake Jones
2012-11-05 19:02 ` [PATCH v2 08/10] notmuch-config: use strchr(), not index() " Blake Jones
2012-11-05 19:02 ` [PATCH v2 09/10] debugger.c: correct return type from getppid() " Blake Jones
2012-11-05 19:02 ` [PATCH v2 10/10] timegm: add portable implementation " Blake Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vcdiznc0.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=blakej@foo.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).