From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1B51D431FBC for ; Tue, 6 Nov 2012 08:51:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sieaIR7mnlKH for ; Tue, 6 Nov 2012 08:51:44 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 45BF2431FB6 for ; Tue, 6 Nov 2012 08:51:44 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 8ADB5100094; Tue, 6 Nov 2012 18:51:43 +0200 (EET) From: Tomi Ollila To: Blake Jones , notmuch@notmuchmail.org Subject: Re: [PATCH v2 05/10] install: check for non-SysV version (Solaris support) In-Reply-To: <1352142123-18286-6-git-send-email-blakej@foo.net> References: <1352142123-18286-1-git-send-email-blakej@foo.net> <1352142123-18286-6-git-send-email-blakej@foo.net> User-Agent: Notmuch/0.14+81~gb8371cd (http://notmuchmail.org) Emacs/24.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2012 16:51:45 -0000 On Mon, Nov 05 2012, Blake Jones wrote: Some quick comments, haven't got time to test yet. // stuff deleted // > diff --git a/vim/Makefile b/vim/Makefile > index f17bebf..7ceba7a 100644 > --- a/vim/Makefile > +++ b/vim/Makefile > @@ -5,8 +5,6 @@ files = plugin/notmuch.vim \ > prefix = $(HOME)/.vim > destdir = $(prefix)/plugin > > -INSTALL = install -D -m644 > - > all: help > > help: > @@ -17,7 +15,7 @@ help: > @echo " make symlink - create symlinks in ~/.vim (useful for development)" > > install: > - @for x in $(files); do $(INSTALL) $(CURDIR)/$$x $(prefix)/$$x; done > + @for x in $(files); do $(INSTALL) -D -m644 $(CURDIR)/$$x $(prefix)/$$x; done > > -link symlink: INSTALL = ln -fs > link symlink: install > + @for x in $(files); do ln -fs $(CURDIR)/$$x $(prefix)/$$x; done > -- Here you'd need to remove the 'install' dependency as it would first do it and then overwriting the results with dependency.. another option is to use other variable like __INSTALL = $(INSTALL) -D -m644 and then replace other uses of INSTALL with __INSTALL (this doesn't look too good but that was what I could come quickly) > 1.7.3.2 Tomi