From: Tomi Ollila <tomi.ollila@iki.fi>
To: Blake Jones <blakej@foo.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)
Date: Thu, 08 Nov 2012 10:55:36 +0200 [thread overview]
Message-ID: <m2bof8fp87.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <24582.1352356152@foo.net>
On Thu, Nov 08 2012, Blake Jones <blakej@foo.net> wrote:
>>> @@ -11,10 +12,44 @@ fi
>>> HEADER=$1
>>> shift
>>>
>>> +if [ `uname -s` == SunOS ] ; then
>>> + #
>>> + # Using Solaris "nm", a defined symbol looks like this:
>>> + #
>>
>> The POSIX / Bourne -comformant equality comparison is '='.
>
> Sigh, of course it is. Fixed.
>
>> e.g.
>>
>> $ ./heirloom-sh/sh -c ' [ a == b ] || echo x'
>> ./heirloom-sh/sh: test: unknown operator ==
>> zsh: exit 1 ./heirloom-sh/sh -c ' [ a == b ] || echo x'
>>
>> Interesting that Solaris /bin/sh did not fail there...
>
> I was running on Solaris 11.1, which uses ksh93 as its /bin/sh. You're
> absolutely right that Solaris 10 would fall over, though.
>
> Similarly, the following line:
>
> demangled=$(demangle $sym)
>
> doesn't work on traditional sh. I've replaced $() with ``.
>
>> Hmm, gen-version-script doesn't have shebang... it is run like:
>>
>> sh $(srcdir)/$(lib)/gen-version-script.sh $< $(libnotmuch_modules) > $@
>>
>> in lib/Makefile.local -- taking sh fron PATH.
>
> I updated the first line from the #! invocation to a comment saying
>
> # This script is invoked via "sh .../gen-version-script.sh".
looks good
> Would a respun version of these patches help toward testing?
$ grep vim test/*
zsh: exit 1 grep vim test/*
i.e. no vim tests...
Also, as *I* will execute my tests in Linux these won't make things
fail -- and probably no-one else eager to test won't have problems
either
So I think these patches are good until someone(tm) finds other
issues (if any),
> Blake
Tomi
next prev parent reply other threads:[~2012-11-08 8:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 19:01 [PATCH v2 00/10] Solaris support Blake Jones
2012-11-05 19:01 ` [PATCH v2 01/10] getpwuid: check for standards compliance (Solaris support) Blake Jones
2012-11-05 19:01 ` [PATCH v2 02/10] asctime: " Blake Jones
2012-11-05 19:01 ` [PATCH v2 03/10] gethostbyname: check for libnsl " Blake Jones
2012-11-05 19:01 ` [PATCH v2 04/10] configure: check for -Wl,-rpath " Blake Jones
2012-11-05 19:01 ` [PATCH v2 05/10] install: check for non-SysV version " Blake Jones
2012-11-06 16:51 ` Tomi Ollila
2012-11-08 6:22 ` Blake Jones
2012-11-05 19:01 ` [PATCH v2 06/10] strsep: check for availability " Blake Jones
2012-11-05 19:02 ` [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output " Blake Jones
2012-11-06 16:58 ` Tomi Ollila
2012-11-08 6:29 ` Blake Jones
2012-11-08 8:55 ` Tomi Ollila [this message]
2012-11-08 15:40 ` Blake Jones
2012-11-05 19:02 ` [PATCH v2 08/10] notmuch-config: use strchr(), not index() " Blake Jones
2012-11-05 19:02 ` [PATCH v2 09/10] debugger.c: correct return type from getppid() " Blake Jones
2012-11-05 19:02 ` [PATCH v2 10/10] timegm: add portable implementation " Blake Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bof8fp87.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=blakej@foo.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).