unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Blake Jones <blakej@foo.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)
Date: Tue, 06 Nov 2012 18:58:50 +0200	[thread overview]
Message-ID: <m2sj8mzn05.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1352142123-18286-8-git-send-email-blakej@foo.net>

On Mon, Nov 05 2012, Blake Jones <blakej@foo.net> wrote:

> The output of "nm" on Solaris is substantially different from that on
> Linux, and the current version of gen-version-script is tied to the
> Linux "nm" output.  This patch separates the parts of "nm" processing
> which are dependent on the output format into a couple shell functions,
> and makes another shell function to use the appropriate version of
> "c++filt" to demangle symbols.  It also modifies lib/Makefile.local
> to pass the generated symbol table correctly to the Solaris linker.


// stuff deleted

> index 76670d5..d7d96da 100644
> --- a/lib/gen-version-script.sh
> +++ b/lib/gen-version-script.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
>  
>  # we go through a bit of work to get the unmangled names of the
>  # typeinfo symbols because of
> @@ -11,10 +12,44 @@ fi
>  HEADER=$1
>  shift
>  
> +if [ `uname -s` == SunOS ] ; then
> +    #
> +    # Using Solaris "nm", a defined symbol looks like this:
> +    #

The POSIX / Bourne -comformant equality comparison is '='. 

e.g.

$ ./heirloom-sh/sh -c ' [ a == b ] || echo x'
./heirloom-sh/sh: test: unknown operator ==
zsh: exit 1     ./heirloom-sh/sh -c ' [ a == b ] || echo x'

Interesting that Solaris /bin/sh did not fail there...

Hmm, gen-version-script doesn't have shebang... it is run like:

sh $(srcdir)/$(lib)/gen-version-script.sh $< $(libnotmuch_modules) > $@

in lib/Makefile.local -- taking sh fron PATH.


Tomi

  reply	other threads:[~2012-11-06 16:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-05 19:01 [PATCH v2 00/10] Solaris support Blake Jones
2012-11-05 19:01 ` [PATCH v2 01/10] getpwuid: check for standards compliance (Solaris support) Blake Jones
2012-11-05 19:01 ` [PATCH v2 02/10] asctime: " Blake Jones
2012-11-05 19:01 ` [PATCH v2 03/10] gethostbyname: check for libnsl " Blake Jones
2012-11-05 19:01 ` [PATCH v2 04/10] configure: check for -Wl,-rpath " Blake Jones
2012-11-05 19:01 ` [PATCH v2 05/10] install: check for non-SysV version " Blake Jones
2012-11-06 16:51   ` Tomi Ollila
2012-11-08  6:22     ` Blake Jones
2012-11-05 19:01 ` [PATCH v2 06/10] strsep: check for availability " Blake Jones
2012-11-05 19:02 ` [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output " Blake Jones
2012-11-06 16:58   ` Tomi Ollila [this message]
2012-11-08  6:29     ` Blake Jones
2012-11-08  8:55       ` Tomi Ollila
2012-11-08 15:40         ` Blake Jones
2012-11-05 19:02 ` [PATCH v2 08/10] notmuch-config: use strchr(), not index() " Blake Jones
2012-11-05 19:02 ` [PATCH v2 09/10] debugger.c: correct return type from getppid() " Blake Jones
2012-11-05 19:02 ` [PATCH v2 10/10] timegm: add portable implementation " Blake Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2sj8mzn05.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=blakej@foo.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).