From: Tomi Ollila <tomi.ollila@iki.fi>
To: Blake Jones <blakej@foo.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v3 00/10] Solaris support
Date: Fri, 16 Nov 2012 08:59:11 +0200 [thread overview]
Message-ID: <m24nkqm3sw.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <15993.1353004975@foo.net>
On Thu, Nov 15 2012, Blake Jones <blakej@foo.net> wrote:
>> $ gcc compat/have_strsep.c
>> compat/have_strsep.c: In function "main":
>> compat/have_strsep.c:7:21: error: expected identifier or "(" before "const"
>> compat/have_strsep.c:9:29: error: "delim" undeclared (first use in this function)
>> compat/have_strsep.c:9:29: note: each undeclared identifier is reported only once for each function it appears in
>> zsh: exit 1 gcc compat/have_strsep.c
>>
>> --- It is very easy to spot the problem ;)
>
> Sigh, yes it is. I started my Solaris port using some patches from
> someone else who had done previous work on a Solaris port, and obviously
> I didn't look at the patch very closely. In fact, after fixing
> have_strsep.c, I saw that I didn't even need it -- Solaris 11 has
> strsep() in libc. But I'd prefer to clean up this patch and leave the
> compat version available for those compiling on older versions of
> Solaris, if that's okay.
It sure is okay -- the missing strsep() issue has been there before.
>> $ gcc compat/check_asctime.c
>> compat/check_asctime.c: In function "main":
>> compat/check_asctime.c:15:5: error: too many arguments to function "asctime_r"
>> In file included from compat/check_asctime.c:8:0:
>> /usr/include/time.h:266:14: note: declared here
>> zsh: exit 1 gcc compat/check_asctime.c
>>
>> --- the posix-semantics way uses the 2-arg format.
>>
>> The logic of the test setting in this file doesn't open to
>> me. Why not test the same way as in getpwuid_r() case ?
>
> Yeah, that's clearly the right thing to do. I was getting odd behavior
> when I defined _POSIX_PTHREAD_SEMANTICS for getpwuid_r(), and it looks
> like I fixed it in the wrong direction.
>
> Did you happen to notice any other issues besides these two? I'd rather
> not spam the list with my ten-patch set if there's other silly stuff
> that needs cleaning up.
Nope, just those 2 :)
>
> Thanks again for testing this.
>
> Blake
Tomi
prev parent reply other threads:[~2012-11-16 6:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 2:09 [PATCH v3 00/10] Solaris support Blake Jones
2012-11-14 2:09 ` [PATCH v3 01/10] getpwuid: check for standards compliance (Solaris support) Blake Jones
2012-11-14 2:09 ` [PATCH v3 02/10] asctime: " Blake Jones
2012-11-14 2:09 ` [PATCH v3 03/10] gethostbyname: check for libnsl " Blake Jones
2012-11-14 2:09 ` [PATCH v3 04/10] configure: check for -Wl,-rpath " Blake Jones
2012-11-14 2:10 ` [PATCH v3 05/10] install: check for non-SysV version " Blake Jones
2012-11-14 2:10 ` [PATCH v3 06/10] strsep: check for availability " Blake Jones
2012-11-14 2:10 ` [PATCH v3 07/10] gen-version-script: parse Solaris "nm" output " Blake Jones
2012-11-14 2:10 ` [PATCH v3 08/10] notmuch-config: use strchr(), not index() " Blake Jones
2013-08-24 9:41 ` David Bremner
2012-11-14 2:10 ` [PATCH v3 09/10] debugger.c: correct return type from getppid() " Blake Jones
2012-11-14 2:10 ` [PATCH v3 10/10] timegm: add portable implementation " Blake Jones
2012-11-15 15:55 ` [PATCH v3 00/10] Solaris support Tomi Ollila
2012-11-15 18:42 ` Blake Jones
2012-11-16 6:59 ` Tomi Ollila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24nkqm3sw.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=blakej@foo.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).