unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Blake Jones <blakej@foo.net>
To: notmuch@notmuchmail.org
Subject: [PATCH v3 08/10] notmuch-config: use strchr(), not index() (Solaris support)
Date: Tue, 13 Nov 2012 18:10:03 -0800	[thread overview]
Message-ID: <1352859005-18631-9-git-send-email-blakej@foo.net> (raw)
In-Reply-To: <1352859005-18631-1-git-send-email-blakej@foo.net>

notmuch-config.c has the only use of the function named "index()" in the
notmuch source.  Several other places use the equivalent function
"strchr()"; this patch just fixes notmuch-config.c to use strchr()
instead.  (Solaris needs to include <strings.h> to get the prototype for
index(), and notmuch-config.c was failing to include that header, so it
wasn't compiling as-is.)
---
 notmuch-config.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/notmuch-config.c b/notmuch-config.c
index 3e37a2d..47eb743 100644
--- a/notmuch-config.c
+++ b/notmuch-config.c
@@ -688,7 +688,7 @@ _item_split (char *item, char **group, char **key)
 
     *group = item;
 
-    period = index (item, '.');
+    period = strchr (item, '.');
     if (period == NULL || *(period+1) == '\0') {
 	fprintf (stderr,
 		 "Invalid configuration name: %s\n"
-- 
1.7.3.2

  parent reply	other threads:[~2012-11-14  2:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14  2:09 [PATCH v3 00/10] Solaris support Blake Jones
2012-11-14  2:09 ` [PATCH v3 01/10] getpwuid: check for standards compliance (Solaris support) Blake Jones
2012-11-14  2:09 ` [PATCH v3 02/10] asctime: " Blake Jones
2012-11-14  2:09 ` [PATCH v3 03/10] gethostbyname: check for libnsl " Blake Jones
2012-11-14  2:09 ` [PATCH v3 04/10] configure: check for -Wl,-rpath " Blake Jones
2012-11-14  2:10 ` [PATCH v3 05/10] install: check for non-SysV version " Blake Jones
2012-11-14  2:10 ` [PATCH v3 06/10] strsep: check for availability " Blake Jones
2012-11-14  2:10 ` [PATCH v3 07/10] gen-version-script: parse Solaris "nm" output " Blake Jones
2012-11-14  2:10 ` Blake Jones [this message]
2013-08-24  9:41   ` [PATCH v3 08/10] notmuch-config: use strchr(), not index() " David Bremner
2012-11-14  2:10 ` [PATCH v3 09/10] debugger.c: correct return type from getppid() " Blake Jones
2012-11-14  2:10 ` [PATCH v3 10/10] timegm: add portable implementation " Blake Jones
2012-11-15 15:55 ` [PATCH v3 00/10] Solaris support Tomi Ollila
2012-11-15 18:42   ` Blake Jones
2012-11-16  6:59     ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352859005-18631-9-git-send-email-blakej@foo.net \
    --to=blakej@foo.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).