From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 879B7431FAF for ; Thu, 15 Nov 2012 22:59:15 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nfHpUGjw5x+r for ; Thu, 15 Nov 2012 22:59:14 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 02D02431FAE for ; Thu, 15 Nov 2012 22:59:13 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id D524A1000E2; Fri, 16 Nov 2012 08:59:11 +0200 (EET) From: Tomi Ollila To: Blake Jones Subject: Re: [PATCH v3 00/10] Solaris support In-Reply-To: <15993.1353004975@foo.net> References: <15993.1353004975@foo.net> User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2012 06:59:15 -0000 On Thu, Nov 15 2012, Blake Jones wrote: >> $ gcc compat/have_strsep.c >> compat/have_strsep.c: In function "main": >> compat/have_strsep.c:7:21: error: expected identifier or "(" before "const" >> compat/have_strsep.c:9:29: error: "delim" undeclared (first use in this function) >> compat/have_strsep.c:9:29: note: each undeclared identifier is reported only once for each function it appears in >> zsh: exit 1 gcc compat/have_strsep.c >> >> --- It is very easy to spot the problem ;) > > Sigh, yes it is. I started my Solaris port using some patches from > someone else who had done previous work on a Solaris port, and obviously > I didn't look at the patch very closely. In fact, after fixing > have_strsep.c, I saw that I didn't even need it -- Solaris 11 has > strsep() in libc. But I'd prefer to clean up this patch and leave the > compat version available for those compiling on older versions of > Solaris, if that's okay. It sure is okay -- the missing strsep() issue has been there before. >> $ gcc compat/check_asctime.c >> compat/check_asctime.c: In function "main": >> compat/check_asctime.c:15:5: error: too many arguments to function "asctime_r" >> In file included from compat/check_asctime.c:8:0: >> /usr/include/time.h:266:14: note: declared here >> zsh: exit 1 gcc compat/check_asctime.c >> >> --- the posix-semantics way uses the 2-arg format. >> >> The logic of the test setting in this file doesn't open to >> me. Why not test the same way as in getpwuid_r() case ? > > Yeah, that's clearly the right thing to do. I was getting odd behavior > when I defined _POSIX_PTHREAD_SEMANTICS for getpwuid_r(), and it looks > like I fixed it in the wrong direction. > > Did you happen to notice any other issues besides these two? I'd rather > not spam the list with my ten-patch set if there's other silly stuff > that needs cleaning up. Nope, just those 2 :) > > Thanks again for testing this. > > Blake Tomi