From: Tomi Ollila <tomi.ollila@iki.fi>
To: Michael J Gruber <git@grubix.eu>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/4] test: set up the outcount file for T380.1
Date: Thu, 10 Feb 2022 19:29:06 +0200 [thread overview]
Message-ID: <m24k56y6jh.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <164448800145.6325.10970593977371856162.git@grubix.eu>
On Thu, Feb 10 2022, Michael J. Gruber wrote:
> Tomi Ollila venit, vidit, dixit 2022-02-09 21:50:35:
>> On Wed, Feb 09 2022, Michael J. Gruber wrote:
>>
>> > If gdb is present but for some reason `atomicity.py` fails to write to
>> > the output file then the test fails with some ugly bash errors in the
>> > wrong places (because the outcount variable is empty).
>> >
>> > Therefore, set up the outcount file with `0` to get the test script to
>> > rund and the test to fail fpr a clearer reason.
>> >
>> > Background: We noticed this with arch armhfp emulated on x86_64 in
>> > Fedora's COPR test build environment.
>> >
>> > Signed-off-by: Michael J Gruber <git@grubix.eu>
>> > ---
>> > test/T380-atomicity.sh | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh
>> > index 49df5c38..caac28a3 100755
>> > --- a/test/T380-atomicity.sh
>> > +++ b/test/T380-atomicity.sh
>> > @@ -64,6 +64,7 @@ if test_require_external_prereq gdb; then
>> > # -tty /dev/null works around a conflict between the 'timeout' wrapper
>> > # and gdb's attempt to control the TTY.
>> > export MAIL_DIR
>> > + echo -n 0 > outcount
>>
>> printf 0 > outcount (is my suggestion)
>
> Would by mine, too :)
> Again, this is not the style of T380 which uses echo exclusively so far.
Right, I did not see the surrouding code in this series :D
(the only thing I saw use of $(expr ...) -- which I put to my notes of
trivial fixes one could do in (distant?) future)
Perhaps the series is good then (and perhaps incremental changing of
expected - actual order is better than newer changing any of those)
Tomi
next prev parent reply other threads:[~2022-02-10 17:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 11:52 [PATCH 0/4] test: T380 rework Michael J Gruber
2022-02-09 11:52 ` [PATCH 1/4] test: correct comparison order in T380 Michael J Gruber
2022-02-09 20:47 ` Tomi Ollila
2022-02-10 10:05 ` Michael J Gruber
2022-02-09 11:52 ` [PATCH 2/4] test: due not pass T380.1 for the wrong reasons Michael J Gruber
2022-02-09 20:49 ` Tomi Ollila
2022-02-10 10:08 ` Michael J Gruber
2022-02-09 22:12 ` David Bremner
2022-02-10 10:56 ` Michael J Gruber
2022-02-12 20:42 ` David Bremner
2022-02-19 21:50 ` Tomi Ollila
2022-02-19 23:02 ` David Bremner
2022-02-20 10:58 ` Michael J Gruber
2022-02-20 12:58 ` David Bremner
2022-02-09 11:52 ` [PATCH 3/4] test: reword T380.2 to be clearer Michael J Gruber
2022-02-09 20:49 ` Tomi Ollila
2022-02-09 11:52 ` [PATCH 4/4] test: set up the outcount file for T380.1 Michael J Gruber
2022-02-09 20:50 ` Tomi Ollila
2022-02-10 10:13 ` Michael J Gruber
2022-02-10 17:29 ` Tomi Ollila [this message]
2023-11-24 17:05 ` [PATCH 0/4] test: T380 rework Michael J Gruber
2023-11-24 22:20 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24k56y6jh.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=git@grubix.eu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).