From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OMTYJWtLBWJMcwAAgWs5BA (envelope-from ) for ; Thu, 10 Feb 2022 18:29:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id EDZqImtLBWKmSAEAauVa8A (envelope-from ) for ; Thu, 10 Feb 2022 18:29:15 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B3E3227787 for ; Thu, 10 Feb 2022 18:29:14 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id F39335F716; Thu, 10 Feb 2022 17:29:11 +0000 (UTC) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 5E1D45F402 for ; Thu, 10 Feb 2022 17:29:09 +0000 (UTC) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 2B6D61B002A8; Thu, 10 Feb 2022 19:29:08 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1644514148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oK3PdFJ8ygTxjTteoHEjh7Gdgqydt2IeaYrxJNGfFEk=; b=dEqBQE3et50jL/49DJZZJWKuhE6GUd8XT9oGs+WRR2uyqLn5ff59Kvg9mpAXSw6TbPP9DT QTmq2+si+PHUv54Go5QSr+6WidHQLi+yq4fz/0svjYgC8LuaC1yONpi53nRcMSLLznSr4H 7TgFQKM3qKI+9ga1ZeBvknubMbu8Vu/Du7BLr8eSqkGCaBHCKbQsU0m3NSXjQOUNSnJB07 1lZrndZM+Q6TI7C2l6cxlek3k6gbRjjumR/UJ9Zp+J6iFLUzI+T/sp5siRO2BuQK179Y5Q en6GfG4vSGpn/NI1eY3rjccT5SoHMO9OxPxiIanpGNnjm6+GUrM06qkCcNW+mQ== From: Tomi Ollila To: Michael J Gruber , notmuch@notmuchmail.org Subject: Re: [PATCH 4/4] test: set up the outcount file for T380.1 In-Reply-To: <164448800145.6325.10970593977371856162.git@grubix.eu> References: <0ccbe5428179bdf550d13ac715db70e78fc9a7c4.1644406756.git.git@grubix.eu> <164448800145.6325.10970593977371856162.git@grubix.eu> User-Agent: Notmuch/0.35+4~ge2bb4cd (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1644514148; a=rsa-sha256; cv=none; b=PS311SAS6uVUvDuvv7uRJHi3VcSmutYSJdVdxEZo1M/5bt4mUkppJw1IxgDKahGnH8aBVs 03/hQRJXJmncFupO13JvYTCN+nmPLGtw2tMNigFG+KnYj7sY3sRPoZgV2SaqoXJUa5JP3x 6GTqqGacp/5jdk3u2hP6TbU5RafhyLvzskYQk4zOXLGHyeS23fnV1imsj7+9yFtmSzZ5NT A0L5H2xQeG8UiCUGdNshV66pCldEwPnlIXhqbb/2/0IU5t0WgUPaX8p3OWiqdFSQygtwCs a1EP1umt/hwNM3PnAkUnEUPI9OQjKVh/V3r/s6jK3zzYPnZshaHNJucaFfbFFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1644514148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oK3PdFJ8ygTxjTteoHEjh7Gdgqydt2IeaYrxJNGfFEk=; b=no2ajNagBI9lXXfOK1YYw9Cuj3AzOxkSUlZVC7XMfLydjaA7h0lxRquZP3tNCJcnF4KQ9p z1BcTjLnTnckNRknP/95bex2dehOZLNB1SsnNea7+tcGy5QX+KzwVX4zdB/y5r/X3uc96W Oz6TZVaC/iRlryujrq/66uOGScSWNgmsMfNgFJICcVp3PkUB6e/zXoimK41Pergp2S77Ul AufV3m6haR0rm0cV4QefYc7lfDV0ASfinIb0MIlbMYYYWgHKIj6zptH2wyqEX9uPpnJjtt m6LJnYjm+TyXPhWcADS02NGK3/+etwlHezWck/v66hQWMd7S6lga8N6NWDRAyA== Message-ID-Hash: VW37QGRAUI5FBZELMVSHNN7PNOFWT4Q7 X-Message-ID-Hash: VW37QGRAUI5FBZELMVSHNN7PNOFWT4Q7 X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644514155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=sOiwEnpgU/JS6t75n5ZFfJ99E8psQBsPBrrdY5QZtew=; b=PKHHRHDL2n0Q/DO3M4ODbsEFdjdi6vImGP/T6cwmSVBxggEtTDj83igHytl44Ntoq82Y+V Q1+6H7BQi4ySFdr5ClY9kMbe/yEwVKx4Yiucf/Oy1jvF4nlhymHbCImGMooSeLADDyQqZ8 7Wi6Mnl5ww1Y7N42niWKgtHZY57oXoaHbwhAWk9MDucc1qfbLLTCeNttjsc5S3u/GiBnUT EQLK9H9paZ4vauhneko/XnWbFtUm2DCpDHltEHyMtjRdrvj5zS1rxUpVyHIwB1r519RVXp DP9qhkYH+WNVkMVBonAQlWP0H7N/BuacvU6F2cAuTvcQRWBZjkDJqVXkFCrCNg== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1644514155; a=rsa-sha256; cv=fail; b=VxRtYXlNBm2TydICGqRsTKoPefB0G3sC+FbLHORI24sJjFjs3dGdOuuaqBAY9RhA3IteWS fIqDB/zOMQiMxHuLk3u4JcjuZVlTUUawJyiPB1meHYVuv2usuSReHpn/UkyVJUCUtrmGIr s3d98TKsElww59efqheG1okgiZQ7T48KJPQZb/Vx8IqHw1EI24uNNsIPNibFnJbYxY6rI+ 8iwO3oV+ycn+vyhCqQHyLjM5CmdxhFP3C+7M+ZSFCgefk3qNbe96mxcASglDptx98lTD2o MWMY+11mX7lix60XU7VON4yXsGKk58iebNH827oFOdRKy9qDaoW9fyR9QPIfRw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=dEqBQE3e; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.84 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=dEqBQE3e; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: B3E3227787 X-Spam-Score: -0.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: nKb/lEZpEfz7 On Thu, Feb 10 2022, Michael J. Gruber wrote: > Tomi Ollila venit, vidit, dixit 2022-02-09 21:50:35: >> On Wed, Feb 09 2022, Michael J. Gruber wrote: >> >> > If gdb is present but for some reason `atomicity.py` fails to write to >> > the output file then the test fails with some ugly bash errors in the >> > wrong places (because the outcount variable is empty). >> > >> > Therefore, set up the outcount file with `0` to get the test script to >> > rund and the test to fail fpr a clearer reason. >> > >> > Background: We noticed this with arch armhfp emulated on x86_64 in >> > Fedora's COPR test build environment. >> > >> > Signed-off-by: Michael J Gruber >> > --- >> > test/T380-atomicity.sh | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh >> > index 49df5c38..caac28a3 100755 >> > --- a/test/T380-atomicity.sh >> > +++ b/test/T380-atomicity.sh >> > @@ -64,6 +64,7 @@ if test_require_external_prereq gdb; then >> > # -tty /dev/null works around a conflict between the 'timeout' wrapper >> > # and gdb's attempt to control the TTY. >> > export MAIL_DIR >> > + echo -n 0 > outcount >> >> printf 0 > outcount (is my suggestion) > > Would by mine, too :) > Again, this is not the style of T380 which uses echo exclusively so far. Right, I did not see the surrouding code in this series :D (the only thing I saw use of $(expr ...) -- which I put to my notes of trivial fixes one could do in (distant?) future) Perhaps the series is good then (and perhaps incremental changing of expected - actual order is better than newer changing any of those) Tomi