From: Michael J Gruber <git@grubix.eu>
To: notmuch@notmuchmail.org
Subject: [PATCH 2/4] test: due not pass T380.1 for the wrong reasons
Date: Wed, 9 Feb 2022 12:52:34 +0100 [thread overview]
Message-ID: <8d483901f3cf9bee86d7359ff1d665943adcd31b.1644406756.git.git@grubix.eu> (raw)
In-Reply-To: <cover.1644406756.git.git@grubix.eu>
If gdb is missing then some files are never written to so that the
comparisons of non-existing files succeeds for the wrong reason,
claiming that `notmch new` is idempotent when it was in fact never run.
Catch this and (for lack of a better spot) set up the files with a
reason for the FAIL.
Signed-off-by: Michael J Gruber <git@grubix.eu>
---
test/T380-atomicity.sh | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh
index a6f1e037..7f618062 100755
--- a/test/T380-atomicity.sh
+++ b/test/T380-atomicity.sh
@@ -90,6 +90,10 @@ if test_require_external_prereq gdb; then
i=$(expr $end - 1)
fi
done
+else
+ echo -n "Test fails due to missing gdb." > searchall
+ echo -n > expectall
+ outcount=0
fi
test_begin_subtest '"notmuch new" is idempotent under arbitrary aborts'
--
2.35.1.306.ga00bde9711
next prev parent reply other threads:[~2022-02-09 11:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 11:52 [PATCH 0/4] test: T380 rework Michael J Gruber
2022-02-09 11:52 ` [PATCH 1/4] test: correct comparison order in T380 Michael J Gruber
2022-02-09 20:47 ` Tomi Ollila
2022-02-10 10:05 ` Michael J Gruber
2022-02-09 11:52 ` Michael J Gruber [this message]
2022-02-09 20:49 ` [PATCH 2/4] test: due not pass T380.1 for the wrong reasons Tomi Ollila
2022-02-10 10:08 ` Michael J Gruber
2022-02-09 22:12 ` David Bremner
2022-02-10 10:56 ` Michael J Gruber
2022-02-12 20:42 ` David Bremner
2022-02-19 21:50 ` Tomi Ollila
2022-02-19 23:02 ` David Bremner
2022-02-20 10:58 ` Michael J Gruber
2022-02-20 12:58 ` David Bremner
2022-02-09 11:52 ` [PATCH 3/4] test: reword T380.2 to be clearer Michael J Gruber
2022-02-09 20:49 ` Tomi Ollila
2022-02-09 11:52 ` [PATCH 4/4] test: set up the outcount file for T380.1 Michael J Gruber
2022-02-09 20:50 ` Tomi Ollila
2022-02-10 10:13 ` Michael J Gruber
2022-02-10 17:29 ` Tomi Ollila
2023-11-24 17:05 ` [PATCH 0/4] test: T380 rework Michael J Gruber
2023-11-24 22:20 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d483901f3cf9bee86d7359ff1d665943adcd31b.1644406756.git.git@grubix.eu \
--to=git@grubix.eu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).