* [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify
@ 2020-03-18 7:47 Daniel Kahn Gillmor
2020-03-18 19:57 ` Tomi Ollila
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Kahn Gillmor @ 2020-03-18 7:47 UTC (permalink / raw)
To: Notmuch Mail
GMIME_ENCRYPT_NONE and GMIME_VERIFY_NONE have the same value, but they
are different enumerated types. So in C, this is a cosmetic change,
but it is technically correct if we only had stricter typing.
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
---
mime-node.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mime-node.c b/mime-node.c
index d4996a33..e531078c 100644
--- a/mime-node.c
+++ b/mime-node.c
@@ -201,7 +201,7 @@ node_verify (mime_node_t *node, GMimeObject *part)
node->verify_attempted = true;
node->sig_list = g_mime_multipart_signed_verify (
- GMIME_MULTIPART_SIGNED (part), GMIME_ENCRYPT_NONE, &err);
+ GMIME_MULTIPART_SIGNED (part), GMIME_VERIFY_NONE, &err);
if (node->sig_list)
set_signature_list_destructor (node);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify
2020-03-18 7:47 [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify Daniel Kahn Gillmor
@ 2020-03-18 19:57 ` Tomi Ollila
2020-03-20 2:00 ` David Bremner
0 siblings, 1 reply; 3+ messages in thread
From: Tomi Ollila @ 2020-03-18 19:57 UTC (permalink / raw)
To: Daniel Kahn Gillmor, Notmuch Mail
On Wed, Mar 18 2020, Daniel Kahn Gillmor wrote:
> GMIME_ENCRYPT_NONE and GMIME_VERIFY_NONE have the same value, but they
> are different enumerated types. So in C, this is a cosmetic change,
> but it is technically correct if we only had stricter typing.
Change consistent with '@@ node_verify', LGTM.
Tomi
>
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> ---
> mime-node.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mime-node.c b/mime-node.c
> index d4996a33..e531078c 100644
> --- a/mime-node.c
> +++ b/mime-node.c
> @@ -201,7 +201,7 @@ node_verify (mime_node_t *node, GMimeObject *part)
>
> node->verify_attempted = true;
> node->sig_list = g_mime_multipart_signed_verify (
> - GMIME_MULTIPART_SIGNED (part), GMIME_ENCRYPT_NONE, &err);
> + GMIME_MULTIPART_SIGNED (part), GMIME_VERIFY_NONE, &err);
>
> if (node->sig_list)
> set_signature_list_destructor (node);
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify
2020-03-18 19:57 ` Tomi Ollila
@ 2020-03-20 2:00 ` David Bremner
0 siblings, 0 replies; 3+ messages in thread
From: David Bremner @ 2020-03-20 2:00 UTC (permalink / raw)
To: Tomi Ollila, Daniel Kahn Gillmor, Notmuch Mail
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Wed, Mar 18 2020, Daniel Kahn Gillmor wrote:
>
>> GMIME_ENCRYPT_NONE and GMIME_VERIFY_NONE have the same value, but they
>> are different enumerated types. So in C, this is a cosmetic change,
>> but it is technically correct if we only had stricter typing.
Pushed. I await with interest the port to Agda.
d
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-20 2:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18 7:47 [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify Daniel Kahn Gillmor
2020-03-18 19:57 ` Tomi Ollila
2020-03-20 2:00 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).