unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify
Date: Wed, 18 Mar 2020 21:57:15 +0200	[thread overview]
Message-ID: <m2mu8djv1g.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20200318074748.366383-1-dkg@fifthhorseman.net>

On Wed, Mar 18 2020, Daniel Kahn Gillmor wrote:

> GMIME_ENCRYPT_NONE and GMIME_VERIFY_NONE have the same value, but they
> are different enumerated types.  So in C, this is a cosmetic change,
> but it is technically correct if we only had stricter typing.

Change consistent with '@@ node_verify', LGTM.

Tomi

>
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> ---
>  mime-node.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mime-node.c b/mime-node.c
> index d4996a33..e531078c 100644
> --- a/mime-node.c
> +++ b/mime-node.c
> @@ -201,7 +201,7 @@ node_verify (mime_node_t *node, GMimeObject *part)
>  
>      node->verify_attempted = true;
>      node->sig_list = g_mime_multipart_signed_verify (
> -	GMIME_MULTIPART_SIGNED (part), GMIME_ENCRYPT_NONE, &err);
> +	GMIME_MULTIPART_SIGNED (part), GMIME_VERIFY_NONE, &err);
>  
>      if (node->sig_list)
>  	set_signature_list_destructor (node);
> -- 
> 2.25.1

  reply	other threads:[~2020-03-18 19:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18  7:47 [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify Daniel Kahn Gillmor
2020-03-18 19:57 ` Tomi Ollila [this message]
2020-03-20  2:00   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2mu8djv1g.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=dkg@fifthhorseman.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).