From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 625F96DE0EB0 for ; Wed, 18 Mar 2020 00:48:00 -0700 (PDT) Authentication-Results: arlo.cworth.org; dkim=permerror (0-bit key) header.d=fifthhorseman.net header.i=@fifthhorseman.net header.b="fN8Jxbpn"; dkim=pass (2048-bit key; unprotected) header.d=fifthhorseman.net header.i=@fifthhorseman.net header.b="QJ6ROTfd"; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -1.232 X-Spam-Level: X-Spam-Status: No, score=-1.232 tagged_above=-999 required=5 tests=[AWL=0.023, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_BL_SPAMCOP_NET=1.246, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q3FAIVq-VHpo for ; Wed, 18 Mar 2020 00:47:59 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 09D606DE0EA6 for ; Wed, 18 Mar 2020 00:47:58 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1584517677; h=from : to : subject : date : message-id : mime-version : content-transfer-encoding : from; bh=L8RaKZFaGH1W9ixFy7aPqJrV+3bVuuV6F7iZlY3ExtQ=; b=fN8JxbpnhEFOplS/yM1yNtD8eeM6Eu/3gfGJQg9P+ad3w1rjDF6PpPdfp8VMBC4DWKxct qRYNPG+4X4DBnCFDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1584517677; h=from : to : subject : date : message-id : mime-version : content-transfer-encoding : from; bh=L8RaKZFaGH1W9ixFy7aPqJrV+3bVuuV6F7iZlY3ExtQ=; b=QJ6ROTfdiT0WbIfQgnwGQVovnVRyrSjWv9uJufxxON6fGrrSrO0zlRt1wdvH5RjmszASQ gO1R7nuhc65gprTX9YEbWytAwwnZBGTyoKFsPic4shToZ/euy0ZLrmTY1UizCH7pmJVZuw5 NZNDZqmzHiOmcmW/htgQveDIBAtRETrpqc5BSLxEoJJsIX1Rnu8+W6wFATCgOou/tnGIldz 3aeU2jv5qeT/lbdazFojcoM1egs+jhcAOOTHbgIx+dLRV3i/N3b8gjcuoOGdJbRCWfQ/UTc oGPjUvDNEsw2dVe8USKc3/DAtHeG0mbbPu4MOxJ0Eo8ZztXLZUXXYj2kWDsA== Received: from fifthhorseman.net (unknown [IPv6:2001:470:1f07:60d:d029:17ff:fe92:f0c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 297E7F9A5 for ; Wed, 18 Mar 2020 03:47:54 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 395162028A; Wed, 18 Mar 2020 03:47:48 -0400 (EDT) From: Daniel Kahn Gillmor To: Notmuch Mail Subject: [PATCH] mime-node: Pass the correct flags to g_mime_multipart_signed_verify Date: Wed, 18 Mar 2020 03:47:48 -0400 Message-Id: <20200318074748.366383-1-dkg@fifthhorseman.net> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2020 07:48:00 -0000 GMIME_ENCRYPT_NONE and GMIME_VERIFY_NONE have the same value, but they are different enumerated types. So in C, this is a cosmetic change, but it is technically correct if we only had stricter typing. Signed-off-by: Daniel Kahn Gillmor --- mime-node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mime-node.c b/mime-node.c index d4996a33..e531078c 100644 --- a/mime-node.c +++ b/mime-node.c @@ -201,7 +201,7 @@ node_verify (mime_node_t *node, GMimeObject *part) node->verify_attempted = true; node->sig_list = g_mime_multipart_signed_verify ( - GMIME_MULTIPART_SIGNED (part), GMIME_ENCRYPT_NONE, &err); + GMIME_MULTIPART_SIGNED (part), GMIME_VERIFY_NONE, &err); if (node->sig_list) set_signature_list_destructor (node); -- 2.25.1