From: David Bremner <david@tethera.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Cc: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Subject: Parsing regression with gmime-2.6?
Date: Tue, 06 Mar 2012 18:04:50 -0400 [thread overview]
Message-ID: <87wr6xmlml.fsf@zancas.localnet> (raw)
In-Reply-To: <1331058417-13776-1-git-send-email-amdragon@mit.edu>
On Tue, 6 Mar 2012 18:26:57 +0000, Austin Clements <amdragon@MIT.EDU> wrote:
> ---
> mime-node.c | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
There seems to be something weird going on with gmime-2.6; maybe we
didn't catch some api change?
I noticed a surprising number of messages failing to parse, so I wrote a
script to take a random sample of 1000 messages and run notmuch show on
them. A shocking 650 to 700 of them fail to parse with gmime-2.6. No
failures are reported with gmime-2.4.
I tried with your patch, and then took a couple of the id's it reported
and tried them on the release branch, and the failed (segfaulted) there.
I don't know at this point if it is something specific to my setup, or
my testing methedology is just hare-brained, but I'd appreciate it if
people could try austin's patch, gmime-2.6, and my script on their
mailstore and let me know how many id's it spits out (if any).
#!/usr/bin/bash
NOTMUCH=${NOTMUCH-notmuch}
if [ ! -f test-ids.txt ]; then
notmuch dump | shuf -n 1000 | cut -f1 -d' ' > test-ids.txt
else
echo "Re-using test-ids.txt" 1>&2
fi
while read id; do
output=$(${NOTMUCH} show --format=json id:$id 2>&1 1>/dev/null)
case "$output" in
"Failed to parse"*)
echo $id
;;
*)
esac
done <test-ids.txt
next prev parent reply other threads:[~2012-03-06 22:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 21:39 Internal error on line 296 of mime-node.c David Bremner
2012-03-01 21:57 ` Austin Clements
2012-03-02 2:35 ` David Bremner
2012-03-02 2:35 ` [PATCH 1/2] test: utility function to add a pre-generated message to the database David Bremner
2012-03-02 2:35 ` [PATCH 2/2] test: add new test file for mime parsing David Bremner
2012-03-06 18:26 ` [PATCH] Handle errors in mime_node_open Austin Clements
2012-03-06 22:04 ` David Bremner [this message]
2012-03-08 15:35 ` [WIP PATCH] debugging gmime-2.6 fail David Bremner
2012-03-08 18:08 ` David Bremner
2012-03-08 18:27 ` Parsing regression with gmime-2.6? Jameson Graef Rollins
2012-03-08 20:30 ` Daniel Kahn Gillmor
2012-03-08 21:32 ` Jameson Graef Rollins
2012-03-08 21:40 ` Daniel Kahn Gillmor
2012-03-08 21:59 ` Jameson Graef Rollins
2012-03-08 21:48 ` [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime David Bremner
2012-03-08 22:05 ` Jameson Graef Rollins
2012-03-09 10:50 ` Tomi Ollila
2012-03-09 13:31 ` [PATCH] mime_node_open: skip envelope from lines at the start of messages David Bremner
2012-03-09 13:56 ` David Bremner
2012-03-09 16:20 ` Daniel Kahn Gillmor
2012-03-10 13:25 ` David Bremner
2012-03-10 14:45 ` Tomi Ollila
2012-03-11 1:51 ` [PATCH] Handle errors in mime_node_open David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wr6xmlml.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=amdragon@MIT.EDU \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).