unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: [WIP PATCH] debugging gmime-2.6 fail.
Date: Thu,  8 Mar 2012 11:35:35 -0400	[thread overview]
Message-ID: <1331220935-6553-1-git-send-email-david@tethera.net> (raw)
In-Reply-To: <87wr6xmlml.fsf@zancas.localnet>

From: David Bremner <bremner@debian.org>

Try parsing again as mbox if the first one failed.
---
I ran out of time for the moment, but the following patch gets me down from 
4196 failures on the notmuch mailing list to 3422.

I'm leaning to reverting back to gmime-2.4 for the Debian 0.12 package
if I can't sort this out.

 mime-node.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/mime-node.c b/mime-node.c
index a95bdab..1d3a184 100644
--- a/mime-node.c
+++ b/mime-node.c
@@ -111,8 +111,17 @@ mime_node_open (const void *ctx, notmuch_message_t *message,
 	goto DONE;
     }
 
+
     mctx->mime_message = g_mime_parser_construct_message (mctx->parser);
     if (!mctx->mime_message) {
+	/*
+	 * Parsing failed, let's try again as an mbox
+	 */
+	mctx->parser = g_mime_parser_new_with_stream (mctx->stream);
+	mctx->mime_message = g_mime_parser_construct_message (mctx->parser);
+    }
+
+    if (!mctx->mime_message) {
 	fprintf (stderr, "Failed to parse %s\n", filename);
 	status = NOTMUCH_STATUS_FILE_ERROR;
 	goto DONE;
-- 
1.7.9.1

  reply	other threads:[~2012-03-08 15:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-01 21:39 Internal error on line 296 of mime-node.c David Bremner
2012-03-01 21:57 ` Austin Clements
2012-03-02  2:35   ` David Bremner
2012-03-02  2:35     ` [PATCH 1/2] test: utility function to add a pre-generated message to the database David Bremner
2012-03-02  2:35     ` [PATCH 2/2] test: add new test file for mime parsing David Bremner
2012-03-06 18:26 ` [PATCH] Handle errors in mime_node_open Austin Clements
2012-03-06 22:04   ` Parsing regression with gmime-2.6? David Bremner
2012-03-08 15:35     ` David Bremner [this message]
2012-03-08 18:08       ` [WIP PATCH] debugging gmime-2.6 fail David Bremner
2012-03-08 18:27     ` Parsing regression with gmime-2.6? Jameson Graef Rollins
2012-03-08 20:30     ` Daniel Kahn Gillmor
2012-03-08 21:32       ` Jameson Graef Rollins
2012-03-08 21:40         ` Daniel Kahn Gillmor
2012-03-08 21:59           ` Jameson Graef Rollins
2012-03-08 21:48       ` [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime David Bremner
2012-03-08 22:05         ` Jameson Graef Rollins
2012-03-09 10:50         ` Tomi Ollila
2012-03-09 13:31           ` [PATCH] mime_node_open: skip envelope from lines at the start of messages David Bremner
2012-03-09 13:56           ` David Bremner
2012-03-09 16:20             ` Daniel Kahn Gillmor
2012-03-10 13:25               ` David Bremner
2012-03-10 14:45                 ` Tomi Ollila
2012-03-11  1:51   ` [PATCH] Handle errors in mime_node_open David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331220935-6553-1-git-send-email-david@tethera.net \
    --to=david@tethera.net \
    --cc=bremner@debian.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).