From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0990B431FBC for ; Tue, 6 Mar 2012 14:04:59 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EKZnNC1WucaA for ; Tue, 6 Mar 2012 14:04:58 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 69209431FAE for ; Tue, 6 Mar 2012 14:04:58 -0800 (PST) Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net ([142.166.230.117] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1S52V6-0004R0-Jc; Tue, 06 Mar 2012 18:04:56 -0400 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1S52V0-0007wB-Sn; Tue, 06 Mar 2012 18:04:50 -0400 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Parsing regression with gmime-2.6? In-Reply-To: <1331058417-13776-1-git-send-email-amdragon@mit.edu> References: <87d38w2e7h.fsf@zancas.localnet> <1331058417-13776-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.11.1+265~g4110e32 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Tue, 06 Mar 2012 18:04:50 -0400 Message-ID: <87wr6xmlml.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam_bar: - Cc: Daniel Kahn Gillmor X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2012 22:04:59 -0000 On Tue, 6 Mar 2012 18:26:57 +0000, Austin Clements wrote: > --- > mime-node.c | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) There seems to be something weird going on with gmime-2.6; maybe we didn't catch some api change? I noticed a surprising number of messages failing to parse, so I wrote a script to take a random sample of 1000 messages and run notmuch show on them. A shocking 650 to 700 of them fail to parse with gmime-2.6. No failures are reported with gmime-2.4. I tried with your patch, and then took a couple of the id's it reported and tried them on the release branch, and the failed (segfaulted) there. I don't know at this point if it is something specific to my setup, or my testing methedology is just hare-brained, but I'd appreciate it if people could try austin's patch, gmime-2.6, and my script on their mailstore and let me know how many id's it spits out (if any). #!/usr/bin/bash NOTMUCH=${NOTMUCH-notmuch} if [ ! -f test-ids.txt ]; then notmuch dump | shuf -n 1000 | cut -f1 -d' ' > test-ids.txt else echo "Re-using test-ids.txt" 1>&2 fi while read id; do output=$(${NOTMUCH} show --format=json id:$id 2>&1 1>/dev/null) case "$output" in "Failed to parse"*) echo $id ;; *) esac done