From: Austin Clements <amdragon@MIT.EDU>
To: David Bremner <bremner@unb.ca>
Cc: notmuch <notmuch@notmuchmail.org>
Subject: Re: Internal error on line 296 of mime-node.c
Date: Thu, 1 Mar 2012 16:57:38 -0500 [thread overview]
Message-ID: <20120301215738.GA7466@mit.edu> (raw)
In-Reply-To: <87d38w2e7h.fsf@zancas.localnet>
Quoth David Bremner on Mar 01 at 5:39 pm:
>
> In the current master (4fa77d031) I get a sort-of double crash on the
> attached message.
>
> The internal error on line 296 is reached, indicating some kind of bug,
> but then the G_OBJECT_TYPE crashes becase parent->part is null.
>
> The message is probably crap, I created it from another "real" message
> from some business that causes the same problem.
>
> (gdb) bt
> #0 0x0000000000416850 in mime_node_child (parent=0x8425fa0, child=0)
> at mime-node.c:296
> #1 0x00000000004137f1 in format_part_json (ctx=0x8425f10, node=0x8425fa0,
> first=1) at notmuch-show.c:669
> #2 0x0000000000413e54 in format_part_json_entry (ctx=0x8425f10,
> node=0x8425fa0, indent=0, params=0x7ff000470) at notmuch-show.c:758
> #3 0x0000000000413f0f in show_message (ctx=0x8367680, format=0x6327e0, message=
> 0x83e9830, indent=0, params=0x7ff000470) at notmuch-show.c:776
> #4 0x0000000000414165 in show_messages (ctx=0x8367680, format=0x6327e0,
> messages=0x8425e70, indent=0, params=0x7ff000470) at notmuch-show.c:835
> #5 0x00000000004145f5 in do_show (ctx=0x8367680, query=0x83b36b0,
> format=0x6327e0, params=0x7ff000470) at notmuch-show.c:956
> #6 0x0000000000414ba7 in notmuch_show_command (ctx=0x8367680, argc=3,
> argv=0x7ff000660) at notmuch-show.c:1089
> #7 0x000000000040a9fe in main (argc=4, argv=0x7ff000658) at notmuch.c:294
> (gdb) print *parent
> $3 = {part = 0x0, envelope_file = 0x83e9830, envelope_part = 0x0,
> nchildren = 1, parent = 0x0, part_num = 0, decrypt_attempted = 0,
> decrypt_success = 0, verify_attempted = 0, sig_list = 0x0, ctx = 0x8426090,
> decrypted_child = 0x0, next_child = 0, next_part_num = 1}
For the record, this is because g_mime_parser_construct_message in
mime_node_open is returning NULL. mime_node_open should be checking
for this as well as errors from the other GMime functions it calls.
(Unfortunately, there appears to be no way to ask GMime *what* went
wrong; it just returns NULL.)
next prev parent reply other threads:[~2012-03-01 21:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 21:39 Internal error on line 296 of mime-node.c David Bremner
2012-03-01 21:57 ` Austin Clements [this message]
2012-03-02 2:35 ` David Bremner
2012-03-02 2:35 ` [PATCH 1/2] test: utility function to add a pre-generated message to the database David Bremner
2012-03-02 2:35 ` [PATCH 2/2] test: add new test file for mime parsing David Bremner
2012-03-06 18:26 ` [PATCH] Handle errors in mime_node_open Austin Clements
2012-03-06 22:04 ` Parsing regression with gmime-2.6? David Bremner
2012-03-08 15:35 ` [WIP PATCH] debugging gmime-2.6 fail David Bremner
2012-03-08 18:08 ` David Bremner
2012-03-08 18:27 ` Parsing regression with gmime-2.6? Jameson Graef Rollins
2012-03-08 20:30 ` Daniel Kahn Gillmor
2012-03-08 21:32 ` Jameson Graef Rollins
2012-03-08 21:40 ` Daniel Kahn Gillmor
2012-03-08 21:59 ` Jameson Graef Rollins
2012-03-08 21:48 ` [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime David Bremner
2012-03-08 22:05 ` Jameson Graef Rollins
2012-03-09 10:50 ` Tomi Ollila
2012-03-09 13:31 ` [PATCH] mime_node_open: skip envelope from lines at the start of messages David Bremner
2012-03-09 13:56 ` David Bremner
2012-03-09 16:20 ` Daniel Kahn Gillmor
2012-03-10 13:25 ` David Bremner
2012-03-10 14:45 ` Tomi Ollila
2012-03-11 1:51 ` [PATCH] Handle errors in mime_node_open David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301215738.GA7466@mit.edu \
--to=amdragon@mit.edu \
--cc=bremner@unb.ca \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).