From: Mark Walters <markwalters1009@gmail.com>
To: Michal Sojka <sojkam1@fel.cvut.cz>, Jani Nikula <jani@nikula.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Mention race condition safety in user visible documentation
Date: Tue, 21 Feb 2012 08:45:00 +0000 [thread overview]
Message-ID: <87vcn0tw1f.fsf@qmul.ac.uk> (raw)
In-Reply-To: <87y5rzmg5v.fsf@steelpick.2x.cz>
On Sun, 19 Feb 2012 08:33:00 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> On Sun, 19 Feb 2012, Jani Nikula wrote:
> > On Feb 19, 2012 12:44 AM, "Michal Sojka" <sojkam1@fel.cvut.cz> wrote:
> > >
> > > After recent rework of a/A/x/X key bindings, the important paragraph in
> > > documentation of `notmuch-show-archive-thread' stayed hidden from users,
> > > because no key is bound to this function.
> > >
> > > This patch copies the important paragraph to the documentation of
> > > functions currently bound to keys.
> >
> > Hi Michal, this was discussed earlier, and Dmitry convinced me that the
> > code does exactly what the user expects it to do (archives only the
> > messages in the buffer) so it would be unnecessary and confusing to have
> > this documentation. It could be added as a comment for developers I
> > guess.
>
> I'm not sure. As a developer, I'm used to think about race conditions
> and the mentioned documentation sounds very racy to me. I guess a lot of
> other notmuch users are developers who may think the same.
>
> > > (defun notmuch-show-archive-thread-then-next ()
> > > - "Archive each message in thread, then show next thread from search."
>
> What about changing it to "Archive each message in the current buffer, ..."?
I like this suggested wording (or perhaps "Archive all messages in the
current buffer, ..."). I do not think `Archive each message in thread' is
completely clear (is the thread the thread as it is now or as it was
then).
Best wishes
Mark
next prev parent reply other threads:[~2012-02-21 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-18 22:44 [PATCH] emacs: Mention race condition safety in user visible documentation Michal Sojka
2012-02-19 7:05 ` Jani Nikula
2012-02-19 7:33 ` Michal Sojka
2012-02-21 8:45 ` Mark Walters [this message]
2012-02-21 9:15 ` Michal Sojka
2012-02-22 20:04 ` Pieter Praet
2012-02-22 20:09 ` [PATCH] emacs: correct `notmuch-search-mode's docstring wrt `notmuch-search-tag-all' Pieter Praet
2012-04-16 19:18 ` Mark Walters
2012-09-02 2:36 ` David Bremner
2012-03-01 2:49 ` [PATCH] emacs: Mention race condition safety in user visible documentation David Bremner
2012-03-01 17:13 ` Pieter Praet
2012-03-01 18:21 ` David Bremner
2012-03-01 18:26 ` David Bremner
2012-02-28 18:39 ` Pieter Praet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcn0tw1f.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).