Re: [PATCH] emacs: correct `notmuch-search-mode's docstring wrt `notmuch-search-tag-all'

[Mark Walters <markwalters1009@gmail.com>]

On Wed, 22 Feb 2012, Pieter Praet <pieter@praet.org> wrote:
> * emacs/notmuch.el (notmuch-search-mode):
>   `notmuch-search-tag-all' currently uses the current query string
>   instead of `notmuch-search-find-thread-id-region-search', which
>   might cause a race condition.

This looks correct and is a significant improvement in wording as it
also correct the fact that * in search view (tag-all) operates on
matching messages not matching threads.

+1

Best wishes

Mark

> ---
>  emacs/notmuch.el |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index f851c6f..0a9fffd 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -435,8 +435,9 @@ (defun notmuch-search-mode ()
>  Pressing \\[notmuch-search-show-thread] on any line displays that thread. The '\\[notmuch-search-add-tag]' and '\\[notmuch-search-remove-tag]'
>  keys can be used to add or remove tags from a thread. The '\\[notmuch-search-archive-thread]' key
>  is a convenience for archiving a thread (removing the \"inbox\"
> -tag). The '\\[notmuch-search-tag-all]' key can be used to add or remove a tag from all
> -threads in the current buffer.
> +tag). The '\\[notmuch-search-tag-all]' key can be used to add and/or remove tags from all
> +messages (as opposed to threads) that match the current query.  Use with caution, as this
> +will also tag matching messages that arrived *after* constructing the buffer.
>  
>  Other useful commands are '\\[notmuch-search-filter]' for filtering the current search
>  based on an additional query string, '\\[notmuch-search-filter-by-tag]' for filtering to include
> -- 
> 1.7.8.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch