From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A7046431FAF for ; Tue, 21 Feb 2012 00:43:37 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DMRZT+L+zyFQ for ; Tue, 21 Feb 2012 00:43:33 -0800 (PST) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 8D3EC431FAE for ; Tue, 21 Feb 2012 00:43:33 -0800 (PST) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1RzlJl-0006ck-6x; Tue, 21 Feb 2012 08:43:29 +0000 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1RzlJl-0004To-0A; Tue, 21 Feb 2012 08:43:25 +0000 From: Mark Walters To: Michal Sojka , Jani Nikula Subject: Re: [PATCH] emacs: Mention race condition safety in user visible documentation In-Reply-To: <87y5rzmg5v.fsf@steelpick.2x.cz> References: <1329605059-15358-1-git-send-email-sojkam1@fel.cvut.cz> <87y5rzmg5v.fsf@steelpick.2x.cz> User-Agent: Notmuch/0.11.1+206~g3b67774 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Tue, 21 Feb 2012 08:45:00 +0000 Message-ID: <87vcn0tw1f.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 94.192.233.223 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: 1bc024877d1328992dec7147d4731c00 (of first 20000 bytes) X-SpamAssassin-Score: -1.8 X-SpamAssassin-SpamBar: - X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -1.8 points. Summary of the scoring: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [138.37.6.40 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay * domain * 0.5 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2012 08:43:37 -0000 On Sun, 19 Feb 2012 08:33:00 +0100, Michal Sojka wrote: > On Sun, 19 Feb 2012, Jani Nikula wrote: > > On Feb 19, 2012 12:44 AM, "Michal Sojka" wrote: > > > > > > After recent rework of a/A/x/X key bindings, the important paragraph in > > > documentation of `notmuch-show-archive-thread' stayed hidden from users, > > > because no key is bound to this function. > > > > > > This patch copies the important paragraph to the documentation of > > > functions currently bound to keys. > > > > Hi Michal, this was discussed earlier, and Dmitry convinced me that the > > code does exactly what the user expects it to do (archives only the > > messages in the buffer) so it would be unnecessary and confusing to have > > this documentation. It could be added as a comment for developers I > > guess. > > I'm not sure. As a developer, I'm used to think about race conditions > and the mentioned documentation sounds very racy to me. I guess a lot of > other notmuch users are developers who may think the same. > > > > (defun notmuch-show-archive-thread-then-next () > > > - "Archive each message in thread, then show next thread from search." > > What about changing it to "Archive each message in the current buffer, ..."? I like this suggested wording (or perhaps "Archive all messages in the current buffer, ..."). I do not think `Archive each message in thread' is completely clear (is the thread the thread as it is now or as it was then). Best wishes Mark