unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Pieter Praet <pieter@praet.org>
To: Michal Sojka <sojkam1@fel.cvut.cz>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCH] emacs: correct `notmuch-search-mode's docstring wrt `notmuch-search-tag-all'
Date: Wed, 22 Feb 2012 21:09:14 +0100	[thread overview]
Message-ID: <1329941354-28121-1-git-send-email-pieter@praet.org> (raw)
In-Reply-To: <8762ey8wil.fsf@praet.org>

* emacs/notmuch.el (notmuch-search-mode):
  `notmuch-search-tag-all' currently uses the current query string
  instead of `notmuch-search-find-thread-id-region-search', which
  might cause a race condition.
---
 emacs/notmuch.el |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index f851c6f..0a9fffd 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -435,8 +435,9 @@ (defun notmuch-search-mode ()
 Pressing \\[notmuch-search-show-thread] on any line displays that thread. The '\\[notmuch-search-add-tag]' and '\\[notmuch-search-remove-tag]'
 keys can be used to add or remove tags from a thread. The '\\[notmuch-search-archive-thread]' key
 is a convenience for archiving a thread (removing the \"inbox\"
-tag). The '\\[notmuch-search-tag-all]' key can be used to add or remove a tag from all
-threads in the current buffer.
+tag). The '\\[notmuch-search-tag-all]' key can be used to add and/or remove tags from all
+messages (as opposed to threads) that match the current query.  Use with caution, as this
+will also tag matching messages that arrived *after* constructing the buffer.
 
 Other useful commands are '\\[notmuch-search-filter]' for filtering the current search
 based on an additional query string, '\\[notmuch-search-filter-by-tag]' for filtering to include
-- 
1.7.8.1

  reply	other threads:[~2012-02-22 20:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-18 22:44 [PATCH] emacs: Mention race condition safety in user visible documentation Michal Sojka
2012-02-19  7:05 ` Jani Nikula
2012-02-19  7:33   ` Michal Sojka
2012-02-21  8:45     ` Mark Walters
2012-02-21  9:15       ` Michal Sojka
2012-02-22 20:04         ` Pieter Praet
2012-02-22 20:09           ` Pieter Praet [this message]
2012-04-16 19:18             ` [PATCH] emacs: correct `notmuch-search-mode's docstring wrt `notmuch-search-tag-all' Mark Walters
2012-09-02  2:36             ` David Bremner
2012-03-01  2:49         ` [PATCH] emacs: Mention race condition safety in user visible documentation David Bremner
2012-03-01 17:13           ` Pieter Praet
2012-03-01 18:21             ` David Bremner
2012-03-01 18:26               ` David Bremner
2012-02-28 18:39 ` Pieter Praet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329941354-28121-1-git-send-email-pieter@praet.org \
    --to=pieter@praet.org \
    --cc=notmuch@notmuchmail.org \
    --cc=sojkam1@fel.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).