From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3C089431FAF for ; Mon, 16 Apr 2012 12:18:14 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w46WfsFmTH3n for ; Mon, 16 Apr 2012 12:18:13 -0700 (PDT) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 6E29C431FAE for ; Mon, 16 Apr 2012 12:18:13 -0700 (PDT) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1SJrR8-0004cJ-P4; Mon, 16 Apr 2012 20:18:09 +0100 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1SJrR8-0002t6-CW; Mon, 16 Apr 2012 20:18:06 +0100 From: Mark Walters To: Pieter Praet , Michal Sojka Subject: Re: [PATCH] emacs: correct `notmuch-search-mode's docstring wrt `notmuch-search-tag-all' In-Reply-To: <1329941354-28121-1-git-send-email-pieter@praet.org> References: <8762ey8wil.fsf@praet.org> <1329941354-28121-1-git-send-email-pieter@praet.org> User-Agent: Notmuch/0.12+110~gbc97b4a (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 16 Apr 2012 20:18:25 +0100 Message-ID: <87sjg34ha6.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 94.192.233.223 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: 44543f9a73803d42a9ce909f1a2d3bbc (of first 20000 bytes) X-SpamAssassin-Score: -1.8 X-SpamAssassin-SpamBar: - X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -1.8 points. Summary of the scoring: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [138.37.6.40 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay * domain * 0.5 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2012 19:18:14 -0000 On Wed, 22 Feb 2012, Pieter Praet wrote: > * emacs/notmuch.el (notmuch-search-mode): > `notmuch-search-tag-all' currently uses the current query string > instead of `notmuch-search-find-thread-id-region-search', which > might cause a race condition. This looks correct and is a significant improvement in wording as it also correct the fact that * in search view (tag-all) operates on matching messages not matching threads. +1 Best wishes Mark > --- > emacs/notmuch.el | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index f851c6f..0a9fffd 100644 > --- a/emacs/notmuch.el > +++ b/emacs/notmuch.el > @@ -435,8 +435,9 @@ (defun notmuch-search-mode () > Pressing \\[notmuch-search-show-thread] on any line displays that thread. The '\\[notmuch-search-add-tag]' and '\\[notmuch-search-remove-tag]' > keys can be used to add or remove tags from a thread. The '\\[notmuch-search-archive-thread]' key > is a convenience for archiving a thread (removing the \"inbox\" > -tag). The '\\[notmuch-search-tag-all]' key can be used to add or remove a tag from all > -threads in the current buffer. > +tag). The '\\[notmuch-search-tag-all]' key can be used to add and/or remove tags from all > +messages (as opposed to threads) that match the current query. Use with caution, as this > +will also tag matching messages that arrived *after* constructing the buffer. > > Other useful commands are '\\[notmuch-search-filter]' for filtering the current search > based on an additional query string, '\\[notmuch-search-filter-by-tag]' for filtering to include > -- > 1.7.8.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch